From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B917555C34; Fri, 19 Jan 2024 18:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705687337; cv=none; b=WKDtrZr3ZEmm0SYDnLiDNvJbMz19pK8IyWs23CpeGIdIOTB4wpFxSzdgAdMOzDmuiO2eZHydGSMQtJ0AzlqRYnAxsDjB/SykINUB6OKoOTH7Xwxvcv4SehqncXoUGfWBpzw0I8EShqwKtVAzFMUx7001MJZMcbReB05D3C9IDIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705687337; c=relaxed/simple; bh=Vpvm4KefXKpJuW7kEf49W4+4n5jkxACkg0N5JK3WnqM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N6DhFe+UzmipYzHhXBaRfid5KRL3vYpq9gFRxNVmuhzht1vbR/CFzMdi1nBaePoUTYidM+vG7z+iKCEANlToFnI/kQHtE+2Stk6NuVmMub74fCNFmJxuO97lZSzydoxYvqjsnKnMeF2Qx0/onl3QsKwiHsA5cbGdbh4O+Paxxjs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cjEt9H6n; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cjEt9H6n" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-5e54d40cca2so8504477b3.3; Fri, 19 Jan 2024 10:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705687335; x=1706292135; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=cjEt9H6nQ3rscFQE99JWn/WbaxZNRZVLVGOwcnl3R6kZeELFAKpZYrbnQQU9icrDHl Xfz7CYSQr9bJsTehUcj66eCKtWkEm+MrZgngnAe0f8uuoclg3pFmpdW11jlwQtGsViqI /NO52s74ekv49dIafEgDTUrhnS3grveRU2O+WIaarPVnpTtaR8kuDUaA1e0PNj/UEQ2a qS0ddmTKJy4V3iBN11EmxBHi2F/rqaWK/Ez22bajvPeTBsK1Z9QAqJ+8MgFjOYNgB240 bX2YpJxBdZYrcQa7PSsqdFIqu8F+fbxXWZ5xvVCFqA/OMvycIBegHtHHEah291mjGvAh nAJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705687335; x=1706292135; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=iJ9L1jHeb4KvuiOEK+DnlBDJbOcOuUE/dU64qBe/FROgNY1Mgm7Tm3aLl0o6QAViQj EghqOT6eVC/sVR8EWO5WZZHqJHyvYS4CjtNE5TZ73711Fk13tmh6A6ZHiZ2+FxcGVJoB iNrhQysOLN48rqcgzM17rQwmz3pn/VzFiPde+AwezF296cNegcDpS+CoKvYk6KCZu3kw z5uMW1NQIMSnp0l5kQ0jveAkClNPmETvQCnY+ItZllUf3xfC5xPOFaCq9E2IQ5eYXJ4s Dy7HMF/JBB/sTtGzP3uSOZB+1OAcJbQHEorewv5kBMGWeDJGLIv/Kcx7e2AyKfuZauXp +66A== X-Gm-Message-State: AOJu0Ywlkn3q0iTfLeD+8pcK3G5jRYGuR2jimevfJgUqxngMTndIFehO Ctvspv0rug2Z3eybvSn0vmo/A0PNpTXjuH3kRiYglnADnuZ/JJag X-Google-Smtp-Source: AGHT+IH9gcZrsox+4pkG+XVC3K2DCkhX2jg2gbQvfcMMKA5AWgDkyl6PTnKywYab9xjZ/eqMztcaSA== X-Received: by 2002:a0d:e003:0:b0:5ff:9567:c81 with SMTP id j3-20020a0de003000000b005ff95670c81mr286738ywe.22.1705687334593; Fri, 19 Jan 2024 10:02:14 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:2288:782e:a717:678d]) by smtp.gmail.com with ESMTPSA id n68-20020a0dcb47000000b005ff877093easm1389519ywd.143.2024.01.19.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 10:02:14 -0800 (PST) Date: Fri, 19 Jan 2024 10:02:13 -0800 From: Yury Norov To: Shijie Huang Cc: Mike Rapoport , Huang Shijie , gregkh@linuxfoundation.org, patches@amperecomputing.com, rafael@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, kuba@kernel.org, vschneid@redhat.com, mingo@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, tglx@linutronix.de, jpoimboe@kernel.org, ndesaulniers@google.com, mikelley@microsoft.com, mhiramat@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, chenhuacai@kernel.org, jiaxun.yang@flygoat.com, linux-mips@vger.kernel.org, cl@os.amperecomputing.com Subject: Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id Message-ID: References: <20240119033227.14113-1-shijie@os.amperecomputing.com> <1cd078fd-c345-4d85-a92f-04c806c20efa@amperemail.onmicrosoft.com> Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Jan 19, 2024 at 04:50:53PM +0800, Shijie Huang wrote: > > 在 2024/1/19 16:42, Mike Rapoport 写道: > > On Fri, Jan 19, 2024 at 02:46:16PM +0800, Shijie Huang wrote: > > > 在 2024/1/19 12:42, Yury Norov 写道: > > > > This adds another level of indirection, I think. Currently cpu_to_node > > > > is a simple inliner. After the patch it would be a real function with > > > > all the associate overhead. Can you share a bloat-o-meter output here? > > > #./scripts/bloat-o-meter vmlinux vmlinux.new > > > add/remove: 6/1 grow/shrink: 61/51 up/down: 1168/-588 (580) > > > Function                                     old     new   delta > > > numa_update_cpu                              148     244     +96 > > > > > >  ...................................................................................................................................(to many to skip) > > > > > > Total: Before=32990130, After=32990710, chg +0.00% > > It's not only about text size, the indirect call also hurts performance > > The cpu_to_node() is called at very low frequency, most of the times is in > the kernel booting time. That doesn't matter. This function is a simple inliner that dereferences a pointer, and I believe all of us want to keep it simple. > > > > Regardless, I don't think that the approach is correct. As per your > > > > description, some initialization functions erroneously call > > > > cpu_to_node() instead of early_cpu_to_node() which exists specifically > > > > for that case. > > > > > > > > If the above correct, it's clearly a caller problem, and the fix is to > > > > simply switch all those callers to use early version. > > > It is easy to change to early_cpu_to_node() for sched_init(), > > > init_sched_fair_class() > > > > > > and workqueue_init_early(). These three places call the cpu_to_node() in the > > > __init function. > > > > > > > > > But it is a little hard to change the early_trace_init(), since it calls > > > cpu_to_node in the deep > > > > > > function stack: > > > > > >   early_trace_init() --> ring_buffer_alloc() -->rb_allocate_cpu_buffer() > > > > > > > > > For early_trace_init(), we need to change more code. > > > > > > > > > Anyway, If we think it is not a good idea to change the common code, I am > > > oaky too. > > Is there a fundamental reason to have early_cpu_to_node() at all? > > The early_cpu_to_node does not work on some ARCHs (which support the NUMA), > such > > as  SPARC, MIPS and S390. So, your approach wouldn't work either, right? I think you've got a testing bot report on it already... You can make it like this: #ifdef CONFIG_ARCH_NO_EARLY_CPU_TO_NODE #define early_cpu_to_node cpu_to_node #endif > > It seems that all the mappings are known by the end of setup_arch() and the > > initialization of numa_node can be moved earlier. > > > > I would also initialize the numa_node with NUMA_NO_NODE at declaration, > > > > so that if someone calls cpu_to_node() before the variable is properly > > > > initialized at runtime, he'll get NO_NODE, which is obviously an error. > > > Even we set the numa_node with NUMA_NO_NODE, it does not always produce > > > error. You can print this error yourself: #ifndef cpu_to_node static inline int cpu_to_node(int cpu) { int node = per_cpu(numa_node, cpu); #ifdef CONFIG_DEBUG_PER_CPU_MAPS if (node == NUMA_NO_NODE) pr_err(...); #endif return node; } #endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91554C4725D for ; Fri, 19 Jan 2024 18:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hV9Kr1EmkOmXFFuLxLTL+8GvxI4ebtrOb3aYEbvYMhA=; b=jTbFxg76Wz1uhY paluxUMmixNbpoV0H+6dDnChzsCdFVuzl4L3PxO+aVS+5yt8PmNwj2tNV0Yo1UTu1BqkatE79EqVe j8vQQ1reg16IJzpXFOW44KneeDZH6IgeJCqdRBl80hLeVJ1i2sjK+EYPwfwR8ukpOWnuNdn3ksMlQ L2qkp5KDQkI6XPLGqxQUwYbiSPbJLwx0p1D2S5pHTlToGCiVc1mR+Oo47NGHRCcke0DkZlUa7iIxv 9vthWB8AU7rXvrrddUA9Gctg0AbTK15b3k59x0JjrQWEAr1RVMXm9eHGVnHPIhKP1Mz69K0FB++6Z I48CRtzY6nWAVCpHf/3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQtC8-006Kkf-30; Fri, 19 Jan 2024 18:02:20 +0000 Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQtC6-006Kk4-0E; Fri, 19 Jan 2024 18:02:19 +0000 Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5f68af028afso8915877b3.2; Fri, 19 Jan 2024 10:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705687335; x=1706292135; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=OEi993k+6f5Xjnmhh5XDgRGc91MGh9eggssk/yOPXTs2UfUaVpP5lzW69Hl4G5GMMQ VwPVUgfQqa/UvHy1oOzkoTRRfaB2oWakam02ywjlhvJ9mBrOPfVv/buxbj++rll09dmT 2lisP8IaZxLwjql2wwWpaC0uBMTlrXtpotcHKlSLXNOYcXygq4zeKL/H+tl42cBaUkMr y0Iwxdu2iI6rKWTAptUrXNiGTNHryAAX/R5+g0YVdsCCDGCegsNDfYbYw35jKQaPEcFP ROnQiOMFq+u8yqnXflTLYHIRUczLkbXHnje3f7rlikLyA/Usjr0d20riiRgp7CPFlwE5 yHxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705687335; x=1706292135; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=b9bzniPGTp90Teth2ah1Na6bWqmZRf55dNWYr7UvZBB9b3g0sNV3mZNad3dwtwfkOY mN+WvmBEJj5yuUKpoUtrCCt2fheW9qwoUMsU2rYxr3mzYr45QLrnlLdPYmBfCTjl7xhE dyRS+38LQ01Q5yqmPZ3ZByCjcJZfmm3wdL5auRsGYaMVI5cxCoM2xNZHVn2fsU6beVtP +t57Ave66g/GnZxp3pNduMFpZva5DPY5Xi8VwyDbb4pbNvBOoJP8jvINO5XsJroqCuw3 eQob7VnZ9IgTee0hE1cmyzTUyitOS2CTYvxpzkCqCKn/fpQHUkD7fdHklgGq141ly3l+ vLIg== X-Gm-Message-State: AOJu0YxnttplwDLD/vN84FLNtD8Vpz0UJ2GDphwnEsN8X5f+bhI47MwS 1PFX1BNt8lmkxcGHlB/KO78TOphHgGRgOLfel247wwvkYJqdsC15 X-Google-Smtp-Source: AGHT+IH9gcZrsox+4pkG+XVC3K2DCkhX2jg2gbQvfcMMKA5AWgDkyl6PTnKywYab9xjZ/eqMztcaSA== X-Received: by 2002:a0d:e003:0:b0:5ff:9567:c81 with SMTP id j3-20020a0de003000000b005ff95670c81mr286738ywe.22.1705687334593; Fri, 19 Jan 2024 10:02:14 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:2288:782e:a717:678d]) by smtp.gmail.com with ESMTPSA id n68-20020a0dcb47000000b005ff877093easm1389519ywd.143.2024.01.19.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 10:02:14 -0800 (PST) Date: Fri, 19 Jan 2024 10:02:13 -0800 From: Yury Norov To: Shijie Huang Cc: Mike Rapoport , Huang Shijie , gregkh@linuxfoundation.org, patches@amperecomputing.com, rafael@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, kuba@kernel.org, vschneid@redhat.com, mingo@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, tglx@linutronix.de, jpoimboe@kernel.org, ndesaulniers@google.com, mikelley@microsoft.com, mhiramat@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, chenhuacai@kernel.org, jiaxun.yang@flygoat.com, linux-mips@vger.kernel.org, cl@os.amperecomputing.com Subject: Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id Message-ID: References: <20240119033227.14113-1-shijie@os.amperecomputing.com> <1cd078fd-c345-4d85-a92f-04c806c20efa@amperemail.onmicrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_100218_114702_2ACC8BD0 X-CRM114-Status: GOOD ( 37.57 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKYW4gMTksIDIwMjQgYXQgMDQ6NTA6NTNQTSArMDgwMCwgU2hpamllIEh1YW5nIHdy b3RlOgo+IAo+IOWcqCAyMDI0LzEvMTkgMTY6NDIsIE1pa2UgUmFwb3BvcnQg5YaZ6YGTOgo+ID4g T24gRnJpLCBKYW4gMTksIDIwMjQgYXQgMDI6NDY6MTZQTSArMDgwMCwgU2hpamllIEh1YW5nIHdy b3RlOgo+ID4gPiDlnKggMjAyNC8xLzE5IDEyOjQyLCBZdXJ5IE5vcm92IOWGmemBkzoKPiA+ID4g PiBUaGlzIGFkZHMgYW5vdGhlciBsZXZlbCBvZiBpbmRpcmVjdGlvbiwgSSB0aGluay4gQ3VycmVu dGx5IGNwdV90b19ub2RlCj4gPiA+ID4gaXMgYSBzaW1wbGUgaW5saW5lci4gQWZ0ZXIgdGhlIHBh dGNoIGl0IHdvdWxkIGJlIGEgcmVhbCBmdW5jdGlvbiB3aXRoCj4gPiA+ID4gYWxsIHRoZSBhc3Nv Y2lhdGUgb3ZlcmhlYWQuIENhbiB5b3Ugc2hhcmUgYSBibG9hdC1vLW1ldGVyIG91dHB1dCBoZXJl Pwo+ID4gPiAjLi9zY3JpcHRzL2Jsb2F0LW8tbWV0ZXIgdm1saW51eCB2bWxpbnV4Lm5ldwo+ID4g PiBhZGQvcmVtb3ZlOiA2LzEgZ3Jvdy9zaHJpbms6IDYxLzUxIHVwL2Rvd246IDExNjgvLTU4OCAo NTgwKQo+ID4gPiBGdW5jdGlvbsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvbGTCoMKgwqDCoCBuZXfCoMKgIGRl bHRhCj4gPiA+IG51bWFfdXBkYXRlX2NwdcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMTQ4wqDCoMKgwqAgMjQ0wqDCoMKgwqAgKzk2Cj4g PiA+IAo+ID4gPiAgwqAuLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLih0byBtYW55IHRvIHNraXApCj4gPiA+IAo+ ID4gPiBUb3RhbDogQmVmb3JlPTMyOTkwMTMwLCBBZnRlcj0zMjk5MDcxMCwgY2hnICswLjAwJQo+ ID4gSXQncyBub3Qgb25seSBhYm91dCB0ZXh0IHNpemUsIHRoZSBpbmRpcmVjdCBjYWxsIGFsc28g aHVydHMgcGVyZm9ybWFuY2UKPiAKPiBUaGUgY3B1X3RvX25vZGUoKSBpcyBjYWxsZWQgYXQgdmVy eSBsb3cgZnJlcXVlbmN5LCBtb3N0IG9mIHRoZSB0aW1lcyBpcyBpbgo+IHRoZSBrZXJuZWwgYm9v dGluZyB0aW1lLgogClRoYXQgZG9lc24ndCBtYXR0ZXIuIFRoaXMgZnVuY3Rpb24gaXMgYSBzaW1w bGUgaW5saW5lciB0aGF0IGRlcmVmZXJlbmNlcwphIHBvaW50ZXIsIGFuZCBJIGJlbGlldmUgYWxs IG9mIHVzIHdhbnQgdG8ga2VlcCBpdCBzaW1wbGUuIAogCj4gPiA+ID4gUmVnYXJkbGVzcywgSSBk b24ndCB0aGluayB0aGF0IHRoZSBhcHByb2FjaCBpcyBjb3JyZWN0LiBBcyBwZXIgeW91cgo+ID4g PiA+IGRlc2NyaXB0aW9uLCBzb21lIGluaXRpYWxpemF0aW9uIGZ1bmN0aW9ucyBlcnJvbmVvdXNs eSBjYWxsCj4gPiA+ID4gY3B1X3RvX25vZGUoKSBpbnN0ZWFkIG9mIGVhcmx5X2NwdV90b19ub2Rl KCkgd2hpY2ggZXhpc3RzIHNwZWNpZmljYWxseQo+ID4gPiA+IGZvciB0aGF0IGNhc2UuCj4gPiA+ ID4gCj4gPiA+ID4gSWYgdGhlIGFib3ZlIGNvcnJlY3QsIGl0J3MgY2xlYXJseSBhIGNhbGxlciBw cm9ibGVtLCBhbmQgdGhlIGZpeCBpcyB0bwo+ID4gPiA+IHNpbXBseSBzd2l0Y2ggYWxsIHRob3Nl IGNhbGxlcnMgdG8gdXNlIGVhcmx5IHZlcnNpb24uCj4gPiA+IEl0IGlzIGVhc3kgdG8gY2hhbmdl IHRvIGVhcmx5X2NwdV90b19ub2RlKCkgZm9yIHNjaGVkX2luaXQoKSwKPiA+ID4gaW5pdF9zY2hl ZF9mYWlyX2NsYXNzKCkKPiA+ID4gCj4gPiA+IGFuZCB3b3JrcXVldWVfaW5pdF9lYXJseSgpLiBU aGVzZSB0aHJlZSBwbGFjZXMgY2FsbCB0aGUgY3B1X3RvX25vZGUoKSBpbiB0aGUKPiA+ID4gX19p bml0IGZ1bmN0aW9uLgo+ID4gPiAKPiA+ID4gCj4gPiA+IEJ1dCBpdCBpcyBhIGxpdHRsZSBoYXJk IHRvIGNoYW5nZSB0aGUgZWFybHlfdHJhY2VfaW5pdCgpLCBzaW5jZSBpdCBjYWxscwo+ID4gPiBj cHVfdG9fbm9kZSBpbiB0aGUgZGVlcAo+ID4gPiAKPiA+ID4gZnVuY3Rpb24gc3RhY2s6Cj4gPiA+ IAo+ID4gPiAgwqAgZWFybHlfdHJhY2VfaW5pdCgpIC0tPiByaW5nX2J1ZmZlcl9hbGxvYygpIC0t PnJiX2FsbG9jYXRlX2NwdV9idWZmZXIoKQo+ID4gPiAKPiA+ID4gCj4gPiA+IEZvciBlYXJseV90 cmFjZV9pbml0KCksIHdlIG5lZWQgdG8gY2hhbmdlIG1vcmUgY29kZS4KPiA+ID4gCj4gPiA+IAo+ ID4gPiBBbnl3YXksIElmIHdlIHRoaW5rIGl0IGlzIG5vdCBhIGdvb2QgaWRlYSB0byBjaGFuZ2Ug dGhlIGNvbW1vbiBjb2RlLCBJIGFtCj4gPiA+IG9ha3kgdG9vLgo+ID4gSXMgdGhlcmUgYSBmdW5k YW1lbnRhbCByZWFzb24gdG8gaGF2ZSBlYXJseV9jcHVfdG9fbm9kZSgpIGF0IGFsbD8KPiAKPiBU aGUgZWFybHlfY3B1X3RvX25vZGUgZG9lcyBub3Qgd29yayBvbiBzb21lIEFSQ0hzICh3aGljaCBz dXBwb3J0IHRoZSBOVU1BKSwKPiBzdWNoCj4gCj4gYXPCoCBTUEFSQywgTUlQUyBhbmQgUzM5MC4K ClNvLCB5b3VyIGFwcHJvYWNoIHdvdWxkbid0IHdvcmsgZWl0aGVyLCByaWdodD8gSSB0aGluayB5 b3UndmUgZ290IGEKdGVzdGluZyBib3QgcmVwb3J0IG9uIGl0IGFscmVhZHkuLi4KCllvdSBjYW4g bWFrZSBpdCBsaWtlIHRoaXM6CgogICNpZmRlZiBDT05GSUdfQVJDSF9OT19FQVJMWV9DUFVfVE9f Tk9ERQogICNkZWZpbmUgZWFybHlfY3B1X3RvX25vZGUgY3B1X3RvX25vZGUKICAjZW5kaWYKIAo+ ID4gSXQgc2VlbXMgdGhhdCBhbGwgdGhlIG1hcHBpbmdzIGFyZSBrbm93biBieSB0aGUgZW5kIG9m IHNldHVwX2FyY2goKSBhbmQgdGhlCj4gPiBpbml0aWFsaXphdGlvbiBvZiBudW1hX25vZGUgY2Fu IGJlIG1vdmVkIGVhcmxpZXIuCj4gPiA+ID4gSSB3b3VsZCBhbHNvIGluaXRpYWxpemUgdGhlIG51 bWFfbm9kZSB3aXRoIE5VTUFfTk9fTk9ERSBhdCBkZWNsYXJhdGlvbiwKPiA+ID4gPiBzbyB0aGF0 IGlmIHNvbWVvbmUgY2FsbHMgY3B1X3RvX25vZGUoKSBiZWZvcmUgdGhlIHZhcmlhYmxlIGlzIHBy b3Blcmx5Cj4gPiA+ID4gaW5pdGlhbGl6ZWQgYXQgcnVudGltZSwgaGUnbGwgZ2V0IE5PX05PREUs IHdoaWNoIGlzIG9idmlvdXNseSBhbiBlcnJvci4KPiA+ID4gRXZlbiB3ZSBzZXQgdGhlIG51bWFf bm9kZSB3aXRoIE5VTUFfTk9fTk9ERSwgaXQgZG9lcyBub3QgYWx3YXlzIHByb2R1Y2UKPiA+ID4g ZXJyb3IuCgpZb3UgY2FuIHByaW50IHRoaXMgZXJyb3IgeW91cnNlbGY6CgogICNpZm5kZWYgY3B1 X3RvX25vZGUKICBzdGF0aWMgaW5saW5lIGludCBjcHVfdG9fbm9kZShpbnQgY3B1KQogIHsKICAg ICAgICBpbnQgbm9kZSA9IHBlcl9jcHUobnVtYV9ub2RlLCBjcHUpOwoKICAjaWZkZWYgQ09ORklH X0RFQlVHX1BFUl9DUFVfTUFQUwogICAgICAgIGlmIChub2RlID09IE5VTUFfTk9fTk9ERSkKICAg ICAgICAgICAgICAgIHByX2VyciguLi4pOwogICNlbmRpZgoKICAgICAgICAgIHJldHVybiBub2Rl OwogIH0KICAjZW5kaWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5mcmFk ZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4 LXJpc2N2Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F7F6C4725D for ; Fri, 19 Jan 2024 18:03:15 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jWU2/wy0; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TGnXd66Crz3c20 for ; Sat, 20 Jan 2024 05:03:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=jWU2/wy0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::112e; helo=mail-yw1-x112e.google.com; envelope-from=yury.norov@gmail.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TGnWd3Qkgz3bw9 for ; Sat, 20 Jan 2024 05:02:19 +1100 (AEDT) Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5ff45c65e60so9264757b3.0 for ; Fri, 19 Jan 2024 10:02:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705687335; x=1706292135; darn=lists.ozlabs.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=jWU2/wy0WpsGglkIMWfT4gDB/IkpdAiTRa0yRChzJyXv9GDlsvvqpK0hYpqT2AliVo KGQS06EfLUrDKKiCPh8zd/Bcq4i4yuKqknRIPzZL173/+ObcTfQ/g6qsIhYEL9lS46W5 k+jJA4ZMlu/KhP1DH0QbbdhOElPlYFvlT5/nM5WH6X92exefLy8utDaLrr7REdx5bibP zk+0BeB3r2s8wM5f7sPQyyIKPE6WlhXJC3Z60u8OmvYpcjfntMJYikAW+UcvXoZvgEtV 19wrx4RjcIaKe7/BJ4du8qd4h0CMcXgTVKOtW+8D2O8573HkQMvim/8wo2pO+Ak0wUCa op7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705687335; x=1706292135; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=brvOYVYwlnnbfKD0MuPxf2fAmjISnsp3DSYzuNVGvVje2/DcgZ4McLOwwP9QxS0SMF WHfJyta9DDl1QeiXlcB1MCSNd4wgAC7oRSgm/L/pcx0dIJT3EzEBpVhnZXGgN+zaCn3y DvYS+eZ7U3OgeaA7oUayfrCtUlbUzVKvKrhPV5laV91D8i4v1lJZKODdQvsHVzofO9wR ooS9qgKJXM9DjtAV15AabUR2SC5LuqV/RWGKkPK825sE0rNqpsLE/VvH6aE8uYhgsbCJ tbJb6Rr4Uvzju1g9pOEB/MUqi2188M22dkYQKHfTBGQrgBkCGSS/Wz0Y1+DoPQDOAw03 qZ5Q== X-Gm-Message-State: AOJu0Yy/h0YHRa+p5yDPRMxu+PNBSgfA3+0bL7d+gnDWoR4VLmZaRjio 3qld1oOGkuipBu7ytececkLQrGiNBW2zJz+9bM3HyZa6H2M0/Tgm X-Google-Smtp-Source: AGHT+IH9gcZrsox+4pkG+XVC3K2DCkhX2jg2gbQvfcMMKA5AWgDkyl6PTnKywYab9xjZ/eqMztcaSA== X-Received: by 2002:a0d:e003:0:b0:5ff:9567:c81 with SMTP id j3-20020a0de003000000b005ff95670c81mr286738ywe.22.1705687334593; Fri, 19 Jan 2024 10:02:14 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:2288:782e:a717:678d]) by smtp.gmail.com with ESMTPSA id n68-20020a0dcb47000000b005ff877093easm1389519ywd.143.2024.01.19.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 10:02:14 -0800 (PST) Date: Fri, 19 Jan 2024 10:02:13 -0800 From: Yury Norov To: Shijie Huang Subject: Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id Message-ID: References: <20240119033227.14113-1-shijie@os.amperecomputing.com> <1cd078fd-c345-4d85-a92f-04c806c20efa@amperemail.onmicrosoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, rafael@kernel.org, catalin.marinas@arm.com, jiaxun.yang@flygoat.com, mikelley@microsoft.com, linux-riscv@lists.infradead.org, will@kernel.org, mingo@kernel.org, vschneid@redhat.com, chenhuacai@kernel.org, cl@os.amperecomputing.com, vbabka@suse.cz, kuba@kernel.org, patches@amperecomputing.com, linux-mips@vger.kernel.org, aou@eecs.berkeley.edu, arnd@arndb.de, paul.walmsley@sifive.com, tglx@linutronix.de, jpoimboe@kernel.org, linux-arm-kernel@lists.infradead.org, Huang Shijie , gregkh@linuxfoundation.org, ndesaulniers@google.com, linux-kernel@vger.kernel.org, palmer@dabbelt.com, mhiramat@kernel.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, Mike Rapoport Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jan 19, 2024 at 04:50:53PM +0800, Shijie Huang wrote: > > 在 2024/1/19 16:42, Mike Rapoport 写道: > > On Fri, Jan 19, 2024 at 02:46:16PM +0800, Shijie Huang wrote: > > > 在 2024/1/19 12:42, Yury Norov 写道: > > > > This adds another level of indirection, I think. Currently cpu_to_node > > > > is a simple inliner. After the patch it would be a real function with > > > > all the associate overhead. Can you share a bloat-o-meter output here? > > > #./scripts/bloat-o-meter vmlinux vmlinux.new > > > add/remove: 6/1 grow/shrink: 61/51 up/down: 1168/-588 (580) > > > Function                                     old     new   delta > > > numa_update_cpu                              148     244     +96 > > > > > >  ...................................................................................................................................(to many to skip) > > > > > > Total: Before=32990130, After=32990710, chg +0.00% > > It's not only about text size, the indirect call also hurts performance > > The cpu_to_node() is called at very low frequency, most of the times is in > the kernel booting time. That doesn't matter. This function is a simple inliner that dereferences a pointer, and I believe all of us want to keep it simple. > > > > Regardless, I don't think that the approach is correct. As per your > > > > description, some initialization functions erroneously call > > > > cpu_to_node() instead of early_cpu_to_node() which exists specifically > > > > for that case. > > > > > > > > If the above correct, it's clearly a caller problem, and the fix is to > > > > simply switch all those callers to use early version. > > > It is easy to change to early_cpu_to_node() for sched_init(), > > > init_sched_fair_class() > > > > > > and workqueue_init_early(). These three places call the cpu_to_node() in the > > > __init function. > > > > > > > > > But it is a little hard to change the early_trace_init(), since it calls > > > cpu_to_node in the deep > > > > > > function stack: > > > > > >   early_trace_init() --> ring_buffer_alloc() -->rb_allocate_cpu_buffer() > > > > > > > > > For early_trace_init(), we need to change more code. > > > > > > > > > Anyway, If we think it is not a good idea to change the common code, I am > > > oaky too. > > Is there a fundamental reason to have early_cpu_to_node() at all? > > The early_cpu_to_node does not work on some ARCHs (which support the NUMA), > such > > as  SPARC, MIPS and S390. So, your approach wouldn't work either, right? I think you've got a testing bot report on it already... You can make it like this: #ifdef CONFIG_ARCH_NO_EARLY_CPU_TO_NODE #define early_cpu_to_node cpu_to_node #endif > > It seems that all the mappings are known by the end of setup_arch() and the > > initialization of numa_node can be moved earlier. > > > > I would also initialize the numa_node with NUMA_NO_NODE at declaration, > > > > so that if someone calls cpu_to_node() before the variable is properly > > > > initialized at runtime, he'll get NO_NODE, which is obviously an error. > > > Even we set the numa_node with NUMA_NO_NODE, it does not always produce > > > error. You can print this error yourself: #ifndef cpu_to_node static inline int cpu_to_node(int cpu) { int node = per_cpu(numa_node, cpu); #ifdef CONFIG_DEBUG_PER_CPU_MAPS if (node == NUMA_NO_NODE) pr_err(...); #endif return node; } #endif From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCB8BC4725D for ; Fri, 19 Jan 2024 18:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uO/3TwIbJSoEt9djamAV7O/By9Ll68xkaEgdtOBsew=; b=fm3cWCSPUIUA2O qOXOXU6HB7qbebU7i0C/dMhnGOmjG6A/RGTbiFHtaz5ieMpc2rJ5Uj+fUsZrYfOjSInp98ciWaZH8 FwBX3NVevQhk8QhEL46wVl2C6Hxp7fibEkpSBy0xjKQ96+h5wXGWhL1UJcI5Kv5DF2hnK9pXGZy0Z aU4jwhLiuEGkF8EfdGyV2uGFOS+cjETv0FEUZ+WYGpVZmcgNd4Xd1kyRB+sjk35eTKDXW1PAVfM5m tNY88Q4MeIwMY7EV/62Go6/jw/I35C9U1qSOAK8keSWtaQ7+7fYSiMncpRZxF6IUchjSqGJ7p56W5 GQSVOY0pm0xkbwwz6PDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rQtC9-006Kkj-1b; Fri, 19 Jan 2024 18:02:21 +0000 Received: from mail-yw1-x1132.google.com ([2607:f8b0:4864:20::1132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rQtC6-006Kk4-0E; Fri, 19 Jan 2024 18:02:19 +0000 Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5f68af028afso8915877b3.2; Fri, 19 Jan 2024 10:02:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705687335; x=1706292135; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=OEi993k+6f5Xjnmhh5XDgRGc91MGh9eggssk/yOPXTs2UfUaVpP5lzW69Hl4G5GMMQ VwPVUgfQqa/UvHy1oOzkoTRRfaB2oWakam02ywjlhvJ9mBrOPfVv/buxbj++rll09dmT 2lisP8IaZxLwjql2wwWpaC0uBMTlrXtpotcHKlSLXNOYcXygq4zeKL/H+tl42cBaUkMr y0Iwxdu2iI6rKWTAptUrXNiGTNHryAAX/R5+g0YVdsCCDGCegsNDfYbYw35jKQaPEcFP ROnQiOMFq+u8yqnXflTLYHIRUczLkbXHnje3f7rlikLyA/Usjr0d20riiRgp7CPFlwE5 yHxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705687335; x=1706292135; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5b/i454jUf4ojxYvY+VxBq+cGu5zdwzrcVsmFXePrUc=; b=b9bzniPGTp90Teth2ah1Na6bWqmZRf55dNWYr7UvZBB9b3g0sNV3mZNad3dwtwfkOY mN+WvmBEJj5yuUKpoUtrCCt2fheW9qwoUMsU2rYxr3mzYr45QLrnlLdPYmBfCTjl7xhE dyRS+38LQ01Q5yqmPZ3ZByCjcJZfmm3wdL5auRsGYaMVI5cxCoM2xNZHVn2fsU6beVtP +t57Ave66g/GnZxp3pNduMFpZva5DPY5Xi8VwyDbb4pbNvBOoJP8jvINO5XsJroqCuw3 eQob7VnZ9IgTee0hE1cmyzTUyitOS2CTYvxpzkCqCKn/fpQHUkD7fdHklgGq141ly3l+ vLIg== X-Gm-Message-State: AOJu0YxnttplwDLD/vN84FLNtD8Vpz0UJ2GDphwnEsN8X5f+bhI47MwS 1PFX1BNt8lmkxcGHlB/KO78TOphHgGRgOLfel247wwvkYJqdsC15 X-Google-Smtp-Source: AGHT+IH9gcZrsox+4pkG+XVC3K2DCkhX2jg2gbQvfcMMKA5AWgDkyl6PTnKywYab9xjZ/eqMztcaSA== X-Received: by 2002:a0d:e003:0:b0:5ff:9567:c81 with SMTP id j3-20020a0de003000000b005ff95670c81mr286738ywe.22.1705687334593; Fri, 19 Jan 2024 10:02:14 -0800 (PST) Received: from localhost ([2601:344:8301:57f0:2288:782e:a717:678d]) by smtp.gmail.com with ESMTPSA id n68-20020a0dcb47000000b005ff877093easm1389519ywd.143.2024.01.19.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Jan 2024 10:02:14 -0800 (PST) Date: Fri, 19 Jan 2024 10:02:13 -0800 From: Yury Norov To: Shijie Huang Cc: Mike Rapoport , Huang Shijie , gregkh@linuxfoundation.org, patches@amperecomputing.com, rafael@kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, kuba@kernel.org, vschneid@redhat.com, mingo@kernel.org, akpm@linux-foundation.org, vbabka@suse.cz, tglx@linutronix.de, jpoimboe@kernel.org, ndesaulniers@google.com, mikelley@microsoft.com, mhiramat@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, mpe@ellerman.id.au, linuxppc-dev@lists.ozlabs.org, chenhuacai@kernel.org, jiaxun.yang@flygoat.com, linux-mips@vger.kernel.org, cl@os.amperecomputing.com Subject: Re: [PATCH] NUMA: Early use of cpu_to_node() returns 0 instead of the correct node id Message-ID: References: <20240119033227.14113-1-shijie@os.amperecomputing.com> <1cd078fd-c345-4d85-a92f-04c806c20efa@amperemail.onmicrosoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240119_100218_114702_2ACC8BD0 X-CRM114-Status: GOOD ( 37.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKYW4gMTksIDIwMjQgYXQgMDQ6NTA6NTNQTSArMDgwMCwgU2hpamllIEh1YW5nIHdy b3RlOgo+IAo+IOWcqCAyMDI0LzEvMTkgMTY6NDIsIE1pa2UgUmFwb3BvcnQg5YaZ6YGTOgo+ID4g T24gRnJpLCBKYW4gMTksIDIwMjQgYXQgMDI6NDY6MTZQTSArMDgwMCwgU2hpamllIEh1YW5nIHdy b3RlOgo+ID4gPiDlnKggMjAyNC8xLzE5IDEyOjQyLCBZdXJ5IE5vcm92IOWGmemBkzoKPiA+ID4g PiBUaGlzIGFkZHMgYW5vdGhlciBsZXZlbCBvZiBpbmRpcmVjdGlvbiwgSSB0aGluay4gQ3VycmVu dGx5IGNwdV90b19ub2RlCj4gPiA+ID4gaXMgYSBzaW1wbGUgaW5saW5lci4gQWZ0ZXIgdGhlIHBh dGNoIGl0IHdvdWxkIGJlIGEgcmVhbCBmdW5jdGlvbiB3aXRoCj4gPiA+ID4gYWxsIHRoZSBhc3Nv Y2lhdGUgb3ZlcmhlYWQuIENhbiB5b3Ugc2hhcmUgYSBibG9hdC1vLW1ldGVyIG91dHB1dCBoZXJl Pwo+ID4gPiAjLi9zY3JpcHRzL2Jsb2F0LW8tbWV0ZXIgdm1saW51eCB2bWxpbnV4Lm5ldwo+ID4g PiBhZGQvcmVtb3ZlOiA2LzEgZ3Jvdy9zaHJpbms6IDYxLzUxIHVwL2Rvd246IDExNjgvLTU4OCAo NTgwKQo+ID4gPiBGdW5jdGlvbsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBvbGTCoMKgwqDCoCBuZXfCoMKgIGRl bHRhCj4gPiA+IG51bWFfdXBkYXRlX2NwdcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMTQ4wqDCoMKgwqAgMjQ0wqDCoMKgwqAgKzk2Cj4g PiA+IAo+ID4gPiAgwqAuLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4u Li4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLi4uLih0byBtYW55IHRvIHNraXApCj4gPiA+IAo+ ID4gPiBUb3RhbDogQmVmb3JlPTMyOTkwMTMwLCBBZnRlcj0zMjk5MDcxMCwgY2hnICswLjAwJQo+ ID4gSXQncyBub3Qgb25seSBhYm91dCB0ZXh0IHNpemUsIHRoZSBpbmRpcmVjdCBjYWxsIGFsc28g aHVydHMgcGVyZm9ybWFuY2UKPiAKPiBUaGUgY3B1X3RvX25vZGUoKSBpcyBjYWxsZWQgYXQgdmVy eSBsb3cgZnJlcXVlbmN5LCBtb3N0IG9mIHRoZSB0aW1lcyBpcyBpbgo+IHRoZSBrZXJuZWwgYm9v dGluZyB0aW1lLgogClRoYXQgZG9lc24ndCBtYXR0ZXIuIFRoaXMgZnVuY3Rpb24gaXMgYSBzaW1w bGUgaW5saW5lciB0aGF0IGRlcmVmZXJlbmNlcwphIHBvaW50ZXIsIGFuZCBJIGJlbGlldmUgYWxs IG9mIHVzIHdhbnQgdG8ga2VlcCBpdCBzaW1wbGUuIAogCj4gPiA+ID4gUmVnYXJkbGVzcywgSSBk b24ndCB0aGluayB0aGF0IHRoZSBhcHByb2FjaCBpcyBjb3JyZWN0LiBBcyBwZXIgeW91cgo+ID4g PiA+IGRlc2NyaXB0aW9uLCBzb21lIGluaXRpYWxpemF0aW9uIGZ1bmN0aW9ucyBlcnJvbmVvdXNs eSBjYWxsCj4gPiA+ID4gY3B1X3RvX25vZGUoKSBpbnN0ZWFkIG9mIGVhcmx5X2NwdV90b19ub2Rl KCkgd2hpY2ggZXhpc3RzIHNwZWNpZmljYWxseQo+ID4gPiA+IGZvciB0aGF0IGNhc2UuCj4gPiA+ ID4gCj4gPiA+ID4gSWYgdGhlIGFib3ZlIGNvcnJlY3QsIGl0J3MgY2xlYXJseSBhIGNhbGxlciBw cm9ibGVtLCBhbmQgdGhlIGZpeCBpcyB0bwo+ID4gPiA+IHNpbXBseSBzd2l0Y2ggYWxsIHRob3Nl IGNhbGxlcnMgdG8gdXNlIGVhcmx5IHZlcnNpb24uCj4gPiA+IEl0IGlzIGVhc3kgdG8gY2hhbmdl IHRvIGVhcmx5X2NwdV90b19ub2RlKCkgZm9yIHNjaGVkX2luaXQoKSwKPiA+ID4gaW5pdF9zY2hl ZF9mYWlyX2NsYXNzKCkKPiA+ID4gCj4gPiA+IGFuZCB3b3JrcXVldWVfaW5pdF9lYXJseSgpLiBU aGVzZSB0aHJlZSBwbGFjZXMgY2FsbCB0aGUgY3B1X3RvX25vZGUoKSBpbiB0aGUKPiA+ID4gX19p bml0IGZ1bmN0aW9uLgo+ID4gPiAKPiA+ID4gCj4gPiA+IEJ1dCBpdCBpcyBhIGxpdHRsZSBoYXJk IHRvIGNoYW5nZSB0aGUgZWFybHlfdHJhY2VfaW5pdCgpLCBzaW5jZSBpdCBjYWxscwo+ID4gPiBj cHVfdG9fbm9kZSBpbiB0aGUgZGVlcAo+ID4gPiAKPiA+ID4gZnVuY3Rpb24gc3RhY2s6Cj4gPiA+ IAo+ID4gPiAgwqAgZWFybHlfdHJhY2VfaW5pdCgpIC0tPiByaW5nX2J1ZmZlcl9hbGxvYygpIC0t PnJiX2FsbG9jYXRlX2NwdV9idWZmZXIoKQo+ID4gPiAKPiA+ID4gCj4gPiA+IEZvciBlYXJseV90 cmFjZV9pbml0KCksIHdlIG5lZWQgdG8gY2hhbmdlIG1vcmUgY29kZS4KPiA+ID4gCj4gPiA+IAo+ ID4gPiBBbnl3YXksIElmIHdlIHRoaW5rIGl0IGlzIG5vdCBhIGdvb2QgaWRlYSB0byBjaGFuZ2Ug dGhlIGNvbW1vbiBjb2RlLCBJIGFtCj4gPiA+IG9ha3kgdG9vLgo+ID4gSXMgdGhlcmUgYSBmdW5k YW1lbnRhbCByZWFzb24gdG8gaGF2ZSBlYXJseV9jcHVfdG9fbm9kZSgpIGF0IGFsbD8KPiAKPiBU aGUgZWFybHlfY3B1X3RvX25vZGUgZG9lcyBub3Qgd29yayBvbiBzb21lIEFSQ0hzICh3aGljaCBz dXBwb3J0IHRoZSBOVU1BKSwKPiBzdWNoCj4gCj4gYXPCoCBTUEFSQywgTUlQUyBhbmQgUzM5MC4K ClNvLCB5b3VyIGFwcHJvYWNoIHdvdWxkbid0IHdvcmsgZWl0aGVyLCByaWdodD8gSSB0aGluayB5 b3UndmUgZ290IGEKdGVzdGluZyBib3QgcmVwb3J0IG9uIGl0IGFscmVhZHkuLi4KCllvdSBjYW4g bWFrZSBpdCBsaWtlIHRoaXM6CgogICNpZmRlZiBDT05GSUdfQVJDSF9OT19FQVJMWV9DUFVfVE9f Tk9ERQogICNkZWZpbmUgZWFybHlfY3B1X3RvX25vZGUgY3B1X3RvX25vZGUKICAjZW5kaWYKIAo+ ID4gSXQgc2VlbXMgdGhhdCBhbGwgdGhlIG1hcHBpbmdzIGFyZSBrbm93biBieSB0aGUgZW5kIG9m IHNldHVwX2FyY2goKSBhbmQgdGhlCj4gPiBpbml0aWFsaXphdGlvbiBvZiBudW1hX25vZGUgY2Fu IGJlIG1vdmVkIGVhcmxpZXIuCj4gPiA+ID4gSSB3b3VsZCBhbHNvIGluaXRpYWxpemUgdGhlIG51 bWFfbm9kZSB3aXRoIE5VTUFfTk9fTk9ERSBhdCBkZWNsYXJhdGlvbiwKPiA+ID4gPiBzbyB0aGF0 IGlmIHNvbWVvbmUgY2FsbHMgY3B1X3RvX25vZGUoKSBiZWZvcmUgdGhlIHZhcmlhYmxlIGlzIHBy b3Blcmx5Cj4gPiA+ID4gaW5pdGlhbGl6ZWQgYXQgcnVudGltZSwgaGUnbGwgZ2V0IE5PX05PREUs IHdoaWNoIGlzIG9idmlvdXNseSBhbiBlcnJvci4KPiA+ID4gRXZlbiB3ZSBzZXQgdGhlIG51bWFf bm9kZSB3aXRoIE5VTUFfTk9fTk9ERSwgaXQgZG9lcyBub3QgYWx3YXlzIHByb2R1Y2UKPiA+ID4g ZXJyb3IuCgpZb3UgY2FuIHByaW50IHRoaXMgZXJyb3IgeW91cnNlbGY6CgogICNpZm5kZWYgY3B1 X3RvX25vZGUKICBzdGF0aWMgaW5saW5lIGludCBjcHVfdG9fbm9kZShpbnQgY3B1KQogIHsKICAg ICAgICBpbnQgbm9kZSA9IHBlcl9jcHUobnVtYV9ub2RlLCBjcHUpOwoKICAjaWZkZWYgQ09ORklH X0RFQlVHX1BFUl9DUFVfTUFQUwogICAgICAgIGlmIChub2RlID09IE5VTUFfTk9fTk9ERSkKICAg ICAgICAgICAgICAgIHByX2VyciguLi4pOwogICNlbmRpZgoKICAgICAgICAgIHJldHVybiBub2Rl OwogIH0KICAjZW5kaWYKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0 aW5mby9saW51eC1hcm0ta2VybmVsCg==