Re: [Buildroot] [PATCH v2 0/2] Add support for Pi5

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Gaël, All,

On 2023-12-11 16:59 +0100, Gaël PORTAY spake thusly:
> Dear maintainers,
> 
> This two patches adds the support for the Raspberry Pi 5[0].
> 
> The first patch enables MMU 16K page-size on ARM64 as the Raspberry Pi 5
> supports 16K page-size[1].

I have two comments about that:
 1. the referenced linked does not mention the page size
 2. are 16K pages required at all?

The issue with using 16K pages, is that it would prec;ude using existing
external prebuilt toolchains, which most probably have been built with
4K pages, and as far as I understand, mixing objects built for 4K pages
and objects built for 16K pages, is not supported.

So, unless 16K is a requirement, I think using 4K pages would be better.

And of course, we currently have no indication whether an external
library was built for $k, 15K, or even 64K pages, so this is somethingwe
need to implement somehow...

Regards,
Yann E. MORIN.

> The last patch adds the raspberrypi5_defconfig for the Raspberry Pi 5
> 64-bit. It uses the defconfig bcm2712_defconfig[2] and the device-tree
> source bcm2712-rpi-5-b.dts[3]. The Raspberry Pi 5 has now a dedicated
> debug UART connector[4] (it is always active and enabled; there is no
> more need to enable_uart=1 in the file config.txt). The UART device name
> changes to ttyAMA10 and the command line has to be updated in the file
> cmdline.txt. The Raspberry Pi 5 only supports 64-bit kernel[5].
> 
> Changes since RFC:
>  - Update README to add model Pi 5 B
>  - Add support for 64K MMU page-size for ARM64 and Raspberry Pi 5
>  - Add Raspberry Pi 5 specific cmdline_5.txt to set its console on its
>    debug uart (ttyAMA10 instead of ttyAMA0)
>  - Remove 32-bit variant since Raspberry Pi 5 supports booting a 64-bit
>    kernel only
>  - Remove the property arm_64bit=1 from config_5_64bit.txt
>  - Remove the _64bit suffix
>  - Remove unecessary Pi 5 variant from package rpi-firmware
> 
> Changes since v1:
>  - Rebase on top of master
>  - Remove the bumps for the rpi-firmware and linux packages
>  - Bump the kernel to linux-17f135b742c4edb340afb365873c3a574f7e16cb
>    (6.1.61, i.e. the same version as the other raspberrypi defconfigs)
> 
> [0]: https://www.raspberrypi.com/documentation/computers/raspberry-pi-5.html#introduction
> [1]: https://www.raspberrypi.com/documentation/computers/config_txt.html#kernel
> [2]: https://github.com/raspberrypi/linux/commit/9cfb379147f803b0362b0fe249e5b145d232bea3
> [3]: https://github.com/raspberrypi/linux/commit/1196bf1a7736ff0ab79f5012fa84082e298031a7
> [4]: https://www.raspberrypi.com/documentation/computers/raspberry-pi-5.html#uart-connector
> [5]: https://www.raspberrypi.com/documentation/computers/config_txt.html#arm_64bit
> 
> Kind Regards,
> Gaël PORTAY (4):
>   arch: add support 16k page size on ARM64
>   configs: add raspberrypi 5 defconfig
> 
>  arch/Config.in.arm              |  4 ++++
>  arch/arch.mk                    |  2 +-
>  board/raspberrypi/cmdline_5.txt |  1 +
>  board/raspberrypi/config_5.txt  | 14 ++++++++++++
>  board/raspberrypi/readme.txt    |  6 +++++
>  board/raspberrypi5              |  1 +
>  configs/raspberrypi5_defconfig  | 40 +++++++++++++++++++++++++++++++++
>  linux/linux.mk                  |  4 ++++
>  8 files changed, 71 insertions(+), 1 deletion(-)
>  create mode 100644 board/raspberrypi/cmdline_5.txt
>  create mode 100644 board/raspberrypi/config_5.txt
>  create mode 120000 board/raspberrypi5
>  create mode 100644 configs/raspberrypi5_defconfig
> 
> --
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot