From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C41EE3222; Sat, 20 Jan 2024 10:02:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705744956; cv=none; b=pPB9MsQkTCg0HA4wnqDAXkGllLHv8/7Dm+U1wKGoVkyTiUZcQyYePF9QbeYiER0CwWi20EcZUaAVqtX4VAINoUAuQWoJ4jfIcrzqIh9B/h+2C0G9LsYVIVZ6mj3ir+lyttBKJrP9kERI/MduZ6jh7w8qzx/roTrULfhm5gNoSTs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705744956; c=relaxed/simple; bh=1mq/TzDDXHVp5Q39X59Xe+zvOA2DB6bcQQvkeWJI9TU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AfYSc18oqyXyY19othwQULuqlW3WUq8rRHhMCn4+7/yDW53haPJKU2kT4VZ28xtSG6aS6WPUeRBaBCiLOq5uJg3V6D/Ns6sZTfSqcdo3UfeQVveC3hk//KrbiCw/tbaF/RecMMikHReOcVGvDCwNT8hwlG/1IWEpyIoYR2gTHe0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8264DA7; Sat, 20 Jan 2024 02:03:18 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35D873F73F; Sat, 20 Jan 2024 02:02:31 -0800 (PST) Date: Sat, 20 Jan 2024 10:02:28 +0000 From: Cristian Marussi To: Peng Fan Cc: sudeep.holla@arm.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 2/2] clk: scmi: support state_ctrl_forbidden Message-ID: References: <20240115060203.813168-1-peng.fan@oss.nxp.com> <20240115060203.813168-2-peng.fan@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Jan 20, 2024 at 10:44:06AM +0800, Peng Fan wrote: > > > 在 1/19/2024 2:27 AM, Cristian Marussi 写道: > > On Mon, Jan 15, 2024 at 02:02:03PM +0800, Peng Fan (OSS) wrote: > > > From: Peng Fan > > > > > > Some clocks may exported to linux, while those clocks are not allowed > > > to configure by Linux. For example: > > > > > > SYS_CLK1----- > > > \ > > > --MUX--->MMC1_CLK > > > / > > > SYS_CLK2----- > > > > > > MMC1 needs set parent, so SYS_CLK1 and SYS_CLK2 are exported to Linux, > > > then the clk propagation will touch SYS_CLK1 or SYS_CLK2. > > > So we need bypass the failure for SYS_CLK1 or SYS_CLK2 when enable > > > the clock of MMC1. > > > > > > > Hi, > > > > so this looks good to me and apparently (as noted) the CLK framework is OK > > with a driver swallowing the -EACCESS when a clock is immutable, BUT at the > > end of the day do we even need to try this SCMI call and hide the failure in > > case of immutable clocks ? > > > > I mean, what if we just dont provide any callback for enable/disable...I can > > see plenty of drivers not providing those callbacks ? > > Maybe this is probably more of a question for Stephen... > > > > IOW what about doing something like below...does it make any difference > > in your setup ? works fine in my emulated env > > It should be fine to use your changes. Do you expect me to use your patch or > make it as a follow up patch? > It was just a suggestion, if you think is fine just include it in your series, I dont mind. > > > > (Note that last snippet in clk_gate_restore_context() is probably a fix > > that needs to be added anyway by looking at the code in clk.c) > > This API seems only used by TI gate driver, this change should be in a > standalone change go through clk tree. So I would your changes > as a standalone optimization follow up patch, while not included > in my patchset. Yes, indeed I have made a small patch of it to post it separately..and I forgot :D... sending it now. Thanks, Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C2AEC47258 for ; Sat, 20 Jan 2024 10:03:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=grrOHTUqywy8bqws5c/zmKWIPQDOlKReGRtva0tt7Oc=; b=GZE4sFjGBIaCiR AOdlTzDhEKN+c9F9ApMr3J5/2YLmkw6x1xe2PVo5x/6CNsBnFfP8aBW5kHrkxuq9EyLMZRsbSE+uU qZ8phFL5HfoLHAw6G0TEQa9e42AxC2wt/bNuE3dJ+wNi1dA6J9SnkAbArRhwkYQMyRke/jwPwwFsX W5hHaFCJtSyhn5HLGvjAYS8dljxb+Wkv2u0m0XWlowpo02JvHZQcFTy7Jwf7J/j4Jxc0Vg40EKAOP ns4LkFoixsnPRzvIy21pCM96CeqlFbB0knEg/xYsLAt+hygY77Os1GYfWo/Zdst7MOrkkYinCgF0o y4fWH5+mR3dHec3GXAWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rR8Bd-007bZN-0l; Sat, 20 Jan 2024 10:02:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rR8BY-007bY0-2M for linux-arm-kernel@lists.infradead.org; Sat, 20 Jan 2024 10:02:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8264DA7; Sat, 20 Jan 2024 02:03:18 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35D873F73F; Sat, 20 Jan 2024 02:02:31 -0800 (PST) Date: Sat, 20 Jan 2024 10:02:28 +0000 From: Cristian Marussi To: Peng Fan Cc: sudeep.holla@arm.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH V3 2/2] clk: scmi: support state_ctrl_forbidden Message-ID: References: <20240115060203.813168-1-peng.fan@oss.nxp.com> <20240115060203.813168-2-peng.fan@oss.nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240120_020244_869122_BDA684DA X-CRM114-Status: GOOD ( 29.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gU2F0LCBKYW4gMjAsIDIwMjQgYXQgMTA6NDQ6MDZBTSArMDgwMCwgUGVuZyBGYW4gd3JvdGU6 Cj4gCj4gCj4g5ZyoIDEvMTkvMjAyNCAyOjI3IEFNLCBDcmlzdGlhbiBNYXJ1c3NpIOWGmemBkzoK PiA+IE9uIE1vbiwgSmFuIDE1LCAyMDI0IGF0IDAyOjAyOjAzUE0gKzA4MDAsIFBlbmcgRmFuIChP U1MpIHdyb3RlOgo+ID4gPiBGcm9tOiBQZW5nIEZhbiA8cGVuZy5mYW5AbnhwLmNvbT4KPiA+ID4g Cj4gPiA+IFNvbWUgY2xvY2tzIG1heSBleHBvcnRlZCB0byBsaW51eCwgd2hpbGUgdGhvc2UgY2xv Y2tzIGFyZSBub3QgYWxsb3dlZAo+ID4gPiB0byBjb25maWd1cmUgYnkgTGludXguIEZvciBleGFt cGxlOgo+ID4gPiAKPiA+ID4gU1lTX0NMSzEtLS0tLQo+ID4gPiAgICAgICAgICAgICAgIFwKPiA+ ID4gCSAgICAgLS1NVVgtLS0+TU1DMV9DTEsKPiA+ID4gICAgICAgICAgICAgICAvCj4gPiA+IFNZ U19DTEsyLS0tLS0KPiA+ID4gCj4gPiA+IE1NQzEgbmVlZHMgc2V0IHBhcmVudCwgc28gU1lTX0NM SzEgYW5kIFNZU19DTEsyIGFyZSBleHBvcnRlZCB0byBMaW51eCwKPiA+ID4gdGhlbiB0aGUgY2xr IHByb3BhZ2F0aW9uIHdpbGwgdG91Y2ggU1lTX0NMSzEgb3IgU1lTX0NMSzIuCj4gPiA+IFNvIHdl IG5lZWQgYnlwYXNzIHRoZSBmYWlsdXJlIGZvciBTWVNfQ0xLMSBvciBTWVNfQ0xLMiB3aGVuIGVu YWJsZQo+ID4gPiB0aGUgY2xvY2sgb2YgTU1DMS4KPiA+ID4gCj4gPiAKPiA+IEhpLAo+ID4gCj4g PiBzbyB0aGlzIGxvb2tzIGdvb2QgdG8gbWUgYW5kIGFwcGFyZW50bHkgKGFzIG5vdGVkKSB0aGUg Q0xLIGZyYW1ld29yayBpcyBPSwo+ID4gd2l0aCBhIGRyaXZlciBzd2FsbG93aW5nIHRoZSAtRUFD Q0VTUyB3aGVuIGEgY2xvY2sgaXMgaW1tdXRhYmxlLCBCVVQgYXQgdGhlCj4gPiBlbmQgb2YgdGhl IGRheSBkbyB3ZSBldmVuIG5lZWQgdG8gdHJ5IHRoaXMgU0NNSSBjYWxsIGFuZCBoaWRlIHRoZSBm YWlsdXJlIGluCj4gPiBjYXNlIG9mIGltbXV0YWJsZSBjbG9ja3MgPwo+ID4gCj4gPiBJIG1lYW4s IHdoYXQgaWYgd2UganVzdCBkb250IHByb3ZpZGUgYW55IGNhbGxiYWNrIGZvciBlbmFibGUvZGlz YWJsZS4uLkkgY2FuCj4gPiBzZWUgcGxlbnR5IG9mIGRyaXZlcnMgbm90IHByb3ZpZGluZyB0aG9z ZSBjYWxsYmFja3MgPwo+ID4gTWF5YmUgdGhpcyBpcyBwcm9iYWJseSBtb3JlIG9mIGEgcXVlc3Rp b24gZm9yIFN0ZXBoZW4uLi4KPiA+IAo+ID4gSU9XIHdoYXQgYWJvdXQgZG9pbmcgc29tZXRoaW5n IGxpa2UgYmVsb3cuLi5kb2VzIGl0IG1ha2UgYW55IGRpZmZlcmVuY2UKPiA+IGluIHlvdXIgc2V0 dXAgPyB3b3JrcyBmaW5lIGluIG15IGVtdWxhdGVkIGVudgo+IAo+IEl0IHNob3VsZCBiZSBmaW5l IHRvIHVzZSB5b3VyIGNoYW5nZXMuIERvIHlvdSBleHBlY3QgbWUgdG8gdXNlIHlvdXIgcGF0Y2gg b3IKPiBtYWtlIGl0IGFzIGEgZm9sbG93IHVwIHBhdGNoPwo+IAoKSXQgd2FzIGp1c3QgYSBzdWdn ZXN0aW9uLCBpZiB5b3UgdGhpbmsgaXMgZmluZSBqdXN0IGluY2x1ZGUgaXQgaW4geW91cgpzZXJp ZXMsIEkgZG9udCBtaW5kLgoKPiA+IAo+ID4gKE5vdGUgdGhhdCBsYXN0IHNuaXBwZXQgaW4gY2xr X2dhdGVfcmVzdG9yZV9jb250ZXh0KCkgaXMgcHJvYmFibHkgYSBmaXgKPiA+ICAgdGhhdCBuZWVk cyB0byBiZSBhZGRlZCBhbnl3YXkgYnkgbG9va2luZyBhdCB0aGUgY29kZSBpbiBjbGsuYykKPiAK PiBUaGlzIEFQSSBzZWVtcyBvbmx5IHVzZWQgYnkgVEkgZ2F0ZSBkcml2ZXIsIHRoaXMgY2hhbmdl IHNob3VsZCBiZSBpbiBhCj4gc3RhbmRhbG9uZSBjaGFuZ2UgZ28gdGhyb3VnaCBjbGsgdHJlZS4g U28gSSB3b3VsZCB5b3VyIGNoYW5nZXMKPiBhcyBhIHN0YW5kYWxvbmUgb3B0aW1pemF0aW9uIGZv bGxvdyB1cCBwYXRjaCwgd2hpbGUgbm90IGluY2x1ZGVkCj4gaW4gbXkgcGF0Y2hzZXQuCgpZZXMs IGluZGVlZCBJIGhhdmUgbWFkZSBhIHNtYWxsIHBhdGNoIG9mIGl0IHRvIHBvc3QgaXQgc2VwYXJh dGVseS4uYW5kIEkKZm9yZ290IDpELi4uIHNlbmRpbmcgaXQgbm93LgoKVGhhbmtzLApDcmlzdGlh bgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=