All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/dbus: drop DBUS_CPE_ID_PRODUCT
Date: Sun, 4 Feb 2024 13:32:27 +0100	[thread overview]
Message-ID: <Zb-D2-ZahrrTCVnJ@landeda> (raw)
In-Reply-To: <20240204103204.1415592-1-fontaine.fabrice@gmail.com>

Fabrice, All,

On 2024-02-04 11:32 +0100, Fabrice Fontaine spake thusly:
> Commit 363b4ebf1aaf4821c0c49713eba71937bd5639ca set DBUS_CPE_ID_PRODUCT
> to dbus but this is not needed as DBUS_CPE_ID_PRODUCT will be set to the
> package name (i.e. dbus) by default

Ah, right. Applied to master, thanks.

Maybe it would be good to add that check to utils/checkpackagelib/, so
that it detects and reports the "FOO_CPE_ID_PRODUCT = foo" case.

Regards,
Yann E. MORIN.

> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/dbus/dbus.mk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/package/dbus/dbus.mk b/package/dbus/dbus.mk
> index d610846ddb..097b89205e 100644
> --- a/package/dbus/dbus.mk
> +++ b/package/dbus/dbus.mk
> @@ -12,7 +12,6 @@ DBUS_SITE = https://dbus.freedesktop.org/releases/dbus
>  DBUS_LICENSE = AFL-2.1 or GPL-2.0+ (library, tools), GPL-2.0+ (tools)
>  DBUS_LICENSE_FILES = COPYING
>  DBUS_CPE_ID_VENDOR = freedesktop
> -DBUS_CPE_ID_PRODUCT = dbus
>  DBUS_INSTALL_STAGING = YES
>  
>  define DBUS_PERMISSIONS
> -- 
> 2.43.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-04 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-04 10:32 [Buildroot] [PATCH 1/1] package/dbus: drop DBUS_CPE_ID_PRODUCT Fabrice Fontaine
2024-02-04 12:32 ` Yann E. MORIN [this message]
2024-02-04 13:25   ` Yann E. MORIN
2024-02-29 14:19 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zb-D2-ZahrrTCVnJ@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.