From: Dave Chinner <david@fromorbit.com>
To: Zorro Lang <zlang@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [xfstests generic/648] 64k directory block size (-n size=65536) crash on _xfs_buf_ioapply
Date: Wed, 24 Jan 2024 07:52:48 +1100 [thread overview]
Message-ID: <ZbAnIIUFXJC74CcQ@dread.disaster.area> (raw)
In-Reply-To: <20240123070203.6ybj224cwt2v6zf3@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
On Tue, Jan 23, 2024 at 03:02:03PM +0800, Zorro Lang wrote:
> On Tue, Jan 23, 2024 at 09:49:37AM +1100, Dave Chinner wrote:
> > On Mon, Jan 22, 2024 at 09:18:56PM +0800, Zorro Lang wrote:
> > Zorro, in the mean time, can you write up an xfstest that creates a
> > small XFS filesystem with "-n size=64k" and a large log, sets it up
> > with single block fragmentation (falloc, punch alternate), then
> > creates a bunch of files (a few thousand) to create a set of
> > fragmented directory blocks, then runs 'shutdown -f' to force the
> > log and prevent metadata writeback, then unmounts and mounts the
> > filesystem. The mount of the filesystem should then trigger this
> > directory fragment recovery issue on any platform, not just s390.
>
> Sure Dave, do you mean something likes this:
Almost. Free space needs to be fragmented before creating the
directory structure so that the directory blocks are fragmented.
> # mkfs.xfs -f -d size=1g -n size=64k -l size=200M /dev/loop0
> # mount /dev/loop0 /mnt/test
# fallocate 1g /mnt/test/file
# punch_alternate /mnt/test/file
> # for ((i=0; i<10000; i++));do echo > /mnt/tmp/dir/loooooooooooooooooooooooogfile$i;done && xfs_io -xc 'shutdown -f' /mnt/test
> # umount /mnt/test
> # mount /mnt/test
Otherwise this should trigger recover of the directory blocks and
hopefully trip over it.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2024-01-23 20:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 14:01 [xfstests generic/648] 64k directory block size (-n size=65536) crash on _xfs_buf_ioapply Zorro Lang
2023-12-18 17:48 ` Darrick J. Wong
2023-12-19 6:34 ` Zorro Lang
2023-12-25 13:38 ` Zorro Lang
2024-01-04 4:35 ` Darrick J. Wong
2024-01-18 1:59 ` Dave Chinner
2024-01-18 4:20 ` Dave Chinner
2024-01-19 1:38 ` Zorro Lang
2024-01-19 7:17 ` Dave Chinner
2024-01-20 11:26 ` Zorro Lang
2024-01-20 23:58 ` Dave Chinner
2024-01-22 7:23 ` Zorro Lang
2024-01-22 11:21 ` Dave Chinner
2024-01-22 13:18 ` Zorro Lang
2024-01-22 22:09 ` Dave Chinner
2024-01-22 22:49 ` Dave Chinner
2024-01-23 7:02 ` Zorro Lang
2024-01-23 20:52 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbAnIIUFXJC74CcQ@dread.disaster.area \
--to=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.