All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH] tests/qtest: Bump timeouts of boot_sector_test()-based tests to 610 seconds
Date: Wed, 24 Jan 2024 08:49:30 +0000	[thread overview]
Message-ID: <ZbDPGjSRI6SsN-5L@redhat.com> (raw)
In-Reply-To: <20240124084412.465638-1-thuth@redhat.com>

On Wed, Jan 24, 2024 at 09:44:12AM +0100, Thomas Huth wrote:
> We're still seeing timeouts in qtests that use a TCG payload with TCI
> on a slow k8s runner:
> 
>  https://gitlab.com/qemu-project/qemu/-/jobs/5990992722
> 
> So we should bump the timeout of cdrom-test to see whether that
> fixes the issue.
> Now, cdrom-test, as bios-tables-test, pxe-test and vmgenid-test use
> the boot_sector_test() function for running a TCG payload. That
> function already uses an internal timeout of 600 seconds with
> the remark that the test could be slow with TCI.
> Thus from the outer meson test runner side, we should not use less
> than 600 seconds as timeout values for these tests. Let's bump them
> on the meson side to 610 seconds so that the tests themselves can
> run with their internal 600 seconds timeout and have some additional
> seconds on top for reporting the outcome.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/qtest/meson.build | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      reply	other threads:[~2024-01-24  8:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  8:44 [PATCH] tests/qtest: Bump timeouts of boot_sector_test()-based tests to 610 seconds Thomas Huth
2024-01-24  8:49 ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbDPGjSRI6SsN-5L@redhat.com \
    --to=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.