All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Nikunj Kela <quic_nkela@quicinc.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
	<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
	<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
	"Prasad Sodagudi (QUIC)" <quic_psodagud@quicinc.com>,
	<srinivas.kandagatla@linaro.org>, <ulf.hansson@linaro.org>
Subject: Re: DT Query on "New Compatible vs New Property"
Date: Wed, 24 Jan 2024 17:24:33 +0000	[thread overview]
Message-ID: <ZbFH0UE9zZQFWm8Z@bogus> (raw)
In-Reply-To: <16db3da8-dfdd-4e06-b348-33e9197fe18d@quicinc.com>

On Wed, Jan 24, 2024 at 06:28:33AM -0800, Nikunj Kela wrote:
> 
> Let me try another shot to convince you :) Currently, driver is dealing with
> clocks and regulators using individual framework APIs(e.g. set_clk_rate,
> regulator_set_voltage etc.). With defining perf to group them in OPP APIs,
> we need to now use set_opp. Therefore the driver needs to change to use OPP
> framework APIs instead of clocks/regulator APIs hence this query on how to
> distinguish the two configuration even though the hardware is same.
>

One option is to make dev_pm_opp_set_opp() work for both. IIUC, opp layer
can deal with clocks and regulators. A quick look at dev_pm_opp_set_opp()
seem to suggest that.

Another option is to try both one after another. Here I am assuming that
clk_get() will fail and return error. One could check if it has pm_domain
with "perf" support and use opp APIs.

I don't think we need DT changes to achieve what you have explained so far.
At least not at a level of per device node compatible or extra property.

--
Regards,
Sudeep

  reply	other threads:[~2024-01-24 17:24 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-12 17:45 DT Query on "New Compatible vs New Property" Nikunj Kela
2023-12-12 19:01 ` Krzysztof Kozlowski
2023-12-12 19:06   ` Nikunj Kela
2023-12-14  6:17     ` Manivannan Sadhasivam
2023-12-14  7:49       ` Krzysztof Kozlowski
2023-12-14 15:18         ` Nikunj Kela
2024-01-23 16:12           ` Manivannan Sadhasivam
2024-01-24  8:02             ` Krzysztof Kozlowski
2024-01-24  8:39               ` Manivannan Sadhasivam
2024-01-24  8:45                 ` Krzysztof Kozlowski
2024-01-24  8:53                   ` Manivannan Sadhasivam
2024-01-24  9:01                     ` Krzysztof Kozlowski
2024-01-24  9:27                       ` Manivannan Sadhasivam
2024-01-24  9:40                         ` Krzysztof Kozlowski
2024-01-24 10:36                           ` Manivannan Sadhasivam
2024-01-24 10:23             ` Sudeep Holla
2024-01-24 10:45               ` Manivannan Sadhasivam
2024-01-24 11:02                 ` Sudeep Holla
2024-01-24 12:27                   ` Nikunj Kela
2024-01-24 12:48                     ` Sudeep Holla
2024-01-24 13:17                       ` Nikunj Kela
2024-01-24 13:38                         ` Vincent Guittot
2024-01-24 14:04                           ` Sudeep Holla
2024-01-24 14:28                             ` Nikunj Kela
2024-01-24 17:24                               ` Sudeep Holla [this message]
2024-01-24 17:33                                 ` Nikunj Kela
2024-02-26 14:22                                   ` Nikunj Kela
2024-02-28 13:27                                     ` Ulf Hansson
2024-02-28 14:02                                       ` Sudeep Holla
2024-02-28 14:20                                         ` Krzysztof Kozlowski
2024-02-28 16:09                                           ` Sudeep Holla
2024-02-28 16:22                                             ` Ulf Hansson
2024-02-28 17:11                                               ` Srinivas Kandagatla
2024-03-01 11:53                                                 ` Ulf Hansson
2024-03-04 11:01                                                   ` Sudeep Holla
2024-03-12 16:52                                                     ` Nikunj Kela
2024-03-12 16:58                                                       ` Trilok Soni
2024-03-12 17:08                                                         ` Nikunj Kela
2024-03-12 17:21                                                         ` Srinivas Kandagatla
2024-03-12 17:25                                                           ` Trilok Soni
2024-03-13  9:19                                                             ` Ulf Hansson
2024-03-13  9:31                                                               ` Nikunj Kela
2024-03-13 11:21                                                               ` Srinivas Kandagatla
2024-03-13 11:49                                                             ` Srinivas Kandagatla
2024-03-13 22:40                                                               ` Trilok Soni
2024-04-10 16:53                                                                 ` Nikunj Kela
2024-04-11  9:29                                                                   ` Sudeep Holla
2024-03-13 11:04                                                       ` Sudeep Holla
2024-03-13 13:04                                                         ` Srinivas Kandagatla
2024-03-14 10:55                                                           ` Sudeep Holla
2024-03-14 12:35                                                             ` Nikunj Kela
2024-03-14 15:38                                                               ` Sudeep Holla
2024-03-16 19:30                                                                 ` Trilok Soni
2024-03-19 10:17                                                                   ` Srinivas Kandagatla
2024-03-19 12:00                                                                     ` Sudeep Holla
2024-03-19 14:40                                                                       ` Srinivas Kandagatla
2024-03-19 15:17                                                                         ` Sudeep Holla
2024-03-19 15:41                                                                           ` Srinivas Kandagatla
2024-03-19 16:13                                                                             ` Sudeep Holla
2024-04-10 16:55                                                                               ` Nikunj Kela
2024-04-10 17:13                                                                                 ` Krzysztof Kozlowski
2024-04-10 17:24                                                                                   ` Nikunj Kela
2024-04-11 15:44                                                                                     ` Conor Dooley
2024-04-11 15:55                                                                                       ` Nikunj Kela
2024-04-11 19:29                                                                                         ` Krzysztof Kozlowski
2024-04-12 10:16                                                                                           ` Sudeep Holla
2024-04-11  9:23                                                                                 ` Sudeep Holla
2024-04-11 15:59                                                                                   ` Nikunj Kela
2024-04-12 10:12                                                                                     ` Sudeep Holla
2024-01-24 14:01                         ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbFH0UE9zZQFWm8Z@bogus \
    --to=sudeep.holla@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=quic_nkela@quicinc.com \
    --cc=quic_psodagud@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=ulf.hansson@linaro.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.