From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1263C46CD2 for ; Wed, 24 Jan 2024 18:36:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nDbfOZBQSkDZrJa5fp17bQAJ/BXX8ExO0z9Hm1NbTCk=; b=toG4CEp1tYQu3n c6a1zph1SuHNxssU5rGz6nU/CMLuhdPV/ayJpz07oJRqeth2tFJSsEZggo3GkueOZJF55QkkYQjXf DGodoFhbJ+4xV9Qz71bK+7T4RkbreAIiR8zH+dRCSlizPqZvBKiFHUN8CsqpYJh4l+Xgy9r5YUpT+ ySiKecPKn+vUn3h/dy/4PtkAl5Olx3gcY+xysGrkPIHJcl7np1E1STt4nFjKz6bVwG16oJN7XrzVM Dyvl0tAcYl72qx1yj6jz09ysenKzYVjZfP7xd2KiCZ3zzU0ramfIvHl5nNfa4owGl/+colq2TmvHb JsYBNyvi23EC9kbWx6cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rSi6w-004ibF-0X; Wed, 24 Jan 2024 18:36:30 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rSi6t-004iYW-0b for linux-riscv@lists.infradead.org; Wed, 24 Jan 2024 18:36:29 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6daa89a6452so4131975b3a.2 for ; Wed, 24 Jan 2024 10:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706121381; x=1706726181; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dyoVaujb6HdGGQZquWAHWyK8BzIubclZKA3RVrGEVpc=; b=kCQhW7lEBkCiH+EpVSwKtcm3t/qnmBkKVlJeYaQicerXo6p4Zca151ezvBOJKVJidP G4/ko2DGcSv2HYTTVAs7Lco5vstrvBdBQIK6n9mnMMZUg4N549GTdcaRqDQBPznlhP0z yJE8qQ3NtVnW1DZO6IOllc0TGa3DahsH1De7B6wl2LIvZMx2G/EfkzcwpRXe2XnhqGvY juorDEc666AuPW7KovveprFAyNFQoLII7uD/k6/FCRBYXKXz1o4SQNvEEXgolPKpulx4 SGpSfsB/i+9AkFlfKaYAVdO0CwCV7vBcScs/7CF1CQ6d6ZiR+Ua0frD8lANq6qKwD4Ht EbwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706121381; x=1706726181; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dyoVaujb6HdGGQZquWAHWyK8BzIubclZKA3RVrGEVpc=; b=TIaRQOOQFjG0VfRRc+NtJsKWQC0imNj66LnXb1JveO+riK93hmcPx8/uYNeqLP1mN4 tStw8n7hc4833VlGBZISozT9VBYbrx1oIWLF6sUUua8jQPyqaG16hH6oGKQIs6a0NsXR RZOHmZOmCYJvC4LsmoduK0B+i9/iZqhhaBci44pAAjwX3X9jGt1HWh2OShuWgreo/UA3 ybDw4FhmekdKEU1Xd48oMQjlijshB6JMCRKsLARzo5xCOCg07M8+GmHgcb0YsIX7FXqE Y65mWDuL1014+6vTwToy++kwvNh94HAuZcOAMXGqWqiAraXWxX4tmtdpRsRTiMLBnJU6 yFoQ== X-Gm-Message-State: AOJu0Yz6eHHeyqmibGdABDRNYqTAhto7AIkRYqOVcg1R96CNoF5JQ8Lo cugGpMDvQNQy1uTb/+2sr357n/qyyCKSVbaKZ08Q4omlOVaqnu1zo8VezsH+mY4= X-Google-Smtp-Source: AGHT+IGa4MiJVKL68+be1ENZatYewBEzPKO9fNG4WgZ7fFnKMwOYC9yysxlwKGZJPdjj+oZ9bTHTzA== X-Received: by 2002:a05:6a20:6e91:b0:19a:e5cd:c41d with SMTP id gr17-20020a056a206e9100b0019ae5cdc41dmr881650pzb.96.1706121381191; Wed, 24 Jan 2024 10:36:21 -0800 (PST) Received: from ghost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id p12-20020a056a0026cc00b006ddc2a97806sm444955pfw.213.2024.01.24.10.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 10:36:20 -0800 (PST) Date: Wed, 24 Jan 2024 10:36:17 -0800 From: Charlie Jenkins To: guoren@kernel.org Cc: linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, alexghiti@rivosinc.com, xiao.w.wang@intel.com, david@redhat.com, panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com, willy@infradead.org, bjorn@rivosinc.com, conor.dooley@microchip.com, cleger@rivosinc.com, leobras@redhat.com, linux-riscv@lists.infradead.org, Guo Ren Subject: Re: [PATCH V3 4/4] riscv: mm: Optimize TASK_SIZE definition Message-ID: References: <20231222115703.2404036-1-guoren@kernel.org> <20231222115703.2404036-5-guoren@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231222115703.2404036-5-guoren@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240124_103627_225529_73F93F23 X-CRM114-Status: GOOD ( 14.31 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBEZWMgMjIsIDIwMjMgYXQgMDY6NTc6MDNBTSAtMDUwMCwgZ3VvcmVuQGtlcm5lbC5v cmcgd3JvdGU6Cj4gRnJvbTogR3VvIFJlbiA8Z3VvcmVuQGxpbnV4LmFsaWJhYmEuY29tPgo+IAo+ IFVuaWZ5IHRoZSBUQVNLX1NJWkUgZGVmaW5pdGlvbiB3aXRoIFZBX0JJVFMgZm9yIGJldHRlciBy ZWFkYWJpbGl0eS4KPiBBZGQgQ09NUEFUIG1vZGUgdXNlciBhZGRyZXNzIHNwYWNlIGluZm8gaW4g dGhlIGNvbW1lbnQuCj4gCj4gUmV2aWV3ZWQtYnk6IExlb25hcmRvIEJyYXMgPGxlb2JyYXNAcmVk aGF0LmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBHdW8gUmVuIDxndW9yZW5AbGludXguYWxpYmFiYS5j b20+Cj4gU2lnbmVkLW9mZi1ieTogR3VvIFJlbiA8Z3VvcmVuQGtlcm5lbC5vcmc+Cj4gLS0tCj4g IGFyY2gvcmlzY3YvaW5jbHVkZS9hc20vcGd0YWJsZS5oIHwgNSArKystLQo+ICAxIGZpbGUgY2hh bmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9h cmNoL3Jpc2N2L2luY2x1ZGUvYXNtL3BndGFibGUuaCBiL2FyY2gvcmlzY3YvaW5jbHVkZS9hc20v cGd0YWJsZS5oCj4gaW5kZXggZTQxNTU4MjI3NmVjLi4yNzE1NjVlMTk1NmYgMTAwNjQ0Cj4gLS0t IGEvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9wZ3RhYmxlLmgKPiArKysgYi9hcmNoL3Jpc2N2L2lu Y2x1ZGUvYXNtL3BndGFibGUuaAo+IEBAIC04NjYsNiArODY2LDcgQEAgc3RhdGljIGlubGluZSBw dGVfdCBwdGVfc3dwX2NsZWFyX2V4Y2x1c2l2ZShwdGVfdCBwdGUpCj4gICAqIE5vdGUgdGhhdCBQ R0RJUl9TSVpFIG11c3QgZXZlbmx5IGRpdmlkZSBUQVNLX1NJWkUuCj4gICAqIFRhc2sgc2l6ZSBp czoKPiAgICogLSAgICAgICAgMHg5ZmMwMDAwMAkofjIuNUdCKSBmb3IgUlYzMi4KPiArICogLSAg ICAgICAgMHg4MDAwMDAwMAkoICAgMkdCKSBmb3IgUlY2NCBjb21wYXQgbW9kZQo+ICAgKiAtICAg ICAgMHg0MDAwMDAwMDAwCSggMjU2R0IpIGZvciBSVjY0IHVzaW5nIFNWMzkgbW11Cj4gICAqIC0g ICAgMHg4MDAwMDAwMDAwMDAJKCAxMjhUQikgZm9yIFJWNjQgdXNpbmcgU1Y0OCBtbXUKPiAgICog LSAweDEwMDAwMDAwMDAwMDAwMAkoICA2NFBCKSBmb3IgUlY2NCB1c2luZyBTVjU3IG1tdQo+IEBA IC04NzcsMTAgKzg3OCwxMCBAQCBzdGF0aWMgaW5saW5lIHB0ZV90IHB0ZV9zd3BfY2xlYXJfZXhj bHVzaXZlKHB0ZV90IHB0ZSkKPiAgICogU2ltaWxhcmx5IGZvciBTVjU3LCBiaXRzIDYz4oCTNTcg bXVzdCBiZSBlcXVhbCB0byBiaXQgNTYuCj4gICAqLwo+ICAjaWZkZWYgQ09ORklHXzY0QklUCj4g LSNkZWZpbmUgVEFTS19TSVpFXzY0CShQR0RJUl9TSVpFICogUFRSU19QRVJfUEdEIC8gMikKPiAr I2RlZmluZSBUQVNLX1NJWkVfNjQJKFVMKDEpIDw8IChWQV9CSVRTIC0gMSkpCj4gIAo+ICAjaWZk ZWYgQ09ORklHX0NPTVBBVAo+IC0jZGVmaW5lIFRBU0tfU0laRV8zMgkoX0FDKDB4ODAwMDAwMDAs IFVMKSkKPiArI2RlZmluZSBUQVNLX1NJWkVfMzIJKFVMKDEpIDw8IChWQV9CSVRTX1NWMzIgLSAx KSkKPiAgI2RlZmluZSBUQVNLX1NJWkUJKHRlc3RfdGhyZWFkX2ZsYWcoVElGXzMyQklUKSA/IFwK PiAgCQkJIFRBU0tfU0laRV8zMiA6IFRBU0tfU0laRV82NCkKPiAgI2Vsc2UKPiAtLSAKPiAyLjQw LjEKPiAKClJldmlld2VkLWJ5OiBDaGFybGllIEplbmtpbnMgPGNoYXJsaWVAcml2b3NpbmMuY29t PgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BBE413172C for ; Wed, 24 Jan 2024 18:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706121394; cv=none; b=nI68x3JLO0+5X7hki3Y0PFFS+/GHOnyleTWOzMjoWkFiMFj5nJCuA0YUYPAxMa875ujWRUIS4enmMGVX5fckaGGcraO+188aqQtjrp3hWeGkPr0xNsAcIjOjUN4mqr4JHaCk9vKOhclgICodWT4CysJ5yJA1zBkz0UNtV/f5skE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706121394; c=relaxed/simple; bh=Y84vm7zPVQwyKhmEkvswV7MwbzkZTeonxhhVQOUT2pI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OEMNDYU+HbpwbQ8duVRB7XeF1OGBwy/kCLKTWlrnySWk9g8+OgvcgdtU35jb7+IWLzeuf7W7+YjnIbjWMhMHX09SHqK9tnz9x4jjcL3HEPrwxNRJgKOByR0H+YcC1cWIs3R33G0GO1vigrwtpl4AaG8QCloRjzcX5jaXVueeUEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=U79ePXOS; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="U79ePXOS" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6ddc6f5eaccso154b3a.3 for ; Wed, 24 Jan 2024 10:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706121381; x=1706726181; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=dyoVaujb6HdGGQZquWAHWyK8BzIubclZKA3RVrGEVpc=; b=U79ePXOSMF/HbuhbOuujkQY+eusf3qkq3agMM3NmznpRgcs2MUQi0a4DeoFTkHDsMi BAdknpuaEwiohreDALcBJIPhNRI2dfP/hCjA3SUmK2N6hGbvDE5eYp0La3JFArEgqB9h IV2b/89iesS2MEuH678m1uFtWjZWZgv0I2danINL9TcpIqYCC2DWkcYjo+iGjO8lLRnG /GQ1T1iWjj9sT9I+YURuTIln0VLRsbXW+slf2ULghZj2uDvjP0Yn3tjyi8CXCUTA4z5I gl4rln64vv96oJp59UaBS5mzXA4s9JWNxyGwMiqdcTaRUe8uEAgexO0UhIaDXu0BJ4nj 0NRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706121381; x=1706726181; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dyoVaujb6HdGGQZquWAHWyK8BzIubclZKA3RVrGEVpc=; b=CcI7CKg1mGzzVgKZ+05Sg3/DgQm3owarj+XKGXImOFfIlae/3dIbInGPHVFGf5MEdp OUOAaqi5lj010dfiki+WDeIrmnJdjeTWH7s4uUDxQ9BTLfl5Fpb+sUCAE3G+2DIet73o swqLdRL5OE/ssZNyDJKKHPWE0/u40sE+jEks2ng70ij4L2kF490zfv1CVbHTTwPdCnVK v7Of4uYZ6RCXjUsfS+Wk53Pn48SERgVt+cWPxiperzqal3rfPTkV4Vs/if1xnMr7LUlb t5UAnCO8tCii5aDcIiam9b5TPeFeM6jx7KSNmCqtGprcr5CkROF8f9ZszQ42ADFueTx6 tmLQ== X-Gm-Message-State: AOJu0Ywa6HzPAVz7xsE7OqXp33M7daNC221H6s8XZNK6CCrewQThSEv4 t1VEsAW3wpnGM1pWN6ubWguCLn6zvoSI79+cKV61FZkmtFxlkdd4PJux1WbNJ04= X-Google-Smtp-Source: AGHT+IGa4MiJVKL68+be1ENZatYewBEzPKO9fNG4WgZ7fFnKMwOYC9yysxlwKGZJPdjj+oZ9bTHTzA== X-Received: by 2002:a05:6a20:6e91:b0:19a:e5cd:c41d with SMTP id gr17-20020a056a206e9100b0019ae5cdc41dmr881650pzb.96.1706121381191; Wed, 24 Jan 2024 10:36:21 -0800 (PST) Received: from ghost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id p12-20020a056a0026cc00b006ddc2a97806sm444955pfw.213.2024.01.24.10.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 10:36:20 -0800 (PST) Date: Wed, 24 Jan 2024 10:36:17 -0800 From: Charlie Jenkins To: guoren@kernel.org Cc: linux-kernel@vger.kernel.org, paul.walmsley@sifive.com, palmer@dabbelt.com, alexghiti@rivosinc.com, xiao.w.wang@intel.com, david@redhat.com, panqinglin2020@iscas.ac.cn, rick.p.edgecombe@intel.com, willy@infradead.org, bjorn@rivosinc.com, conor.dooley@microchip.com, cleger@rivosinc.com, leobras@redhat.com, linux-riscv@lists.infradead.org, Guo Ren Subject: Re: [PATCH V3 4/4] riscv: mm: Optimize TASK_SIZE definition Message-ID: References: <20231222115703.2404036-1-guoren@kernel.org> <20231222115703.2404036-5-guoren@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231222115703.2404036-5-guoren@kernel.org> On Fri, Dec 22, 2023 at 06:57:03AM -0500, guoren@kernel.org wrote: > From: Guo Ren > > Unify the TASK_SIZE definition with VA_BITS for better readability. > Add COMPAT mode user address space info in the comment. > > Reviewed-by: Leonardo Bras > Signed-off-by: Guo Ren > Signed-off-by: Guo Ren > --- > arch/riscv/include/asm/pgtable.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/riscv/include/asm/pgtable.h b/arch/riscv/include/asm/pgtable.h > index e415582276ec..271565e1956f 100644 > --- a/arch/riscv/include/asm/pgtable.h > +++ b/arch/riscv/include/asm/pgtable.h > @@ -866,6 +866,7 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) > * Note that PGDIR_SIZE must evenly divide TASK_SIZE. > * Task size is: > * - 0x9fc00000 (~2.5GB) for RV32. > + * - 0x80000000 ( 2GB) for RV64 compat mode > * - 0x4000000000 ( 256GB) for RV64 using SV39 mmu > * - 0x800000000000 ( 128TB) for RV64 using SV48 mmu > * - 0x100000000000000 ( 64PB) for RV64 using SV57 mmu > @@ -877,10 +878,10 @@ static inline pte_t pte_swp_clear_exclusive(pte_t pte) > * Similarly for SV57, bits 63–57 must be equal to bit 56. > */ > #ifdef CONFIG_64BIT > -#define TASK_SIZE_64 (PGDIR_SIZE * PTRS_PER_PGD / 2) > +#define TASK_SIZE_64 (UL(1) << (VA_BITS - 1)) > > #ifdef CONFIG_COMPAT > -#define TASK_SIZE_32 (_AC(0x80000000, UL)) > +#define TASK_SIZE_32 (UL(1) << (VA_BITS_SV32 - 1)) > #define TASK_SIZE (test_thread_flag(TIF_32BIT) ? \ > TASK_SIZE_32 : TASK_SIZE_64) > #else > -- > 2.40.1 > Reviewed-by: Charlie Jenkins