From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE4EBC47258 for ; Thu, 25 Jan 2024 16:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rvR+VXv1f18BSClkjanWiSajfNl4/jls34jdju1x0oo=; b=pebZUAC9LxuhD2KsR0Zu9zaGiR v4dPm4tJ0gvsH3lc63iRRr+oGbaH3YmepmeHjcchlSxQJU/+/6MXAEper/OsLN9Xrg/eT7DPCXy1H S+NaYSTO8xtcApHUdr+EhzR39SRFBx7/WLRO6+ZwGDcj+I7oKV3jYb7OxFp3Nuj7k8+4LlkFId14e h2XudKhUCl8h56GkrqCbGIjWtLggxVl/LifrnOWIA8TwiadZ5cYWrW+xx9wkrCSXrydY8THP92Hqf LNyKNZ5BTAmkqK49lUNw9Wtjtjasogn792o1e2dR+edmI7KUc1MWj3AsID8nXA18/GyYBo7L9bs7R HQijmuJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT2R8-00000000lNr-1UfV; Thu, 25 Jan 2024 16:18:42 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT2R5-00000000lMF-0jAW; Thu, 25 Jan 2024 16:18:40 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rT2Qi-0003de-0p; Thu, 25 Jan 2024 16:18:16 +0000 Date: Thu, 25 Jan 2024 16:18:07 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, John Crispin Subject: Re: [PATCH net] net: dsa: mt7530: fix 10M/100M speed on MT7988 switch Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_081839_251244_BBC5915C X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Jan 25, 2024 at 12:49:19PM +0300, Arınç ÜNAL wrote: > On 24/01/2024 08:17, Daniel Golle wrote: > > Setup PMCR port register for actual speed and duplex on internally > > connected PHYs of the MT7988 built-in switch. This fixes links with > > speeds other than 1000M. > > > > Fixes: ("110c18bfed414 net: dsa: mt7530: introduce driver for MT7988 built-in switch") > > Signed-off-by: Daniel Golle > > Acked-by: Arınç ÜNAL > > I'm wondering why we manually set speed and duplex for these interface > modes in the first place. I don't how it works for > PHY_INTERFACE_MODE_INTERNAL but, at least for PHY_INTERFACE_MODE_TRGMII and > 802.3z interfaces, phylink should already supply proper speed and duplex. It's true that duplex should always be set to full-duplex already by phylink. However, speed could be 2500MBit/s (2500Base-X) or 2000MBit/s (?, TRGMII) and we yet need to program the PCR like if it was 1000MBit/s. Regarding the INTERNAL case: it was added by mistake. In case of MT7988, all ports of the switch are connected via INTERNAL links, however, the PHYs still need adjustment of the PCR register just like on all other MT753x switches and the CPU port is setup elsewhere anyway. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86B0EC47422 for ; Thu, 25 Jan 2024 16:18:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WaoFW2ArDBji0OGUvUMs4NS27hJLmhXDrN29TANU4mY=; b=okP8cYlttZan3e Mk58kaMXBniXbMWQvGvdfg/mygBzj+Frq4bKcY6fIqucXKCGsjY4OPNnXkVUeI5sdp5S1ozrpPUfO m4SiuhxwCLR93pBk0iCzUX5YrQk0xAgQzJgC0lLFT64O6iOAEyhUSSU9V5IPBBKi5qmIexKpdy2Hh 3TrRlUl4uDODBEk5WFbQtEg28eoP6+CIf1cxSytej4acGd0Y0nUgSIuxsW7bjQ9mjeVCj3P0mlLur qehgrgqi69kY/Fu2GxHMQuZW26D+n6oIg2hFK5gA+xl7FqO448a9g3Mi2vXCIjIpzeZ+a9yzSKypa IFjh33C5lIPNVu7jGu3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT2R7-00000000lNc-3HBD; Thu, 25 Jan 2024 16:18:41 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT2R5-00000000lMF-0jAW; Thu, 25 Jan 2024 16:18:40 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96.2) (envelope-from ) id 1rT2Qi-0003de-0p; Thu, 25 Jan 2024 16:18:16 +0000 Date: Thu, 25 Jan 2024 16:18:07 +0000 From: Daniel Golle To: =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= Cc: DENG Qingfang , Sean Wang , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, John Crispin Subject: Re: [PATCH net] net: dsa: mt7530: fix 10M/100M speed on MT7988 switch Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240125_081839_251244_BBC5915C X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBKYW4gMjUsIDIwMjQgYXQgMTI6NDk6MTlQTSArMDMwMCwgQXLEsW7DpyDDnE5BTCB3 cm90ZToKPiBPbiAyNC8wMS8yMDI0IDA4OjE3LCBEYW5pZWwgR29sbGUgd3JvdGU6Cj4gPiBTZXR1 cCBQTUNSIHBvcnQgcmVnaXN0ZXIgZm9yIGFjdHVhbCBzcGVlZCBhbmQgZHVwbGV4IG9uIGludGVy bmFsbHkKPiA+IGNvbm5lY3RlZCBQSFlzIG9mIHRoZSBNVDc5ODggYnVpbHQtaW4gc3dpdGNoLiBU aGlzIGZpeGVzIGxpbmtzIHdpdGgKPiA+IHNwZWVkcyBvdGhlciB0aGFuIDEwMDBNLgo+ID4gCj4g PiBGaXhlczogKCIxMTBjMThiZmVkNDE0IG5ldDogZHNhOiBtdDc1MzA6IGludHJvZHVjZSBkcml2 ZXIgZm9yIE1UNzk4OCBidWlsdC1pbiBzd2l0Y2giKQo+ID4gU2lnbmVkLW9mZi1ieTogRGFuaWVs IEdvbGxlIDxkYW5pZWxAbWFrcm90b3BpYS5vcmc+Cj4gCj4gQWNrZWQtYnk6IEFyxLFuw6cgw5xO QUwgPGFyaW5jLnVuYWxAYXJpbmM5LmNvbT4KPiAKPiBJJ20gd29uZGVyaW5nIHdoeSB3ZSBtYW51 YWxseSBzZXQgc3BlZWQgYW5kIGR1cGxleCBmb3IgdGhlc2UgaW50ZXJmYWNlCj4gbW9kZXMgaW4g dGhlIGZpcnN0IHBsYWNlLiBJIGRvbid0IGhvdyBpdCB3b3JrcyBmb3IKPiBQSFlfSU5URVJGQUNF X01PREVfSU5URVJOQUwgYnV0LCBhdCBsZWFzdCBmb3IgUEhZX0lOVEVSRkFDRV9NT0RFX1RSR01J SSBhbmQKPiA4MDIuM3ogaW50ZXJmYWNlcywgcGh5bGluayBzaG91bGQgYWxyZWFkeSBzdXBwbHkg cHJvcGVyIHNwZWVkIGFuZCBkdXBsZXguCgpJdCdzIHRydWUgdGhhdCBkdXBsZXggc2hvdWxkIGFs d2F5cyBiZSBzZXQgdG8gZnVsbC1kdXBsZXggYWxyZWFkeSBieQpwaHlsaW5rLiBIb3dldmVyLCBz cGVlZCBjb3VsZCBiZSAyNTAwTUJpdC9zICgyNTAwQmFzZS1YKSBvciAyMDAwTUJpdC9zCig/LCBU UkdNSUkpIGFuZCB3ZSB5ZXQgbmVlZCB0byBwcm9ncmFtIHRoZSBQQ1IgbGlrZSBpZiBpdCB3YXMK MTAwME1CaXQvcy4KClJlZ2FyZGluZyB0aGUgSU5URVJOQUwgY2FzZTogaXQgd2FzIGFkZGVkIGJ5 IG1pc3Rha2UuIEluIGNhc2Ugb2YKTVQ3OTg4LCBhbGwgcG9ydHMgb2YgdGhlIHN3aXRjaCBhcmUg Y29ubmVjdGVkIHZpYSBJTlRFUk5BTCBsaW5rcywKaG93ZXZlciwgdGhlIFBIWXMgc3RpbGwgbmVl ZCBhZGp1c3RtZW50IG9mIHRoZSBQQ1IgcmVnaXN0ZXIganVzdCBsaWtlCm9uIGFsbCBvdGhlciBN VDc1M3ggc3dpdGNoZXMgYW5kIHRoZSBDUFUgcG9ydCBpcyBzZXR1cCBlbHNld2hlcmUKYW55d2F5 LgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=