From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B218C47422 for ; Fri, 26 Jan 2024 09:56:00 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTIvy-0006iK-2t; Fri, 26 Jan 2024 04:55:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTIvt-0006e3-4g for grub-devel@gnu.org; Fri, 26 Jan 2024 04:55:33 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTIvq-0000nI-3Z for grub-devel@gnu.org; Fri, 26 Jan 2024 04:55:32 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 3628C5C017D; Fri, 26 Jan 2024 04:55:27 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 26 Jan 2024 04:55:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1706262927; x=1706349327; bh=cqKdDKwNO2 q2zu2zrLNagYQQynNGiZKqRDpKA9ySlfU=; b=FVo6DAsaTOvbMSPe6+lMWQV3SD XSQM5EwucZssvZ9fkCP/TgBN0EhHaD0WCGbAvwh9hl/yp/Hthxdq8LBFbNgnc5Hh FXm8+309GD02JoYwJxG2kSFKB+PTJmP7ZalVpGxU4bsjXNGWNvaqbuht+2x5VPoR h+yyxYxY7fNqfULojJUlcHPGUz/qd19SpxiCeQjNZe4LwJlQtgIonzSrcP+YTp/9 qYt939ZL6LNdTwEPJ3G2vyJDGJVo8diC5SIj9U/LEkO/M97LDZYsBQ2YuLTGOC5e cuZxmyFsAZsq701aqwxZwMTPc5purokyEl/8Y9hQUWhwY9x/vcyqTjgfxDVA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1706262927; x=1706349327; bh=cqKdDKwNO2q2zu2zrLNagYQQynNG iZKqRDpKA9ySlfU=; b=MlwUR21E/KoPQ/C+4mN1eVOhB9veeZ2rBGAxRhOLMyM+ JQLslOBtHEcTJurUDInBVNVB4iHqg8a4yTc+lfbmUw8ubZBm4AegAcRZo83lacpp kR4KAMe/XimliJ9laoa9ruClZmw2KZjGWGVKZIu/CDiiVaZUAKQgsLS4bUUtfToY 1C5KkkFf0/PFdkCivucrUNWq2ilS5AyD9S1g2e0WSWyobFV0di89M/D2fXkqj34W CpFP0BfHVxqGSsoKqqaKAa5rxVFQn/fOSDuA/H1YHL51PizlJafdsDq2teWieydA pAi+Uy88XN3e9jmq9Y7SZogx4cm9Id5ggpn/kCSySQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvdeljedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepteeuvefhhfdufedvgeeiueeileegtdfhgeeftdeuveejjedtgfejhedujeeutddu necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphhsse hpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Jan 2024 04:55:25 -0500 (EST) Received: by vm-mail (OpenSMTPD) with ESMTPSA id 60293e93 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 26 Jan 2024 09:52:12 +0000 (UTC) Date: Fri, 26 Jan 2024 10:55:21 +0100 From: Patrick Steinhardt To: Nikolaos Chatzikonstantinou Cc: Daniel Kiper , phcoder@gmail.com, grub-devel@gnu.org Subject: Re: State of Argon2 support Message-ID: References: <20240123165757.nkjtebueyyqks3b5@tomti.i.net-space.pl> <20240125181501.ucw4kxn6g4bx7y2l@tomti.i.net-space.pl> MIME-Version: 1.0 In-Reply-To: Received-SPF: pass client-ip=66.111.4.26; envelope-from=ps@pks.im; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Type: multipart/mixed; boundary="===============8577128747074410787==" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org --===============8577128747074410787== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lzMyCbFh2kLU8juG" Content-Disposition: inline --lzMyCbFh2kLU8juG Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 26, 2024 at 03:18:57AM -0500, Nikolaos Chatzikonstantinou wrote: > On Thu, Jan 25, 2024 at 1:15=E2=80=AFPM Daniel Kiper wrote: > > > > Adding Vladimir who knows GRUB history better than I... > > > > On Wed, Jan 24, 2024 at 01:23:55AM -0500, Nikolaos Chatzikonstantinou w= rote: > > > > [...] > > > > > My apologies for the repeated messages, but I came up with just one > > > more question that I'm curious about. To summarize my questions: > > > > > > 1. Where is the libgcrypt bundle from grub from? I think my > > > investigation has led me around version 1.7.0 of libgcrypt, but if I > > > can get a precise commit or version, that would be useful. > > > > > > ... and now to my new question: > > > > Vladimir, could you help with that? > > > > > 2. What is the reason libgcrypt is bundled as opposed to a regular de= pendency? > > > > I am not entirely sure I understand the question. Could you elaborate? >=20 > By bundling, I mean that someone copied libgcrypt files into the GRUB pro= ject. >=20 > To elaborate further, regular programs (not like GRUB which is a > bootloader) can link statically or dynamically to libraries; but also, > there's a third option, to dump the source code of a library directly > into the source tree of the project. To my understanding this third > option (which is not really a third linker option as it is not related > to the linker) is chosen when the project needs to include its own > patch set to the library. I am curious if GRUB has patched libgcrypt > for some reason, and is that why libgcrypt is bundled with GRUB? Yeah, the libgcrypt version carried by GRUB is heavily patched so that it compiles within the non-libc environment that GRUB uses. That is the whole crux of this topic -- if libgcrypt was simply a vanilla version then it shouldn't be all that hard to update. I think in the long term it would be great indeed if we could refrain =66rom patching libgcrypt to the widest extent possible so that future updates become easier. I guess that would require something of a "shim" header that makes available all of the prerequisites that are currently missing for libgcrypt to compile. Patrick --lzMyCbFh2kLU8juG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmWzgYgACgkQVbJhu7ck PpSmFQ//SZC0n7ITIaXuf1Ee3Xy824JiT7/8KBpuDwlFkfxAdehW01ngLlo7cFva mQVOOV2ASpSs1kWUgSOBaW3U+cEiNgs98ET6VuP+Jzx6ptDGwckuVTMZiFVzTLfR Z6ILPdhq8EkzxumWQ9Q52v/es1VqE3zZxGwvw8xakS/vUR0U7+THh4q/pfBQrvTd C0yFqTWGiX2KsDONVGE7KHzMZU3EdHO4LfoqdWY/JbCqLX3sCq+5YOKBDzo3dEL3 zHJW9Ia4Gl5LPZZNBZwlhj7aBNT9ZkWkAgMXOj7qFB5fwfsx1hli8C8VhQ1lcPg8 j5vzX6QisO2agxe8XvXYBqSk5xylA9tq6q4lqWezVb/FOkGil5WohhKMZmObAOhm ylClzVMOubSwa2kW13AUOaNcvNeoJXfoDwwRoKhCyxRe4brES8auB2wUnSV572mg Zips5MdNsNLufvbbCByVG8nLX0BT2R9+/vkOQcNLlyJKJI+yYBmcfBE181PRMfqp G5dMQ/9uGUnjGEGXILl0WnNu/m+2A/8zAKCYIKvYraAVcW9PYmKZiPkz3/p0Mo4Q fx36xB/lWf9HChoe4rvJ3/Qa8xiWXh82/MBBu7N+AyKB252fVsARLQEm64KL1TtT /EVY3e6Xq6BTIYwGFipXwsScf47SzjKoq8s9qN9m9Pfx3lQwALM= =xO7g -----END PGP SIGNATURE----- --lzMyCbFh2kLU8juG-- --===============8577128747074410787== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3J1Yi1kZXZl bCBtYWlsaW5nIGxpc3QKR3J1Yi1kZXZlbEBnbnUub3JnCmh0dHBzOi8vbGlzdHMuZ251Lm9yZy9t YWlsbWFuL2xpc3RpbmZvL2dydWItZGV2ZWwK --===============8577128747074410787==--