From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Yicong Yang <yangyicong@huawei.com>,
namhyung@kernel.org, peterz@infradead.org, mark.rutland@arm.com,
alexander.shishkin@linux.intel.com, jolsa@kernel.org,
linux-perf-users@vger.kernel.org, yangyicong@hisilicon.com,
hejunhao3@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH] perf build: Make minimal shellcheck version to v0.6.0
Date: Fri, 26 Jan 2024 11:26:38 -0300 [thread overview]
Message-ID: <ZbPBHmvKJJlprxac@kernel.org> (raw)
In-Reply-To: <CAP-5=fVzaRycRX2+NNMRp423sU5qpBa8z8p-WmF5sX+ty1Xf8A@mail.gmail.com>
Em Tue, Jan 23, 2024 at 08:04:55AM -0800, Ian Rogers escreveu:
> On Mon, Jan 22, 2024 at 12:08 AM Yicong Yang <yangyicong@huawei.com> wrote:
> >
> > From: Yicong Yang <yangyicong@hisilicon.com>
> >
> > perf build failed due to the shellcheck on my machine (v0.4.6 on Ubuntu
> > 18.04.1 LTS) doesn't support -a/--check-sourced and -S/--severity option.
> > These two options are introduced in shellcheck v0.4.7 and v0.6.0
> > respectively. So restrict the minimal version of shellcheck to v0.6.0.
> >
> > Fixes: b809fc656e76 ("perf build: Shellcheck support for OUTPUT directory")
> > Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>
> Reviewed-by: Ian Rogers <irogers@google.com>
Thanks, applied to perf-tools.
- Arnaldo
next prev parent reply other threads:[~2024-01-26 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 8:04 [PATCH] perf build: Make minimal shellcheck version to v0.6.0 Yicong Yang
2024-01-23 16:04 ` Ian Rogers
2024-01-26 14:26 ` Arnaldo Carvalho de Melo [this message]
2024-01-24 1:01 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbPBHmvKJJlprxac@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=hejunhao3@huawei.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mark.rutland@arm.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.