From: Adam Goldman <adamg@pobox.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: core: mask previous entry's type bits when looking for leaf
Date: Fri, 26 Jan 2024 20:53:42 -0800 [thread overview]
Message-ID: <ZbSMVdOZB1zusXmo@iguana.24-8.net> (raw)
In-Reply-To: <20240126121917.GA99160@workstation.local>
On Fri, Jan 26, 2024 at 09:19:17PM +0900, Takashi Sakamoto wrote:
> I think we can handle the quirk of configuration ROM without changing
> the kernel API. Would you test the following patch? (not tested in my
> side).
>
> ======== 8< --------
>
> >From 83bf1e04d308ea89c76c64e3168b9701f9d9191b Mon Sep 17 00:00:00 2001
> From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> Date: Fri, 26 Jan 2024 20:37:21 +0900
> Subject: [PATCH] firewire: search descriptor leaf just after vendor directory
> entry in root directory
Hi Takashi,
I tested your patch with the DVMC-DA1. I also tested it with another
device with normal placement of the leaf entry. In both cases, it works.
-- Adam
next prev parent reply other threads:[~2024-01-27 4:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ZbJQ0JdbGixJouvn@iguana.24-8.net>
2024-01-26 1:17 ` [PATCH] firewire: core: mask previous entry's type bits when looking for leaf Takashi Sakamoto
2024-01-26 8:49 ` Adam Goldman
2024-01-26 12:19 ` Takashi Sakamoto
2024-01-27 4:53 ` Adam Goldman [this message]
2024-01-30 19:10 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbSMVdOZB1zusXmo@iguana.24-8.net \
--to=adamg@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.