From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC4FFC47DDB for ; Sat, 27 Jan 2024 09:31:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aU15YHKsPREvvTXcIUXVbJPZtSIaluMNVne51OUaKjU=; b=Yxf5CenojyKUPz cx101h8QoA4DzvaKHQrtGdYK2XZHFzpjH3ikzgbebA6D9PqPQPOqp0jzx1k07s0bp2mZX9alI9cJ4 3AgNC4WZVD2FLMZjhcWh5CyONBT4HGlx5xzLpVhPBiNib+3yjcD9aLACZEcpjwfSYvZViNf2+k29R lufBjCDtvccOYt0nnO+GhMZr6EikeMAYBuSp/tNhAEMWqVp+i+E/2R4MdEFBnhWK/9iKIZz6OrEh7 xxAfW8ijhsFCPOAnDp5Hg+C33DkWNDO7FVzovfd8VFMxuMza7D1qvvum5TSxOaklGF2plWHIllHix ubWAXCsE96YppYkZT8cQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTf22-00000007FcL-4A4a; Sat, 27 Jan 2024 09:31:22 +0000 Received: from mecka.net ([159.69.159.214]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTf1t-00000007FRr-0yka; Sat, 27 Jan 2024 09:31:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mecka.net; s=2016.11; t=1706347870; bh=ZKfXwd9FW0rWdUEIALu0OP8KvDADbdtz+p95WviJSc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E5zqKQbgtz/Vq1FfeGeVWFW44FAQes1TM4fjycxZbs1PXj/kVBhPZtt8C/MCLa5XM dai1JImK0gvTG3CT70igLp2rBfb57qbRrPLdvZba717th93qWGahfDoSPH4YxzXy3o KFLVR2c/ArebjwwBnqxAOeAtAR7PvYD0LYY6uiOcH8I94rBblNT04Edw8a4onAr+Ui fYBHN55OgbOXxjVOCIvNjCAajRO1CrZrvjnBCMu+xHqEC4DExZ/uHvnMUiudhwP5m+ S/9hkxTVl5vu66m9D3t65iwe/mRLoQov1gFs/bJPNdYvl2v6JKRQOKRP4DWuu9e4WG z4X7wSbggV/gw== Received: from mecka.net (unknown [185.147.11.134]) by mecka.net (Postfix) with ESMTPSA id A981E3BF3AE; Sat, 27 Jan 2024 10:31:09 +0100 (CET) Date: Sat, 27 Jan 2024 10:31:08 +0100 From: Manuel Traut To: Jonas Karlman Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sandy Huang , Mark Yao , Diederik de Haas , Segfault , Arnaud Ferraris , Danct12 , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2 Message-ID: References: <20240102-pinetab2-v3-0-cb1aa69f8c30@mecka.net> <20240102-pinetab2-v3-4-cb1aa69f8c30@mecka.net> <775vjfucu2g2s6zzeutj7f7tapx3q2geccpxvv4ppcms4hxbq7@cbrdmlu2ryzp> <903e9d0c-a00c-4214-9f0e-dd676b13b428@kwiboo.se> <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_013113_911870_7CC010D9 X-CRM114-Status: GOOD ( 27.68 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgSm9uYXMsCgpPbiBXZWQsIEphbiAwMywgMjAyNCBhdCAwMzoxOToyNVBNICswMTAwLCBKb25h cyBLYXJsbWFuIHdyb3RlOgo+IEhpIE1hbnVlbCwKPiAKPiBPbiAyMDI0LTAxLTAzIDE0OjQwLCBN YW51ZWwgVHJhdXQgd3JvdGU6Cj4gPiBIaSBKb25hcyBhbmQgT25kxZllaiwKPiA+IAo+ID4+Pj4g KyZzZmMgewo+ID4+Pj4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ID4+Pj4gKwlwaW5j dHJsLTAgPSA8JmZzcGlfZHVhbF9pb19waW5zPjsKPiA+Pj4+ICsJc3RhdHVzID0gIm9rYXkiOwo+ ID4+Pj4gKwkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+Pj4+ICsJI3NpemUtY2VsbHMgPSA8MD47 Cj4gPj4+PiArCj4gPj4+PiArCWZsYXNoQDAgewo+ID4+Pj4gKwkJY29tcGF0aWJsZSA9ICJqZWRl YyxzcGktbm9yIjsKPiA+Pj4+ICsJCXJlZyA9IDwwPjsKPiA+Pj4+ICsJCXNwaS1tYXgtZnJlcXVl bmN5ID0gPDI0MDAwMDAwPjsKPiA+Pj4KPiA+Pj4gVGhhdCdzIGEgYml0IG9uIHRoZSBsb3cgc2lk ZS4gVGhlIGZsYXNoIGNoaXAgc2hvdWxkIHdvcmsgZm9yIGFsbCBjb21tYW5kcyB1cCB0bwo+ID4+ PiA4ME1IeiBodHRwczovL21lZ291cy5jb20vZGwvdG1wL2I0MjhhZDliODVhYzQ2MzMucG5nIGFu ZCBTR00zMTU3WUM2IHN3aXRjaAo+ID4+PiBmb3IgdGhlIEZTUEktQ0xLIHNob3VsZCBoYXZlIGhp Z2ggZW5vdWdoIGJhbmR3aWR0aCwgdG9vLgo+ID4+Cj4gPj4gSSBhZ3JlZSB0aGF0IHRoaXMgaXMg YSBsaXR0bGUgYml0IG9uIHRoZSBsb3cgc2lkZSwgaXQgd2FzIGEgc2FmZSByYXRlCj4gPj4gdGhh dCBJIHVzZWQgZm9yIFUtQm9vdC4gVS1Cb290IHJlcXVpcmVkIGFuIGV4YWN0IHJhdGUgb2YgdGhl IHN1cHBvcnRlZAo+ID4+IHNmYyBjbGsgcmF0ZXM6IDI0LCA1MCwgNzUsIDEwMCwgMTI1IG9yIDE1 MCBNSHouCj4gPj4KPiA+PiBQbGVhc2UgYWxzbyBub3RlIHRoYXQgdGhlIFNQSSBOT1IgZmxhc2gg Y2hpcCB1c2VkIGluIFBpbmVUYWIyIGlzIG5vdCBhCj4gPj4gR2lnYURldmljZSBHRDI1TFExMjhF LCBpdCBzaG91bGQgYmUgYSBTaWxpY29uS2Fpc2VyIFNLMjVMUDEyOCwgc2FtZSBhcwo+ID4+IGZv dW5kIGluIHRoZSBQaW5lNjQgUGluZVBob25lIFByby4KPiA+IAo+ID4gVGhlIHNjaGVtYXRpY3Mg Zm9yIHYyLjAgcmVmZXJlbmNlIGEgR0QyNUxRMTI4RVdJR1IuIEkgbmV2ZXIgY2hlY2tlZCB0aGUg amVkZWMKPiA+IGlkLiBIb3cgZGlkIHlvdSByZXRyaWV2ZSB0aGlzIGluZm9ybWF0aW9uLCBvciBp cyBpdCBtYXliZSBhIGRpZmZlcmVuY2UgaW4gdjAuMQo+ID4gYW5kIDIuMD8KPiAKPiBUaGlzIHdh cyB3aGVuIHdvcmtpbmcgb24gbWFpbmxpbmUgVS1Cb290IGZvciB0aGUgUGluZVRhYjIgKGFuZCBv dGhlcgo+IHJrMzU2eCBkZXZpY2VzKS4gU2VlIFsxXSBmb3IgYSBwZW5kaW5nIFUtQm9vdCBwYXRj aCB0aGF0IGlzIHdhaXRpbmcgb24gYQo+IHByb3BlciBtYWlubGluZSBsaW51eCBkZXZpY2V0cmVl IGZvciB0aGUgUFQyLgo+IAo+IFRoZSBKRURFQyBJRCBpcyByZXBvcnRlZCBhcyAweDI1NzAxOCBv biBteSB2Mi4wIHByb2R1Y3Rpb24gdW5pdCwgYW5kCj4gZG9lcyBub3QgbWF0Y2ggdGhlIEpFREVD IElEIGZvciBHRDI1TFExMjhFICgweGM4NjAxOCkgcmVmZXJlbmNlZCBpbgo+IHRoZSBzY2hlbWF0 aWNzLgo+IAo+IEkgZm91bmQgdGhhdCB0aGUgSkVERUMgSUQgMHgyNTcwMTggd2FzIHJlZmVyZW5j ZWQgaW4gcHJpb3IgcGF0Y2hlcwo+IHJlbGF0ZWQgdG8gdGhlIFNLMjVMUDEyOCBTUEkgTk9SIGZs YXNoIGNoaXAgdXNlZCBpbiBQaW5lNjQgUGluZVBob25lIFByby4KPiAKPiBJIGhhdmUgb25seSBl dmVyIHRlc3RlZCB0aGUgMjQgTUh6IHJhdGUsIGJ1dCBJIGFtIGV4cGVjdGluZyB0aGF0IGUuZy4K PiAxMDAgTUh6IGFsc28gc2hvdWxkIHdvcmsuIFdpbGwgbm90IGJlIGFibGUgdG8gdGVzdCBvbiBt eSBQVDIgdW50aWwgYXQKPiBlYXJsaWVzdCBuZXh0IHdlZWsuCj4gCj4gWzFdIGh0dHBzOi8vZ2l0 aHViLmNvbS9Ld2lib28vdS1ib290LXJvY2tjaGlwL2NvbW1pdC82NjU2MmQ2ZWFmMmMxMWE5Zjk3 ZmNkYmEzNzlkM2NlZGE4YWE3MGVmCgpJIGZvdW5kIHRoZSB0aW1lIHRvIHZlcmlmeSB0aGF0IDEw MCBNSHogaXMgYWxzbyB3b3JraW5nLgpXaWxsIGluY2x1ZGUgdGhpcyBpbiB2NAoKVGhhbmtzIGZv ciB5b3VyIGhlbHAKTWFudWVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxpc3QKTGludXgtcm9ja2NoaXBAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25EA0C46CD2 for ; Sat, 27 Jan 2024 09:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5eUWM7w8YpIWMd48X1SPGxvJczFoVtoFA5Fhavgs1+Q=; b=dX3BF+Zf3BHyZl PfJqjTPxpnu28evgR6tiU4H/M4ngAaMmFytwjUcmuFTIWU5ug5BrbaftctZb0168iRfE67dz7V/RM DjcQQOwtolRAwaEQG8hn0PiayEgcQna22AVmnBubutP2YtXK+6C72L15fuSCda7u1sXBU7LpavrRH aiN3xGHIakLxB78+KHLHCAx40gTvawc+kJvyXQCm8WkE/XfvFOL/6zi/A8Vik7WVFgz7njcud/86q /r8vpvIp5heqrWg/VqQ/Ze4VBlfjdYuVxIl+nKRioakJT4LooLMwQtnwxrNwj4fBR6W33H3/NQ03G Zo6ZmETY2Mq90TV8itEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTf1z-00000007FZH-3wK8; Sat, 27 Jan 2024 09:31:19 +0000 Received: from mecka.net ([159.69.159.214]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTf1t-00000007FRr-0yka; Sat, 27 Jan 2024 09:31:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mecka.net; s=2016.11; t=1706347870; bh=ZKfXwd9FW0rWdUEIALu0OP8KvDADbdtz+p95WviJSc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E5zqKQbgtz/Vq1FfeGeVWFW44FAQes1TM4fjycxZbs1PXj/kVBhPZtt8C/MCLa5XM dai1JImK0gvTG3CT70igLp2rBfb57qbRrPLdvZba717th93qWGahfDoSPH4YxzXy3o KFLVR2c/ArebjwwBnqxAOeAtAR7PvYD0LYY6uiOcH8I94rBblNT04Edw8a4onAr+Ui fYBHN55OgbOXxjVOCIvNjCAajRO1CrZrvjnBCMu+xHqEC4DExZ/uHvnMUiudhwP5m+ S/9hkxTVl5vu66m9D3t65iwe/mRLoQov1gFs/bJPNdYvl2v6JKRQOKRP4DWuu9e4WG z4X7wSbggV/gw== Received: from mecka.net (unknown [185.147.11.134]) by mecka.net (Postfix) with ESMTPSA id A981E3BF3AE; Sat, 27 Jan 2024 10:31:09 +0100 (CET) Date: Sat, 27 Jan 2024 10:31:08 +0100 From: Manuel Traut To: Jonas Karlman Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sandy Huang , Mark Yao , Diederik de Haas , Segfault , Arnaud Ferraris , Danct12 , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2 Message-ID: References: <20240102-pinetab2-v3-0-cb1aa69f8c30@mecka.net> <20240102-pinetab2-v3-4-cb1aa69f8c30@mecka.net> <775vjfucu2g2s6zzeutj7f7tapx3q2geccpxvv4ppcms4hxbq7@cbrdmlu2ryzp> <903e9d0c-a00c-4214-9f0e-dd676b13b428@kwiboo.se> <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240127_013113_911870_7CC010D9 X-CRM114-Status: GOOD ( 27.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgSm9uYXMsCgpPbiBXZWQsIEphbiAwMywgMjAyNCBhdCAwMzoxOToyNVBNICswMTAwLCBKb25h cyBLYXJsbWFuIHdyb3RlOgo+IEhpIE1hbnVlbCwKPiAKPiBPbiAyMDI0LTAxLTAzIDE0OjQwLCBN YW51ZWwgVHJhdXQgd3JvdGU6Cj4gPiBIaSBKb25hcyBhbmQgT25kxZllaiwKPiA+IAo+ID4+Pj4g KyZzZmMgewo+ID4+Pj4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ID4+Pj4gKwlwaW5j dHJsLTAgPSA8JmZzcGlfZHVhbF9pb19waW5zPjsKPiA+Pj4+ICsJc3RhdHVzID0gIm9rYXkiOwo+ ID4+Pj4gKwkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiA+Pj4+ICsJI3NpemUtY2VsbHMgPSA8MD47 Cj4gPj4+PiArCj4gPj4+PiArCWZsYXNoQDAgewo+ID4+Pj4gKwkJY29tcGF0aWJsZSA9ICJqZWRl YyxzcGktbm9yIjsKPiA+Pj4+ICsJCXJlZyA9IDwwPjsKPiA+Pj4+ICsJCXNwaS1tYXgtZnJlcXVl bmN5ID0gPDI0MDAwMDAwPjsKPiA+Pj4KPiA+Pj4gVGhhdCdzIGEgYml0IG9uIHRoZSBsb3cgc2lk ZS4gVGhlIGZsYXNoIGNoaXAgc2hvdWxkIHdvcmsgZm9yIGFsbCBjb21tYW5kcyB1cCB0bwo+ID4+ PiA4ME1IeiBodHRwczovL21lZ291cy5jb20vZGwvdG1wL2I0MjhhZDliODVhYzQ2MzMucG5nIGFu ZCBTR00zMTU3WUM2IHN3aXRjaAo+ID4+PiBmb3IgdGhlIEZTUEktQ0xLIHNob3VsZCBoYXZlIGhp Z2ggZW5vdWdoIGJhbmR3aWR0aCwgdG9vLgo+ID4+Cj4gPj4gSSBhZ3JlZSB0aGF0IHRoaXMgaXMg YSBsaXR0bGUgYml0IG9uIHRoZSBsb3cgc2lkZSwgaXQgd2FzIGEgc2FmZSByYXRlCj4gPj4gdGhh dCBJIHVzZWQgZm9yIFUtQm9vdC4gVS1Cb290IHJlcXVpcmVkIGFuIGV4YWN0IHJhdGUgb2YgdGhl IHN1cHBvcnRlZAo+ID4+IHNmYyBjbGsgcmF0ZXM6IDI0LCA1MCwgNzUsIDEwMCwgMTI1IG9yIDE1 MCBNSHouCj4gPj4KPiA+PiBQbGVhc2UgYWxzbyBub3RlIHRoYXQgdGhlIFNQSSBOT1IgZmxhc2gg Y2hpcCB1c2VkIGluIFBpbmVUYWIyIGlzIG5vdCBhCj4gPj4gR2lnYURldmljZSBHRDI1TFExMjhF LCBpdCBzaG91bGQgYmUgYSBTaWxpY29uS2Fpc2VyIFNLMjVMUDEyOCwgc2FtZSBhcwo+ID4+IGZv dW5kIGluIHRoZSBQaW5lNjQgUGluZVBob25lIFByby4KPiA+IAo+ID4gVGhlIHNjaGVtYXRpY3Mg Zm9yIHYyLjAgcmVmZXJlbmNlIGEgR0QyNUxRMTI4RVdJR1IuIEkgbmV2ZXIgY2hlY2tlZCB0aGUg amVkZWMKPiA+IGlkLiBIb3cgZGlkIHlvdSByZXRyaWV2ZSB0aGlzIGluZm9ybWF0aW9uLCBvciBp cyBpdCBtYXliZSBhIGRpZmZlcmVuY2UgaW4gdjAuMQo+ID4gYW5kIDIuMD8KPiAKPiBUaGlzIHdh cyB3aGVuIHdvcmtpbmcgb24gbWFpbmxpbmUgVS1Cb290IGZvciB0aGUgUGluZVRhYjIgKGFuZCBv dGhlcgo+IHJrMzU2eCBkZXZpY2VzKS4gU2VlIFsxXSBmb3IgYSBwZW5kaW5nIFUtQm9vdCBwYXRj aCB0aGF0IGlzIHdhaXRpbmcgb24gYQo+IHByb3BlciBtYWlubGluZSBsaW51eCBkZXZpY2V0cmVl IGZvciB0aGUgUFQyLgo+IAo+IFRoZSBKRURFQyBJRCBpcyByZXBvcnRlZCBhcyAweDI1NzAxOCBv biBteSB2Mi4wIHByb2R1Y3Rpb24gdW5pdCwgYW5kCj4gZG9lcyBub3QgbWF0Y2ggdGhlIEpFREVD IElEIGZvciBHRDI1TFExMjhFICgweGM4NjAxOCkgcmVmZXJlbmNlZCBpbgo+IHRoZSBzY2hlbWF0 aWNzLgo+IAo+IEkgZm91bmQgdGhhdCB0aGUgSkVERUMgSUQgMHgyNTcwMTggd2FzIHJlZmVyZW5j ZWQgaW4gcHJpb3IgcGF0Y2hlcwo+IHJlbGF0ZWQgdG8gdGhlIFNLMjVMUDEyOCBTUEkgTk9SIGZs YXNoIGNoaXAgdXNlZCBpbiBQaW5lNjQgUGluZVBob25lIFByby4KPiAKPiBJIGhhdmUgb25seSBl dmVyIHRlc3RlZCB0aGUgMjQgTUh6IHJhdGUsIGJ1dCBJIGFtIGV4cGVjdGluZyB0aGF0IGUuZy4K PiAxMDAgTUh6IGFsc28gc2hvdWxkIHdvcmsuIFdpbGwgbm90IGJlIGFibGUgdG8gdGVzdCBvbiBt eSBQVDIgdW50aWwgYXQKPiBlYXJsaWVzdCBuZXh0IHdlZWsuCj4gCj4gWzFdIGh0dHBzOi8vZ2l0 aHViLmNvbS9Ld2lib28vdS1ib290LXJvY2tjaGlwL2NvbW1pdC82NjU2MmQ2ZWFmMmMxMWE5Zjk3 ZmNkYmEzNzlkM2NlZGE4YWE3MGVmCgpJIGZvdW5kIHRoZSB0aW1lIHRvIHZlcmlmeSB0aGF0IDEw MCBNSHogaXMgYWxzbyB3b3JraW5nLgpXaWxsIGluY2x1ZGUgdGhpcyBpbiB2NAoKVGhhbmtzIGZv ciB5b3VyIGhlbHAKTWFudWVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVs QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mecka.net (mecka.net [159.69.159.214]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E55561E88B; Sat, 27 Jan 2024 09:31:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.159.214 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706347875; cv=none; b=PCUJPfsZFoMOJ2SJu4ZNLH7JEZJywzoJrbD1jo5e2qruyTSNsKo7PmqQ4KD5eYrknFwCZ7oUwN9nrOOHYE66nCVAXMBEQQvcFf2whWz2bUffEmT1dgTqti2Rslv4jcyBgzUB0wcuIdAaSwF0YK97ifIEv4t6BTZ4uyyNFACu42Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706347875; c=relaxed/simple; bh=ZKfXwd9FW0rWdUEIALu0OP8KvDADbdtz+p95WviJSc4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fyuioiQsHZA0v4N1ZvbbZdwcSCee5lHRm0Eh1djD5i9vQ99YIu81ymIhUtpEL2EgwxUxLxDm0/KOjV42DKZozZwgfJ+cK7p05AYWAQgH+f3Zi7RBDiFgbnbCn5eHEbZ1ftbtUndMjxaQ7KHHZCqaEKZMp2JV3G4mtbIkyWBXtOQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mecka.net; spf=pass smtp.mailfrom=mecka.net; dkim=fail (0-bit key) header.d=mecka.net header.i=@mecka.net header.b=E5zqKQbg reason="key not found in DNS"; arc=none smtp.client-ip=159.69.159.214 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mecka.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mecka.net Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mecka.net header.i=@mecka.net header.b="E5zqKQbg" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mecka.net; s=2016.11; t=1706347870; bh=ZKfXwd9FW0rWdUEIALu0OP8KvDADbdtz+p95WviJSc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E5zqKQbgtz/Vq1FfeGeVWFW44FAQes1TM4fjycxZbs1PXj/kVBhPZtt8C/MCLa5XM dai1JImK0gvTG3CT70igLp2rBfb57qbRrPLdvZba717th93qWGahfDoSPH4YxzXy3o KFLVR2c/ArebjwwBnqxAOeAtAR7PvYD0LYY6uiOcH8I94rBblNT04Edw8a4onAr+Ui fYBHN55OgbOXxjVOCIvNjCAajRO1CrZrvjnBCMu+xHqEC4DExZ/uHvnMUiudhwP5m+ S/9hkxTVl5vu66m9D3t65iwe/mRLoQov1gFs/bJPNdYvl2v6JKRQOKRP4DWuu9e4WG z4X7wSbggV/gw== Received: from mecka.net (unknown [185.147.11.134]) by mecka.net (Postfix) with ESMTPSA id A981E3BF3AE; Sat, 27 Jan 2024 10:31:09 +0100 (CET) Date: Sat, 27 Jan 2024 10:31:08 +0100 From: Manuel Traut To: Jonas Karlman Cc: =?utf-8?Q?Ond=C5=99ej?= Jirman , Neil Armstrong , Jessica Zhang , Sam Ravnborg , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sandy Huang , Mark Yao , Diederik de Haas , Segfault , Arnaud Ferraris , Danct12 , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2 Message-ID: References: <20240102-pinetab2-v3-0-cb1aa69f8c30@mecka.net> <20240102-pinetab2-v3-4-cb1aa69f8c30@mecka.net> <775vjfucu2g2s6zzeutj7f7tapx3q2geccpxvv4ppcms4hxbq7@cbrdmlu2ryzp> <903e9d0c-a00c-4214-9f0e-dd676b13b428@kwiboo.se> <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> Hi Jonas, On Wed, Jan 03, 2024 at 03:19:25PM +0100, Jonas Karlman wrote: > Hi Manuel, > > On 2024-01-03 14:40, Manuel Traut wrote: > > Hi Jonas and Ondřej, > > > >>>> +&sfc { > >>>> + pinctrl-names = "default"; > >>>> + pinctrl-0 = <&fspi_dual_io_pins>; > >>>> + status = "okay"; > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + > >>>> + flash@0 { > >>>> + compatible = "jedec,spi-nor"; > >>>> + reg = <0>; > >>>> + spi-max-frequency = <24000000>; > >>> > >>> That's a bit on the low side. The flash chip should work for all commands up to > >>> 80MHz https://megous.com/dl/tmp/b428ad9b85ac4633.png and SGM3157YC6 switch > >>> for the FSPI-CLK should have high enough bandwidth, too. > >> > >> I agree that this is a little bit on the low side, it was a safe rate > >> that I used for U-Boot. U-Boot required an exact rate of the supported > >> sfc clk rates: 24, 50, 75, 100, 125 or 150 MHz. > >> > >> Please also note that the SPI NOR flash chip used in PineTab2 is not a > >> GigaDevice GD25LQ128E, it should be a SiliconKaiser SK25LP128, same as > >> found in the Pine64 PinePhone Pro. > > > > The schematics for v2.0 reference a GD25LQ128EWIGR. I never checked the jedec > > id. How did you retrieve this information, or is it maybe a difference in v0.1 > > and 2.0? > > This was when working on mainline U-Boot for the PineTab2 (and other > rk356x devices). See [1] for a pending U-Boot patch that is waiting on a > proper mainline linux devicetree for the PT2. > > The JEDEC ID is reported as 0x257018 on my v2.0 production unit, and > does not match the JEDEC ID for GD25LQ128E (0xc86018) referenced in > the schematics. > > I found that the JEDEC ID 0x257018 was referenced in prior patches > related to the SK25LP128 SPI NOR flash chip used in Pine64 PinePhone Pro. > > I have only ever tested the 24 MHz rate, but I am expecting that e.g. > 100 MHz also should work. Will not be able to test on my PT2 until at > earliest next week. > > [1] https://github.com/Kwiboo/u-boot-rockchip/commit/66562d6eaf2c11a9f97fcdba379d3ceda8aa70ef I found the time to verify that 100 MHz is also working. Will include this in v4 Thanks for your help Manuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 098BCC46CD2 for ; Sat, 27 Jan 2024 09:31:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 40F6A10EB2D; Sat, 27 Jan 2024 09:31:13 +0000 (UTC) Received: from mecka.net (mecka.net [159.69.159.214]) by gabe.freedesktop.org (Postfix) with ESMTP id CFD9910EB2D for ; Sat, 27 Jan 2024 09:31:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mecka.net; s=2016.11; t=1706347870; bh=ZKfXwd9FW0rWdUEIALu0OP8KvDADbdtz+p95WviJSc4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E5zqKQbgtz/Vq1FfeGeVWFW44FAQes1TM4fjycxZbs1PXj/kVBhPZtt8C/MCLa5XM dai1JImK0gvTG3CT70igLp2rBfb57qbRrPLdvZba717th93qWGahfDoSPH4YxzXy3o KFLVR2c/ArebjwwBnqxAOeAtAR7PvYD0LYY6uiOcH8I94rBblNT04Edw8a4onAr+Ui fYBHN55OgbOXxjVOCIvNjCAajRO1CrZrvjnBCMu+xHqEC4DExZ/uHvnMUiudhwP5m+ S/9hkxTVl5vu66m9D3t65iwe/mRLoQov1gFs/bJPNdYvl2v6JKRQOKRP4DWuu9e4WG z4X7wSbggV/gw== Received: from mecka.net (unknown [185.147.11.134]) by mecka.net (Postfix) with ESMTPSA id A981E3BF3AE; Sat, 27 Jan 2024 10:31:09 +0100 (CET) Date: Sat, 27 Jan 2024 10:31:08 +0100 From: Manuel Traut To: Jonas Karlman Subject: Re: [PATCH v3 4/4] arm64: dts: rockchip: Add devicetree for Pine64 PineTab2 Message-ID: References: <20240102-pinetab2-v3-0-cb1aa69f8c30@mecka.net> <20240102-pinetab2-v3-4-cb1aa69f8c30@mecka.net> <775vjfucu2g2s6zzeutj7f7tapx3q2geccpxvv4ppcms4hxbq7@cbrdmlu2ryzp> <903e9d0c-a00c-4214-9f0e-dd676b13b428@kwiboo.se> <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6efe305c-4ab4-43c1-ab6d-64bdf1d81a2f@kwiboo.se> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Diederik de Haas , Danct12 , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , David Airlie , Sam Ravnborg , linux-rockchip@lists.infradead.org, Jessica Zhang , devicetree@vger.kernel.org, Conor Dooley , Thomas Zimmermann , Maxime Ripard , Rob Herring , Mark Yao , linux-arm-kernel@lists.infradead.org, Neil Armstrong , Segfault , Sandy Huang , =?utf-8?Q?Ond=C5=99ej?= Jirman , Daniel Vetter , Arnaud Ferraris Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Jonas, On Wed, Jan 03, 2024 at 03:19:25PM +0100, Jonas Karlman wrote: > Hi Manuel, > > On 2024-01-03 14:40, Manuel Traut wrote: > > Hi Jonas and Ondřej, > > > >>>> +&sfc { > >>>> + pinctrl-names = "default"; > >>>> + pinctrl-0 = <&fspi_dual_io_pins>; > >>>> + status = "okay"; > >>>> + #address-cells = <1>; > >>>> + #size-cells = <0>; > >>>> + > >>>> + flash@0 { > >>>> + compatible = "jedec,spi-nor"; > >>>> + reg = <0>; > >>>> + spi-max-frequency = <24000000>; > >>> > >>> That's a bit on the low side. The flash chip should work for all commands up to > >>> 80MHz https://megous.com/dl/tmp/b428ad9b85ac4633.png and SGM3157YC6 switch > >>> for the FSPI-CLK should have high enough bandwidth, too. > >> > >> I agree that this is a little bit on the low side, it was a safe rate > >> that I used for U-Boot. U-Boot required an exact rate of the supported > >> sfc clk rates: 24, 50, 75, 100, 125 or 150 MHz. > >> > >> Please also note that the SPI NOR flash chip used in PineTab2 is not a > >> GigaDevice GD25LQ128E, it should be a SiliconKaiser SK25LP128, same as > >> found in the Pine64 PinePhone Pro. > > > > The schematics for v2.0 reference a GD25LQ128EWIGR. I never checked the jedec > > id. How did you retrieve this information, or is it maybe a difference in v0.1 > > and 2.0? > > This was when working on mainline U-Boot for the PineTab2 (and other > rk356x devices). See [1] for a pending U-Boot patch that is waiting on a > proper mainline linux devicetree for the PT2. > > The JEDEC ID is reported as 0x257018 on my v2.0 production unit, and > does not match the JEDEC ID for GD25LQ128E (0xc86018) referenced in > the schematics. > > I found that the JEDEC ID 0x257018 was referenced in prior patches > related to the SK25LP128 SPI NOR flash chip used in Pine64 PinePhone Pro. > > I have only ever tested the 24 MHz rate, but I am expecting that e.g. > 100 MHz also should work. Will not be able to test on my PT2 until at > earliest next week. > > [1] https://github.com/Kwiboo/u-boot-rockchip/commit/66562d6eaf2c11a9f97fcdba379d3ceda8aa70ef I found the time to verify that 100 MHz is also working. Will include this in v4 Thanks for your help Manuel