From: Jiri Olsa <olsajiri@gmail.com>
To: Menglong Dong <dongmenglong.8@bytedance.com>
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
john.fastabend@gmail.com, martin.lau@linux.dev,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline
Date: Sun, 28 Jan 2024 10:04:55 +0100 [thread overview]
Message-ID: <ZbYYtx7-Z-A07K4N@krava> (raw)
In-Reply-To: <20240128055443.413291-1-dongmenglong.8@bytedance.com>
On Sun, Jan 28, 2024 at 01:54:43PM +0800, Menglong Dong wrote:
> It seems that the field "mod" in struct bpf_trampoline is not used
> anywhere after the commit 31bf1dbccfb0 ("bpf: Fix attaching
> fentry/fexit/fmod_ret/lsm to modules"). So we can just remove it now.
>
> Signed-off-by: Menglong Dong <dongmenglong.8@bytedance.com>
Fixes: 31bf1dbccfb0 ("bpf: Fix attaching fentry/fexit/fmod_ret/lsm to modules")
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> include/linux/bpf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/bpf.h b/include/linux/bpf.h
> index b86bd15a051d..1ebbee1d648e 100644
> --- a/include/linux/bpf.h
> +++ b/include/linux/bpf.h
> @@ -1189,7 +1189,6 @@ struct bpf_trampoline {
> int progs_cnt[BPF_TRAMP_MAX];
> /* Executable image of trampoline */
> struct bpf_tramp_image *cur_image;
> - struct module *mod;
> };
>
> struct bpf_attach_target_info {
> --
> 2.39.2
>
next prev parent reply other threads:[~2024-01-28 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-28 5:54 [PATCH bpf-next] bpf: remove unused field "mod" in struct bpf_trampoline Menglong Dong
2024-01-28 9:04 ` Jiri Olsa [this message]
2024-01-29 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbYYtx7-Z-A07K4N@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dongmenglong.8@bytedance.com \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.