Re: [PATCH 2/2] dt-bindings: iio: imu: st_lsm6dsx: add asm330lhhxg1

[Lorenzo Bianconi <lorenzo@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1801 bytes --]

> On Wed, 24 Jan 2024 11:52:34 +0100
> Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> 
> > Add device bindings for asm330lhhxg1 IMU sensor.
> > Use asm330lhhx as fallback device for asm330lhhxg1 since it implements
> > all the features currently supported by asm330lhhxg1.
> 
> Can we clarify if the hardware of the asm330lhhxg1 supports
> 1) Exactly the same features as the asm330lhhx
>    (Valid use for a fallback compatible, because we might find
>     bugs etc in future).
> 2) More features, but the asm330lhhx features set is a subset.
>    (Most valid use for a fallback compatible)

Hi Jonathan,

afaik asm330lhhx supports a subset of asm330lhhxg1 features (adding st folks in
cc for some clarification here) but they are not implemented in st_lsm6dsx.

Regards,
Lorenzo

> 3) Different features from the asm330llhhx but driver only supports
>    a set both support? (this is a problem)
> 
> I 'think' it is 2 from your text, but I'm not 100% sure I've understood
> correctly.
> > 
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > index 28b667a9cb76..7ba3de66a2e1 100644
> > --- a/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > +++ b/Documentation/devicetree/bindings/iio/imu/st,lsm6dsx.yaml
> > @@ -49,6 +49,9 @@ properties:
> >        - items:
> >            - const: st,asm330lhb
> >            - const: st,asm330lhh
> > +      - items:
> > +          - const: st,asm330lhhxg1
> > +          - const: st,asm330lhhx
> >  
> >    reg:
> >      maxItems: 1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]