From: Johan Hovold <johan@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Michael Schaller <michael@5challer.de>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
regressions@lists.linux.dev,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Ajay Agarwal <ajayagarwal@google.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Johan Hovold <johan+linaro@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
stable@vger.kernel.org, regressions@leemhuis.info
Subject: Re: PCI/ASPM locking regression in 6.7-final (was: Re: [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()")
Date: Tue, 30 Jan 2024 11:07:46 +0100 [thread overview]
Message-ID: <ZbjKci6GuWVrpbri@hovoldconsulting.com> (raw)
In-Reply-To: <ZbDHZtR8Tg1hWAzc@hovoldconsulting.com>
On Wed, Jan 24, 2024 at 09:16:38AM +0100, Johan Hovold wrote:
> On Tue, Jan 23, 2024 at 04:36:48PM -0600, Bjorn Helgaas wrote:
> > I don't quite follow. By simply reverting, do you mean to revert
> > f93e71aea6c6 ("Revert "PCI/ASPM: Remove
> > pcie_aspm_pm_state_change()"")? IIUC that would break Michael's
> > machine again.
>
> Right, at least until that issue is fully understood and alternative
> fixes have been considered.
>
> If that's not an option, we need to rework core to pass a flag through
> more than one layer to indicate whether pcie_aspm_pm_state_change()
> should take the bus semaphore or not. I'd rather not do that if it can
> be avoided.
As a revert appears unlikely to happen, let's fix the regression by
adding a new helper pci_set_power_state_locked() that can be called
with the bus lock held:
https://lore.kernel.org/lkml/20240130100243.11011-1-johan+linaro@kernel.org/
Johan
next prev parent reply other threads:[~2024-01-30 10:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 18:29 [Regression] [PCI/ASPM] [ASUS PN51] Reboot on resume attempt (bisect done; commit found) Michael Schaller
2023-12-29 0:26 ` Bjorn Helgaas
2023-12-29 10:31 ` Michael Schaller
2024-01-01 18:13 ` Bjorn Helgaas
2024-01-01 18:57 ` Michael Schaller
2024-01-01 22:15 ` Bjorn Helgaas
2024-01-02 13:50 ` Michael Schaller
2024-01-03 8:21 ` Linux regression tracking (Thorsten Leemhuis)
2024-01-05 3:25 ` Kai-Heng Feng
2024-01-05 11:18 ` Michael Schaller
2024-01-05 15:51 ` Bjorn Helgaas
2024-01-10 3:43 ` Kai-Heng Feng
2024-01-10 12:39 ` Michael Schaller
2024-03-07 6:51 ` Kai-Heng Feng
2024-03-08 15:49 ` michael
2024-03-08 16:40 ` Bjorn Helgaas
2024-01-03 15:41 ` Ilpo Järvinen
2024-01-05 3:14 ` Kai-Heng Feng
2024-01-05 10:29 ` Ilpo Järvinen
2024-01-02 23:25 ` [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()" Bjorn Helgaas
2024-01-02 23:33 ` Kuppuswamy Sathyanarayanan
2024-01-03 0:12 ` Bjorn Helgaas
2024-01-08 8:39 ` Johan Hovold
2024-01-22 10:53 ` PCI/ASPM locking regression in 6.7-final (was: Re: [PATCH] Revert "PCI/ASPM: Remove pcie_aspm_pm_state_change()") Johan Hovold
2024-01-22 18:26 ` Bjorn Helgaas
2024-01-23 17:25 ` Johan Hovold
2024-01-23 22:36 ` Bjorn Helgaas
2024-01-24 8:16 ` Johan Hovold
2024-01-30 10:07 ` Johan Hovold [this message]
2024-02-09 12:45 ` PCI/ASPM locking regression in 6.7-final Linux regression tracking #update (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbjKci6GuWVrpbri@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=ajayagarwal@google.com \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=johan+linaro@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=michael@5challer.de \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.