All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Andrew Melnychenko <andrew@daynix.com>
Cc: jasowang@redhat.com, mst@redhat.com, armbru@redhat.com,
	eblake@redhat.com, qemu-devel@nongnu.org,
	yuri.benditovich@daynix.com, yan@daynix.com,
	akihiko.odaki@daynix.com
Subject: Re: [PATCH v8 1/5] ebpf: Added eBPF map update through mmap.
Date: Tue, 30 Jan 2024 10:37:59 +0000	[thread overview]
Message-ID: <ZbjRhyNtjajkYQ8i@redhat.com> (raw)
In-Reply-To: <20240125130656.425607-2-andrew@daynix.com>

On Thu, Jan 25, 2024 at 03:06:50PM +0200, Andrew Melnychenko wrote:
> Changed eBPF map updates through mmaped array.
> Mmaped arrays provide direct access to map data.
> It should omit using bpf_map_update_elem() call,
> which may require capabilities that are not present.
> 
> Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
> ---
>  ebpf/ebpf_rss.c | 120 ++++++++++++++++++++++++++++++++++++++----------
>  ebpf/ebpf_rss.h |   8 +++-
>  2 files changed, 101 insertions(+), 27 deletions(-)
> 
> diff --git a/ebpf/ebpf_rss.c b/ebpf/ebpf_rss.c
> index cee658c158..c6e10265a7 100644
> --- a/ebpf/ebpf_rss.c
> +++ b/ebpf/ebpf_rss.c
> @@ -7,8 +7,7 @@
>   *  Andrew Melnychenko <andrew@daynix.com>
>   *  Yuri Benditovich <yuri.benditovich@daynix.com>
>   *
> - * This work is licensed under the terms of the GNU GPL, version 2.  See
> - * the COPYING file in the top-level directory.
> + * SPDX-License-Identifier: GPL-2.0-or-later


> diff --git a/ebpf/ebpf_rss.h b/ebpf/ebpf_rss.h
> index bf3f2572c7..404cf53613 100644
> --- a/ebpf/ebpf_rss.h
> +++ b/ebpf/ebpf_rss.h
> @@ -7,8 +7,7 @@
>   *  Andrew Melnychenko <andrew@daynix.com>
>   *  Yuri Benditovich <yuri.benditovich@daynix.com>
>   *
> - * This work is licensed under the terms of the GNU GPL, version 2.  See
> - * the COPYING file in the top-level directory.
> + * SPDX-License-Identifier: GPL-2.0-or-later
>   */
>  
>  #ifndef QEMU_EBPF_RSS_H

Thee are changing the file license. This *must* be done as a
standalone commit and show agreement from all contributors
who could hold copyright over the code. Fortunately I only
see one other contributor to these file, and the scope of
their change isn't copyrightable IMHO.



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2024-01-30 10:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25 13:06 [PATCH v8 0/5] eBPF RSS through QMP support Andrew Melnychenko
2024-01-25 13:06 ` [PATCH v8 1/5] ebpf: Added eBPF map update through mmap Andrew Melnychenko
2024-01-30 10:37   ` Daniel P. Berrangé [this message]
2024-02-05 16:54     ` Andrew Melnichenko
2024-01-25 13:06 ` [PATCH v8 2/5] ebpf: Added eBPF initialization by fds Andrew Melnychenko
2024-01-25 13:06 ` [PATCH v8 3/5] virtio-net: Added property to load eBPF RSS with fds Andrew Melnychenko
2024-01-25 13:06 ` [PATCH v8 4/5] qmp: Added new command to retrieve eBPF blob Andrew Melnychenko
2024-01-25 13:06 ` [PATCH v8 5/5] ebpf: Updated eBPF program and skeleton Andrew Melnychenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbjRhyNtjajkYQ8i@redhat.com \
    --to=berrange@redhat.com \
    --cc=akihiko.odaki@daynix.com \
    --cc=andrew@daynix.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yan@daynix.com \
    --cc=yuri.benditovich@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.