From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90926C46CD2 for ; Tue, 30 Jan 2024 17:02:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1E16B00AE; Tue, 30 Jan 2024 12:02:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A916B00AF; Tue, 30 Jan 2024 12:02:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E06DC6B00B1; Tue, 30 Jan 2024 12:02:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CC9086B00AE for ; Tue, 30 Jan 2024 12:02:29 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4A9D6A1AE0 for ; Tue, 30 Jan 2024 17:02:29 +0000 (UTC) X-FDA: 81736596018.26.5079CA4 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf10.hostedemail.com (Postfix) with ESMTP id 1117AC0051 for ; Tue, 30 Jan 2024 17:02:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H23sFVzy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 3nSu5ZQoKCA4C265Cov0sru22uzs.q20zw18B-00y9oqy.25u@flex--yosryahmed.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3nSu5ZQoKCA4C265Cov0sru22uzs.q20zw18B-00y9oqy.25u@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706634143; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6OxUoyIJ3bgXe6LBTsvCQjNpEhIzQfA+N+joEQUVhLo=; b=NpB5SOwet44CYL3uQtZW/CYFltDWLO0QJYFRIkSJgDnG5bjy/nkLVT1yZGo1qWJsMtFMnK WhbWsF2Ls3GeRK7x7s9TTXvR8TasXXlaCETo92V/znBEpEAhHKgD3zTqQ4DNyyALnkTw46 VgASSRgCbKRJyeDHaLiUw95KfPpErD0= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=H23sFVzy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of 3nSu5ZQoKCA4C265Cov0sru22uzs.q20zw18B-00y9oqy.25u@flex--yosryahmed.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3nSu5ZQoKCA4C265Cov0sru22uzs.q20zw18B-00y9oqy.25u@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706634143; a=rsa-sha256; cv=none; b=VG3LSdZEmbbLouo7kZmMl0J8i9XgP3dh3GZxmFJi6zHIHsEu2m1vRWaBt8ILLVPvsUxvR1 sjUWOd5wURCY1lZRUPeCmfCrBWKjdS5NLAIQeE1YjeM6ySnVHy6fYgMJ+mKlBk3564ECi9 Sk5uVURP92a+s1ZblGh6EeI2ym1d1A0= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-6de1ea7d843so2716346b3a.2 for ; Tue, 30 Jan 2024 09:02:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706634141; x=1707238941; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=6OxUoyIJ3bgXe6LBTsvCQjNpEhIzQfA+N+joEQUVhLo=; b=H23sFVzyaxpt0/ShlCLuZAOcnbCaUNeLj8Svh7UlDW+hbge0RKVeId+lmqJ4nnq+jH JL5C3xqutmCjtnnwUdY0Z70c3gZ9VRHv91z3YwzIADjFsRsddJvYZU+t+Ys79EnmEOdf MJNEfO5C0EY855/vMxhmnVnRflOd15gtATOptaH5y68u923yC+/O7JxDDvRmbIP3SRbF 7yBBMNw5cOwuYwCUcdW/byQCVN/9ypDHr+1O5qWKPJKEuhsRZZVRYLjVMZq+vfL2AJQG PBxUNlS9AYLTVHt91f1//I74/rLdDSvKK7gE2WqD9h63HrUdrpwXnvIH7hop7w0RZNjt kpRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706634141; x=1707238941; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=6OxUoyIJ3bgXe6LBTsvCQjNpEhIzQfA+N+joEQUVhLo=; b=pEXaK3eRAmJO7gmyFdryEe4OBk9JDoqO42dCFljAl96b5lr2LrsCclQfwVQQSbUNEb lnUOTDgtbVsqcbNeDtB0RjlTunsBg/kxazIQ3Ah1x73IUrbz6pVp1TQdQJHqZdzQrxL4 ajddsWAlK6yPgmxbzma+U0zKs60V+fecch6Ad/xHhSV/efYLjcyUM8QaJq5AoZVXHvk4 zpRDpCZ3vYn6a2xLdFd3HBGdSkaF9t8K42296ERhqh1wJk7eY3hOW9nqwMCSujDwUmD0 FtLyeipjGcsbEbZfzt/dMGlwFZQzHE0XNAJPi8R+Q0+wudl4d0o2Q3BpCvG4bl756Q53 nPZg== X-Gm-Message-State: AOJu0Yy37HJPNfUhUc5n0eB7qBCgmdrhKnoFsJMHXqL0Zs9qULK7BUoB KcKRfplkoLD7mHWxZ+KrD40ZPZK/q98WK6QhFH6kc6Zrgn8g/vVmFZIuKCrAldsvIWLh+mv2DFM DrOrrkXLEYW33XbpL1Q== X-Google-Smtp-Source: AGHT+IFSJOITkX9FQ5vyk7lZp7iPUAfNUdn773OnngacDKk9fsVdQ25tPAEr+IEdrY3ZfMZZPLW/+Q0AOqb7g5YT X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6a00:27a5:b0:6de:39ef:7e05 with SMTP id bd37-20020a056a0027a500b006de39ef7e05mr408355pfb.3.1706634141087; Tue, 30 Jan 2024 09:02:21 -0800 (PST) Date: Tue, 30 Jan 2024 17:02:18 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-6-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 05/20] mm: zswap: clean up zswap_entry_put() From: Yosry Ahmed To: Nhat Pham Cc: Johannes Weiner , Andrew Morton , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1117AC0051 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qnsaigofc3g7rtqitp6ifjia9qwat59e X-HE-Tag: 1706634142-12548 X-HE-Meta: U2FsdGVkX19iQonQPm6w1JOLF3mP+HzMb+OUycxciwvOVW3vlWj3uwXnZuCwd0wZNsEDaycZkMnKViuk4CPk1oq9WzwTvwfmMaDqOLs7X9T2IzMOw+/CLUoyJWSYxre2PMdaRU0XQoiqhmR0S/7EI4t+8KEGLvvt5fV9tJI0XZMlgcaIQzhLf9bDLbjWn+kcAGJKQP/mcQrOk0V77QDiq/hF/d2A9Sgjf3lIXx6/rDajNn2u6FEaccNEsQ1pPUysthHyWPRDpVfvX9BaeAhyWmO0bgXu3UParGcVT2RNudsCRd+hPpryV014+G2RskWARm6TP2j1v0/4qgYHgQY49YYS6oquxOnAv1AkXNEaMz5CKEXPQg8I5+xg6qvjDm6baMYVG9WTFIVNKMmXPvQrERevALd3Y4MZnJvvSPAQusiO6aJI2wWOApC2hQbw0XtRmXGh59TGKRfIX/+0WmzfZP5bvJDMmXRZE9swCXeG60Sosvwrc70C8ou+oOlScikQiSmIjWiu+fwQRY0cbg5Cz+zAxDHD+9OzRHmLaVDhLwoJsiJfVfUJDUsff6lil4pDuAfX/YkBYDGPCe/XkG5/tdss6c++WgwjKq5EaocUfxpHDWbXuu2kR7gnSgiX7vQIp7g9OcVQeF82WbTxMrbnbqgCVh0OdlO0mxmNYejB5CpT6BqHTCtuFeNM6RfC4AVBR/Sjx8n3s5+dcOllVxrQS8yqOL40zeMKqwmPDqOPQzsSUGbiNV/QBpEVl1ZuImy4OIZVMSefjMqHVq/pIhMpKvBCbujPrBY4LBFXnXF2iMHLcBP3ap5RuYlwhz7a5lkHi+GO8ZjGADMPagGhSOhjf8qTA3lazwH3sOsCT32Mr4mo36NbSEaLgj1sLBQ/BziTNMdn79aOUMVPgLH8kp3FZ/eot48VD49plwA8ih39cP4IMCOrFD5Clbczyt9p3Pss/MJvRXPbzRuQujLvwW9 ZXeSTvwy OpaimmXLArksrzjS0yXbYxxHWTTzMwN34023WYU3/fOhvWerwA+4eQ3kLBGomZYZAGJOlCHwA+UN2T8UKkL90f12uCZBuYtNABtbclVQN5eiHuKpqQ/8HbwCZDIt2jH07UyDN3MkAZRkqwL0IPE6C8S+mWoxDdvGrPxGRMrTHdsg1j5mLjCOYVadC6pHQj1OBuYxbGgYaqBkaFodBc6XJ9akJ6ToMII8gO0VV2wO9gl+Vmj+bWWFSjoMLLNxWY4CNiL7lEDh9e2bHaNqISoWNU9G53Lk3mz6fERFT+EhO3mxrFEbWE/xa6yGNTRQA7LfB+mS8O7/yu09FgQNOD4pJHW4WuNj5TMyh6fpVdtyPyd+/zTGSrr7I3+F+pBW2EeOfX2qVGEkadIlxlO4KS1t6KyZ8Oit7bTPpcDSPv7JmKCX7QMb4O5QfSuOIlsYyLu+i0vBTwWVZVOuv0sAamayGa4uJ+gbMTX8RuxZoEvajXTQ9vD9HsRBHihiYQi4e16l9gSTL28tDEHxEbJ3bEPjHXRpc1lPYeXNT/Kiobn7IQQdKaUYiCx2n3x8ECcjnPly5PdlwNnOuHXuzVuv3A/z6JpvjCpdjYsBwtiMVQXmXABarGqPZDMn9xKPeBmWPrpVO/cYuLyUg/A5iIm/zwRNbcdmtPO5HgjKAUUatpIpb4taRUWnHGV1stUpQwU0qq+b+dEr5/xTpt1tFOPhoayuPSQM6yvvVC362q0UJPKqLrRLbgwo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000043, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 08:31:22AM -0800, Nhat Pham wrote: > On Mon, Jan 29, 2024 at 11:51=E2=80=AFPM Yosry Ahmed wrote: > > > > On Mon, Jan 29, 2024 at 08:36:41PM -0500, Johannes Weiner wrote: > > > Remove stale comment and unnecessary local variable. > > > > > > Signed-off-by: Johannes Weiner > > > --- > > > mm/zswap.c | 10 +++------- > > > 1 file changed, 3 insertions(+), 7 deletions(-) > > > > > > diff --git a/mm/zswap.c b/mm/zswap.c > > > index 0c6adaf2fdb6..7a7e8da2b4f8 100644 > > > --- a/mm/zswap.c > > > +++ b/mm/zswap.c > > > @@ -546,15 +546,11 @@ static void zswap_entry_get(struct zswap_entry = *entry) > > > entry->refcount++; > > > } > > > > > > -/* caller must hold the tree lock > > > -* remove from the tree and free it, if nobody reference the entry > > > -*/ > > > +/* caller must hold the tree lock */ > > > > We should replace all those "caller must hold the tree lock" comments > > with lockdep_assert_held() or assert_spin_locked() or something. > > > > I can send follow up patches on top if you don't want to resend this > > series. >=20 > Agree. There's also this: >=20 > /* should be called under RCU */ > #ifdef CONFIG_MEMCG > static inline struct mem_cgroup *mem_cgroup_from_entry(struct > zswap_entry *entry) > { > return entry->objcg ? obj_cgroup_memcg(entry->objcg) : NULL; > } >=20 > which you pointed out in the per-cgroup zswap LRU review :) I will send out a patch this week or so.