From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 82EAB7EF0B for ; Tue, 30 Jan 2024 23:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655706; cv=none; b=ezDDYG0Ths9GwTo1nQ8LCprwYmlVPLcNva5nNQGdGjOuaMSp9G0kBhHARq+O7rMzvz9LG6dvdKUUeXl4AuWtI/icPCoL855txhQxq7nxix2HB3csAs16nPeQRQti5yNo944GbFlZIyoH2cmCKKrwZiROS8rsAatsgATq32qK0Do= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706655706; c=relaxed/simple; bh=BhXfGyAPv4SiBtMKJ3yf878gVc2hoptHT3pniLDIM20=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jaM42YV7Gp5YW/ZBW4JbdBS5QGNLBDPC1/UGHiaOuyNqQIrUvgolHZNC+NI6ZiVH0YXCpSuBbGZh3WDTxbBYgrFAdyn89FckTG3PhvXpEf/KhdJTBfkJyojCrloWkxbnPnxGyFUCNixgalRWD+4KldihDRzS9AIdC19C2fvfzbw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=RpRd5lvT; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="RpRd5lvT" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1d8d08f9454so29085ad.1 for ; Tue, 30 Jan 2024 15:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706655704; x=1707260504; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=InqSXSTpbT1eiS6unjbH+Gd3bGvOKOKvltW4HzECThc=; b=RpRd5lvTS00wy3JtmBLu9dGD33xQ6OX28VGFno/GYwlLFxiLuQIkSCk0GMHBNkZVWY VOUBK2wbqtwbt/1DQQAd0h37ksNJRlAW0BXFCENY8yUlLx405/7aIOwP0HwWADBv6ATm +/fb11FDGSXR1tadTGuhoKPHajzkGNjR5rb4UOIg7dlLhZTJXdpDcI8WdL4R1eo5+XbU 0VFyToz6gWr9sP9VZMXVykIKxgcoVbt9rdzpHs2yxSX5aLaXK2Sz8+6RdWO1vXz9TaEI 25HaovjgmSdPOCeddIFnsJHneNDXJMATFcjaSxYzZo4T6v9rbAkyn1ThlH3ebBHI716C /GVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706655704; x=1707260504; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=InqSXSTpbT1eiS6unjbH+Gd3bGvOKOKvltW4HzECThc=; b=UZNhlRZVWPM1rsd8Bs1Ket65HWbGWbmP8Kev/xYbmLqFm1PdfnrBKRzyj/GDDhNCS1 U5xueq33ReaYLd9BInA19UKTEfPAwK2mgArIowJFzaizXQqng7lsHG3C/CPHyNBFAn8h vw4H9YTs+ynFQojAg2qCHhVt+c80K/6o+sd3Dsw/XUvANnHUE2wx2J1/C2h0Xgwhs97t qTlaN79QDp7XHpIflLVvWpJ/L/aVlqJ9Vd/cWBntHxfDx7BoLFr1kWnX6CZrcx492Fza jKPG2LyZKuoKHgNawMpKeU9VDLoWul9H+ax12yZzCe2Uw8PoUR2GP7Vkc5zQC4gqVD7D FJCg== X-Gm-Message-State: AOJu0YwyDG8Q37W73T9ON2riJ11Ah0Knm2MvP55RsKVnh/AbsYcKRe94 z4yET/X2Uq0k291YZ2HjVHXTd+vl8HFH6+y12OH9wAIH+Aogz3ks2rkQe74xQw== X-Google-Smtp-Source: AGHT+IHHlfMmJN3TbbAqe9NgDhqGhzDl2uuy1MggUp8v8ebeUy6kOFXJOYClhwrKxKJuMakJW6TItQ== X-Received: by 2002:a17:902:c943:b0:1d5:78d5:760b with SMTP id i3-20020a170902c94300b001d578d5760bmr389018pla.10.1706655703427; Tue, 30 Jan 2024 15:01:43 -0800 (PST) Received: from google.com (69.8.247.35.bc.googleusercontent.com. [35.247.8.69]) by smtp.gmail.com with ESMTPSA id iz3-20020a170902ef8300b001d8e974ed2fsm3827918plb.284.2024.01.30.15.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 15:01:42 -0800 (PST) Date: Tue, 30 Jan 2024 15:01:39 -0800 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 6/7] arm64: dts: exynos: gs101: define USI12 with I2C configuration Message-ID: References: <20240129174703.1175426-1-andre.draszik@linaro.org> <20240129174703.1175426-7-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-clk@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240129174703.1175426-7-andre.draszik@linaro.org> Hi Andre, On 01/29/2024, André Draszik wrote: > On the gs101-oriole board, i2c bus 12 has various USB-related > controllers attached to it. > > Note the selection of the USI protocol is intentionally left for the > board dts file. > > Signed-off-by: André Draszik > Reviewed-by: Sam Protsenko > > --- > v2: > * reorder pinctrl-0 & pinctrl-names > * collect Reviewed-by: tags > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 30 ++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index e1bcf490309a..9876ecae0ad8 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -451,6 +451,36 @@ pinctrl_peric1: pinctrl@10c40000 { > interrupts = ; > }; > > + usi12: usi@10d500c0 { > + compatible = "google,gs101-usi", > + "samsung,exynos850-usi"; > + reg = <0x10d500c0 0x20>; > + ranges; > + #address-cells = <1>; > + #size-cells = <1>; > + clocks = <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_PCLK_5>, > + <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_IPCLK_5>; > + clock-names = "pclk", "ipclk"; > + samsung,sysreg = <&sysreg_peric1 0x1010>; > + samsung,mode = ; > + status = "disabled"; > + > + hsi2c_12: i2c@10d50000 { > + compatible = "google,gs101-hsi2c", > + "samsung,exynosautov9-hsi2c"; > + reg = <0x10d50000 0xc0>; > + interrupts = ; > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-0 = <&hsi2c12_bus>; > + pinctrl-names = "default"; > + clocks = <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_IPCLK_5>, > + <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_PCLK_5>; > + clock-names = "hsi2c", "hsi2c_pclk"; > + status = "disabled"; > + }; Can you include the i2c aliases for hsi2c_12 and hsi2c_8 (added by Tudor previously)? This will ensure userspace compatibility with the existing Pixel userspace builds. Feel free to do so in a follow-up patch, but I'd prefer the aliases get included in the same kernel release that these devices were added in (v6.9). Thanks, Will > + }; > + > pinctrl_hsi1: pinctrl@11840000 { > compatible = "google,gs101-pinctrl"; > reg = <0x11840000 0x00001000>; > -- > 2.43.0.429.g432eaa2c6b-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A926C46CD2 for ; Tue, 30 Jan 2024 23:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0QdGCWTlTvIC1utDqE+qW6xPfEjnbx+JteXZEYUaTtU=; b=McXA/+gV31p1vZ LdgT11BYPZctPBFMFlcrDubIwcQeldLVHBhSLBxYLDjpP/C0E+9VJqaXqk+da8tVkchSG0WAgs2uQ +zG4SbkYqs+Q4ByGmEAf4wNLdFQMzkqBrfI42IT391BCp2K/eIicElIXHHE0gzv9YxaGhRQlMmd08 9c240tJvvKn3aAGYLDlA0mW5gYP0W+slUkMXqk1JDu7q3riWp9hRIsBxFOR2OKyAq0WSRVAk/fSH9 gPTs3fXcQu5T93Oaquh+lQGDhNvM5MibdGJVCvIFEtRohtiTr8Tkz3hq54e7SV6jbwHylr4Ws98jz sBrIBzkXTGsT+zqEaK/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUx6y-00000000puK-0FZ7; Tue, 30 Jan 2024 23:01:48 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUx6v-00000000prq-2fBa for linux-arm-kernel@lists.infradead.org; Tue, 30 Jan 2024 23:01:46 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1d8d8bb7628so64215ad.0 for ; Tue, 30 Jan 2024 15:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706655704; x=1707260504; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=InqSXSTpbT1eiS6unjbH+Gd3bGvOKOKvltW4HzECThc=; b=FnWFRGuUqxuGqhm4h1GUR5QMKtwUIPxS6SvSXs+oxf5sGU+Jh4ZIjI4O3N7WwNSBoP kMYQQLK/T0virHnEtv6S9hocAFwgQ/Kfsg71y0TuMJP6qlQXMSz9lHxpinTdzSore44A CgvZG6rglvt7qdtgthsZ2mO1V9LCHNBeMabS/MvNFqA+9beGm2J5KaoNsmXErIXIg4lq G/L7SGEAnSYfUgt/3r5VtXDH9fJ+zz3yh/RBC0CYLCKZoGTz17QqSTXNESbnHt85c73B NviHpFqIUaTnozTiNS54vVJzX1gn2xDFGLpsIEercva079gI0ZJfrWwJEsmE3Wc+mh/G fadw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706655704; x=1707260504; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=InqSXSTpbT1eiS6unjbH+Gd3bGvOKOKvltW4HzECThc=; b=I9x0TC297McEUpPNVJrlZQMsf0oAosHI/iJsJ3epUoS492R1SNmva8pkpliTGMxwS/ rQfLdenYiK4XqA2IjJpf9KcMRVBpukMe1GxEn3uKfaFR2uiDsOOg+bJAFegLwh07TVBa hTuoKkce6nauZr/tcogRuLDeVLi+08O7Wd1G2cLWY74+A1WpSpgvlcvAK3VHxv4TZYsJ o/jRC+tGfSbkWdfUTVblpZYws90EK0BwregRNf0xQrylnKX1QpXHzADPvnYowa9u8E/A gamId+0x2mNGslLitO/jiRFhwI0dWojHUFtwLGOPtJgyw5HKVwziSVgq/QbBgCHehQIE VFDA== X-Gm-Message-State: AOJu0YyAcwVZd7YjMpuK2Zay2b9ZrUHusbE1CaixSR66dIGAjYp59fY1 WABCy0oF3NwqAP8iXIqVfsTkYGDrHL5SluVLyoJy9nwa332vvOiBQuiqQKBMCg== X-Google-Smtp-Source: AGHT+IHHlfMmJN3TbbAqe9NgDhqGhzDl2uuy1MggUp8v8ebeUy6kOFXJOYClhwrKxKJuMakJW6TItQ== X-Received: by 2002:a17:902:c943:b0:1d5:78d5:760b with SMTP id i3-20020a170902c94300b001d578d5760bmr389018pla.10.1706655703427; Tue, 30 Jan 2024 15:01:43 -0800 (PST) Received: from google.com (69.8.247.35.bc.googleusercontent.com. [35.247.8.69]) by smtp.gmail.com with ESMTPSA id iz3-20020a170902ef8300b001d8e974ed2fsm3827918plb.284.2024.01.30.15.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 15:01:42 -0800 (PST) Date: Tue, 30 Jan 2024 15:01:39 -0800 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: peter.griffin@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, tudor.ambarus@linaro.org, semen.protsenko@linaro.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 6/7] arm64: dts: exynos: gs101: define USI12 with I2C configuration Message-ID: References: <20240129174703.1175426-1-andre.draszik@linaro.org> <20240129174703.1175426-7-andre.draszik@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240129174703.1175426-7-andre.draszik@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240130_150145_716281_7269E930 X-CRM114-Status: GOOD ( 16.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andre, On 01/29/2024, Andr=E9 Draszik wrote: > On the gs101-oriole board, i2c bus 12 has various USB-related > controllers attached to it. > = > Note the selection of the USI protocol is intentionally left for the > board dts file. > = > Signed-off-by: Andr=E9 Draszik > Reviewed-by: Sam Protsenko > = > --- > v2: > * reorder pinctrl-0 & pinctrl-names > * collect Reviewed-by: tags > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 30 ++++++++++++++++++++ > 1 file changed, 30 insertions(+) > = > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/bo= ot/dts/exynos/google/gs101.dtsi > index e1bcf490309a..9876ecae0ad8 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -451,6 +451,36 @@ pinctrl_peric1: pinctrl@10c40000 { > interrupts =3D ; > }; > = > + usi12: usi@10d500c0 { > + compatible =3D "google,gs101-usi", > + "samsung,exynos850-usi"; > + reg =3D <0x10d500c0 0x20>; > + ranges; > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + clocks =3D <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_PCLK_5>, > + <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_IPCLK_5>; > + clock-names =3D "pclk", "ipclk"; > + samsung,sysreg =3D <&sysreg_peric1 0x1010>; > + samsung,mode =3D ; > + status =3D "disabled"; > + > + hsi2c_12: i2c@10d50000 { > + compatible =3D "google,gs101-hsi2c", > + "samsung,exynosautov9-hsi2c"; > + reg =3D <0x10d50000 0xc0>; > + interrupts =3D ; > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + pinctrl-0 =3D <&hsi2c12_bus>; > + pinctrl-names =3D "default"; > + clocks =3D <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_IPCLK_5>, > + <&cmu_peric1 CLK_GOUT_PERIC1_PERIC1_TOP0_PCLK_5>; > + clock-names =3D "hsi2c", "hsi2c_pclk"; > + status =3D "disabled"; > + }; Can you include the i2c aliases for hsi2c_12 and hsi2c_8 (added by Tudor previously)? This will ensure userspace compatibility with the existing Pix= el userspace builds. Feel free to do so in a follow-up patch, but I'd prefer the aliases get included in the same kernel release that these devices were added in (v6.9). Thanks, Will > + }; > + > pinctrl_hsi1: pinctrl@11840000 { > compatible =3D "google,gs101-pinctrl"; > reg =3D <0x11840000 0x00001000>; > -- = > 2.43.0.429.g432eaa2c6b-goog > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel