From: Dave Chinner <david@fromorbit.com>
To: Joe Damato <jdamato@fastly.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
chuck.lever@oracle.com, jlayton@kernel.org,
linux-api@vger.kernel.org, brauner@kernel.org,
edumazet@google.com, davem@davemloft.net,
alexander.duyck@gmail.com, sridhar.samudrala@intel.com,
kuba@kernel.org, willemdebruijn.kernel@gmail.com,
weiwan@google.com, David.Laight@aculab.com, arnd@arndb.de,
Jonathan Corbet <corbet@lwn.net>,
Alexander Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Lynch <nathanl@linux.ibm.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Maik Broemme <mbroemme@libmpq.org>,
Steve French <stfrench@microsoft.com>,
Julien Panis <jpanis@baylibre.com>,
Jiri Slaby <jirislaby@kernel.org>, Thomas Huth <thuth@redhat.com>,
Andrew Waterman <waterman@eecs.berkeley.edu>,
Albert Ou <aou@eecs.berkeley.edu>,
Palmer Dabbelt <palmer@dabbelt.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params
Date: Wed, 31 Jan 2024 13:57:05 +1100 [thread overview]
Message-ID: <Zbm3AXgcwL9D6TNM@dread.disaster.area> (raw)
In-Reply-To: <20240131022756.GA4837@fastly.com>
On Tue, Jan 30, 2024 at 06:27:57PM -0800, Joe Damato wrote:
> On Tue, Jan 30, 2024 at 06:08:36PM -0800, Greg Kroah-Hartman wrote:
> > On Wed, Jan 31, 2024 at 01:47:33AM +0000, Joe Damato wrote:
> > > +struct epoll_params {
> > > + __aligned_u64 busy_poll_usecs;
> > > + __u16 busy_poll_budget;
> > > +
> > > + /* pad the struct to a multiple of 64bits for alignment on all arches */
> > > + __u8 __pad[6];
> >
> > You HAVE to check this padding to be sure it is all 0, otherwise it can
> > never be used in the future for anything.
>
> Is there some preferred mechanism for this in the kernel that I should be
> using or is this as simple as adding a for loop to check each u8 == 0 ?
memchr_inv()
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2024-01-31 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 1:47 [PATCH net-next v4 0/3] Per epoll context busy poll support Joe Damato
2024-01-31 1:47 ` [PATCH net-next v4 1/3] eventpoll: support busy poll per epoll instance Joe Damato
2024-01-31 1:47 ` [PATCH net-next v4 2/3] eventpoll: Add per-epoll busy poll packet budget Joe Damato
2024-01-31 1:47 ` [PATCH net-next v4 3/3] eventpoll: Add epoll ioctl for epoll_params Joe Damato
2024-01-31 2:08 ` Greg Kroah-Hartman
2024-01-31 2:27 ` Joe Damato
2024-01-31 2:31 ` Greg Kroah-Hartman
2024-01-31 2:57 ` Dave Chinner [this message]
2024-01-31 6:03 ` Jiri Slaby
2024-01-31 16:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zbm3AXgcwL9D6TNM@dread.disaster.area \
--to=david@fromorbit.com \
--cc=David.Laight@aculab.com \
--cc=alexander.duyck@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jack@suse.cz \
--cc=jdamato@fastly.com \
--cc=jirislaby@kernel.org \
--cc=jlayton@kernel.org \
--cc=jpanis@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroemme@libmpq.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=sridhar.samudrala@intel.com \
--cc=stfrench@microsoft.com \
--cc=thuth@redhat.com \
--cc=tzimmermann@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=waterman@eecs.berkeley.edu \
--cc=weiwan@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.