From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4B2EC47DDB for ; Wed, 31 Jan 2024 03:02:58 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6F34C875A0; Wed, 31 Jan 2024 04:02:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 08864875E9; Wed, 31 Jan 2024 04:02:57 +0100 (CET) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08BE287579 for ; Wed, 31 Jan 2024 04:02:53 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 40V32bVt013305; Wed, 31 Jan 2024 11:02:37 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from swlinux02 (10.0.15.183) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Jan 2024 11:02:36 +0800 Date: Wed, 31 Jan 2024 11:02:33 +0800 From: Leo Liang To: Aurelien Jarno CC: Yanhong Wang , Tom Rini , Shengyu Qu , Chanho Park , Minda Chen , "Simon Glass" , open list , E Shattow Subject: Re: [PATCH] configs: visionfive2: Disable ENV_IS_NOWHERE Message-ID: References: <20240127134850.582763-1-aurelien@aurel32.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20240127134850.582763-1-aurelien@aurel32.net> User-Agent: Mutt/2.2.10 (e0e92c31) (2023-03-25) X-Originating-IP: [10.0.15.183] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 40V32bVt013305 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sat, Jan 27, 2024 at 02:48:45PM +0100, Aurelien Jarno wrote: > The VisionFive 2 board supports saving the u-boot environment settings > are saved to on-board SPI flash. However the defconfig enables both > ENV_IS_NOWHERE and ENV_IS_IN_SPI_FLASH, preventing the "saveenv" command > to work. Fix that by disabling ENV_IS_NOWHERE. > > Fixes: 7d79bed00c9e ("configs: starfive: Enable environment in SPI flash support") > > Reported-by: E Shattow > Signed-off-by: Aurelien Jarno > --- > configs/starfive_visionfive2_defconfig | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Leo Yu-Chi Liang