Re: [PATCH V2] rust: str: implement `Display` and `Debug` for `BStr`

[Yutaro Ohno <yutaro.ono.418@gmail.com>]

Thank you both for the comments!

On 01/29, Miguel Ojeda wrote:
> On Mon, Jan 29, 2024 at 1:19 PM Alice Ryhl <aliceryhl@google.com> wrote:
> >
> > What about newlines and tabs? Those are printable.
> >
> > If you are intentionally excluding them, please add a comment saying that.
> 
> +1 and, either way, it would also nice a test for those too.

> > This escapes quotes, but what about backslashes?
> 
> Ditto.

Newlines and tabs are omitted here because this patch doesn't intend to
change the current behavior of CStr's Display/Debug in this patch,
aligning with the feedback provided in V1.

So, how about removing the changes to CStr's Display/Debug from my
patch, and adding '\t' and '\n' as printable characters to BStr's
Display/Debug? (Backslashes for Debug as well.)

I'm considering whether it would be preferable for BStr's Display and
Debug to have distinct behavior from CStr's.

On Mon, Jan 29, 2024 at 1:19 PM Alice Ryhl <aliceryhl@google.com> wrote:
> Also, perhaps `write_char('"')` makes more sense than `write_str("\"")`?

I agree. Will change in V3.

On 01/29, Alice Ryhl wrote:
> >  macro_rules! b_str {
> >      ($str:literal) => {{
> >          const S: &'static str = $str;
> > -        const C: &'static $crate::str::BStr = S.as_bytes();
> > +        const C: &'static $crate::str::BStr = BStr::from_bytes(S.as_bytes());
> >          C
> >      }};
> >  }
> 
> This should use the full path both times:
> 
> const C: &'static $crate::str::BStr = $crate::str::BStr::from_bytes(S.as_bytes());

Thanks. I'll also change this.


Best regards,
Yutaro Ohno