From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69F0CC47258 for ; Wed, 31 Jan 2024 06:31:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9859B878CB; Wed, 31 Jan 2024 07:31:05 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4CE608798B; Wed, 31 Jan 2024 07:31:04 +0100 (CET) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9DB2D87887 for ; Wed, 31 Jan 2024 07:31:01 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=quarantine dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=randolph@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 40V6Unkw056020; Wed, 31 Jan 2024 14:30:49 +0800 (+08) (envelope-from randolph@andestech.com) Received: from atctrx (10.0.15.173) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Wed, 31 Jan 2024 14:30:48 +0800 Date: Wed, 31 Jan 2024 14:30:41 +0800 From: Randolph Lin To: Stefan Roese CC: , , CL Wang , Leo Yu-Chi Liang Subject: Re: [PATCH V4 2/2] configs: andes: add watchdog support fot andes ae350 Message-ID: References: <20240124062133.439469-1-randolph@andestech.com> <20240124062133.439469-2-randolph@andestech.com> <5a7375c1-1b3d-4085-847e-1be68b049423@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5a7375c1-1b3d-4085-847e-1be68b049423@denx.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Originating-IP: [10.0.15.173] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 40V6Unkw056020 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Wed, Jan 24, 2024 at 09:37:41AM +0100, Stefan Roese wrote: Hi Stefan, Thank you for testing and reviewing. I have checked the error message and the relationship to my patch. The reason for the failure has nothing to do with my patch. Could you kindly help me run the CI test again? Randolph Sincerely > Hi Randolph, > > On 1/24/24 07:21, Randolph wrote: > > It adds the ATCWDT200 support for Andes AE350 platform. > > It also enables wdt command support. > > > > Signed-off-by: CL Wang > > Signed-off-by: Randolph > > Reviewed-by: Leo Yu-Chi Liang > > This fails in world CI build in "test.py for sandbox": > > https://dev.azure.com/sr0718/0cded7c3-6e6a-4b57-8d0f-65c99496c42f/_apis/build/builds/338/logs/181 > > Not sure how this is related. Could you please take a look? > > Thanks, > Stefan > > > --- > > configs/ae350_rv32_defconfig | 4 ++++ > > configs/ae350_rv32_spl_defconfig | 4 ++++ > > configs/ae350_rv32_spl_xip_defconfig | 4 ++++ > > configs/ae350_rv32_xip_defconfig | 4 ++++ > > configs/ae350_rv64_defconfig | 4 ++++ > > configs/ae350_rv64_spl_defconfig | 4 ++++ > > configs/ae350_rv64_spl_xip_defconfig | 4 ++++ > > configs/ae350_rv64_xip_defconfig | 4 ++++ > > 8 files changed, 32 insertions(+) > > > > diff --git a/configs/ae350_rv32_defconfig b/configs/ae350_rv32_defconfig > > index 3bfa3e9f8e..35ad62c845 100644 > > --- a/configs/ae350_rv32_defconfig > > +++ b/configs/ae350_rv32_defconfig > > @@ -23,6 +23,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -49,3 +50,6 @@ CONFIG_BAUDRATE=38400 > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv32_spl_defconfig b/configs/ae350_rv32_spl_defconfig > > index aeb50206d2..41cd457bc3 100644 > > --- a/configs/ae350_rv32_spl_defconfig > > +++ b/configs/ae350_rv32_spl_defconfig > > @@ -33,6 +33,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -58,3 +59,6 @@ CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > # CONFIG_BINMAN_FDT is not set > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv32_spl_xip_defconfig b/configs/ae350_rv32_spl_xip_defconfig > > index f15ec301ce..954e2f2de7 100644 > > --- a/configs/ae350_rv32_spl_xip_defconfig > > +++ b/configs/ae350_rv32_spl_xip_defconfig > > @@ -34,6 +34,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -59,3 +60,6 @@ CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > # CONFIG_BINMAN_FDT is not set > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv32_xip_defconfig b/configs/ae350_rv32_xip_defconfig > > index c40eb043c5..95863595d2 100644 > > --- a/configs/ae350_rv32_xip_defconfig > > +++ b/configs/ae350_rv32_xip_defconfig > > @@ -24,6 +24,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -50,3 +51,6 @@ CONFIG_BAUDRATE=38400 > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv64_defconfig b/configs/ae350_rv64_defconfig > > index 7ae938aeb2..988214285a 100644 > > --- a/configs/ae350_rv64_defconfig > > +++ b/configs/ae350_rv64_defconfig > > @@ -23,6 +23,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -49,3 +50,6 @@ CONFIG_BAUDRATE=38400 > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv64_spl_defconfig b/configs/ae350_rv64_spl_defconfig > > index 68ac4325ab..e929320433 100644 > > --- a/configs/ae350_rv64_spl_defconfig > > +++ b/configs/ae350_rv64_spl_defconfig > > @@ -33,6 +33,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -58,3 +59,6 @@ CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > # CONFIG_BINMAN_FDT is not set > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv64_spl_xip_defconfig b/configs/ae350_rv64_spl_xip_defconfig > > index 839ca335d4..3f92643b07 100644 > > --- a/configs/ae350_rv64_spl_xip_defconfig > > +++ b/configs/ae350_rv64_spl_xip_defconfig > > @@ -34,6 +34,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -59,3 +60,6 @@ CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > # CONFIG_BINMAN_FDT is not set > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > diff --git a/configs/ae350_rv64_xip_defconfig b/configs/ae350_rv64_xip_defconfig > > index 5432b6d6d7..835f020990 100644 > > --- a/configs/ae350_rv64_xip_defconfig > > +++ b/configs/ae350_rv64_xip_defconfig > > @@ -24,6 +24,7 @@ CONFIG_SYS_PROMPT="RISC-V # " > > CONFIG_CMD_IMLS=y > > CONFIG_CMD_MMC=y > > CONFIG_CMD_SF_TEST=y > > +CONFIG_CMD_WDT=y > > # CONFIG_CMD_SETEXPR is not set > > CONFIG_BOOTP_PREFER_SERVERIP=y > > CONFIG_CMD_CACHE=y > > @@ -50,3 +51,6 @@ CONFIG_BAUDRATE=38400 > > CONFIG_SYS_NS16550=y > > CONFIG_SPI=y > > CONFIG_ATCSPI200_SPI=y > > +# CONFIG_WATCHDOG_AUTOSTART is not set > > +CONFIG_WDT=y > > +CONFIG_WDT_ATCWDT200=y > > Viele Grüße, > Stefan Roese > > -- > DENX Software Engineering GmbH, Managing Director: Erika Unter > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de