From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C140C47258 for ; Wed, 31 Jan 2024 08:55:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 148F64097A; Wed, 31 Jan 2024 08:55:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 148F64097A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1706691327; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=q/apN5SNOmSmUP3VbnTRbtAniL29iBIDrXypIpKwkQHDiYzRWqObRJWQdPGaZN1MM EaBYsctQLB+Odu90LKtW7cRSCoH3TZIPnu6vitZu4esJbVW1uGOXOD/2pf1Z4G0SOl YaWodk4Tz23pt4HhYAdo9Wn80psjXP1sQK3HEAwZ4jkAH2LtCY8/PADolm0IbtbHef o5/hVzhHone9akPKDXHL0eoNQ+bzMvUoHqYaSXsRIuGj45YRmckVUbMH+ku7tETxzw yY5DaFGrxnLzC8v0dizBa3mDbD9pI0QMqJBtNeeg1gWy1FHDgBTWwSmWyS1Hixbzq0 W7a/meN922lMA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qClWEp4mueWz; Wed, 31 Jan 2024 08:55:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 55DE4409C2; Wed, 31 Jan 2024 08:55:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 55DE4409C2 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 21B241BF846 for ; Wed, 31 Jan 2024 08:55:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E86C2409C2 for ; Wed, 31 Jan 2024 08:55:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E86C2409C2 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DhG77_tDHp6j for ; Wed, 31 Jan 2024 08:55:23 +0000 (UTC) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by smtp4.osuosl.org (Postfix) with ESMTPS id 60C2D4097A for ; Wed, 31 Jan 2024 08:55:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 60C2D4097A Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-33b0763bbc5so80984f8f.0 for ; Wed, 31 Jan 2024 00:55:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706691321; x=1707296121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; b=DMLe9AZtD4VqGm2whcBmAea2o5uF/RqreX61u34Tt/4zn6XFUymcxyQWahfSo+m4pJ AyKbSyUtZU6oZ+xmJvvYIRgHKPa1aD2ebRLfw+0KqyqX/N8gQvA+hZKRycd+XItNDhtf C3JYOIYfi50V8r9VrCUUZHmFBDkvlTT7WneaZsmfXfJ3DB1DL43riqff9OxLMlvherRB hjI7fkdITlwaAnRxmxp0FY9D8T8Cdfqu/s2tntuVu4d3uOgI+D8sgf7jUSB1yWA2sbd8 2UaYzYnCg3x13V3Unk3QMpanTRKAyQ2kj+B5J3FDu+GPzJuyRSZTvlnzIuO4u2rdqmY+ hTpw== X-Gm-Message-State: AOJu0YznqElcR/pa7MJRhbatddKFKJpdLa+SjsMwhqpZkppv79ryok8k bQB7dvqMOdOgLwC9/ctFk2wVa19jxFZLn3umgCzUrTuTB2v9v0CBP8EaPoxlY7M= X-Google-Smtp-Source: AGHT+IEDaB/xrJB9e/nbcOYh/jzhcipifSUQvbsXwmciEyC3bvRWprUeAzSWNd6QobawgPm3fQCCjQ== X-Received: by 2002:adf:ffc8:0:b0:33b:290:253 with SMTP id x8-20020adfffc8000000b0033b02900253mr711420wrs.59.1706691321011; Wed, 31 Jan 2024 00:55:21 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVijmjMIBMPrVUDqpjOW8DpKrsuG/p+eiyjvljc+dEmxB6q2VcNXli1GoNTXWTgsQuSMqmzskCR7aGyn4nRAwYXYG/UmYNOWWOF1uwNI61zppf43lGmYYizGcUNUFCZZQNUGCpi7w4ZtgCB0WBCIqRnfLxpSC7406NOM6iHs7q8O8FAcRbp9PGzvBG0YR8wPtWvmVSfJPd2E13lM01BVx/i0geEPVTkXUA85quOLBts/lbIapx0m+Jo+E9NT+8V7zgl1CDqyXsAmJTXcg8qrf6IjK7V6+Bm05MpE4tIP18QxWOvc6hJnHXPaG/FBv9hHppA6A2RVm0KvkfqxOQuL2hN0bjIcYdO2SCRlhD74ep7iaQ/4VlTQOZdnqM7BYSCfXvf0IC11iSL8TmQkogGy7tRWyt308LRGyblF0Yop5iZy4AyE/JLjXz8YbuWg/lkm1NH80kP Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ay12-20020a5d6f0c000000b0033ad47d7b86sm12915043wrb.27.2024.01.31.00.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 00:55:20 -0800 (PST) Date: Wed, 31 Jan 2024 09:55:17 +0100 From: Jiri Pirko To: karthiksundaravel Message-ID: References: <20240131080847.30614-1-ksundara@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131080847.30614-1-ksundara@redhat.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706691321; x=1707296121; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; b=STssBScGRBNjnUbjXBbyvkemg5TvNBjhLa3gNqkPtWgSff1U0PTaMIhlUMuek5Kp2h 6uMAyi/HP6/ZNH3UKPbG69RFBLSJj3QHxqQ7Kn3vAACP0QWXg9GAoxKXDduYIAamDJeE wC749IbZdLmXdTvOHKMp+CzAArJwPo0cKlgLTRr3rsQ1w0mHssxzxGqzvtVAy2TgcxA+ CjklvpiDptuCS+BT192uh+o79EDBdwozZhpmTc1lboWJqwGHeYmk/MuSd8VEfV0W6YWV pzDuY76UCULgG6rT/VTxLB5ucKebPWSSbIlWflUXyiTLDF92PPabzZIR+dJFNTef1n06 QjNw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=STssBScG Subject: Re: [Intel-wired-lan] [PATCH] ice: Add get/set hw address for VF representor ports X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: vchundur@redhat.com, aharivel@redhat.com, cfontain@redhat.com, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com, linux-kernel@vger.kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com, netdev@vger.kernel.org, kuba@kernel.org, rjarry@redhat.com, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Wed, Jan 31, 2024 at 09:08:47AM CET, ksundara@redhat.com wrote: >Changing the mac address of the VF representor ports are not >available via devlink. Add the function handlers to set and get >the HW address for the VF representor ports. Wait a sec. The API is there to change the mac of the actual VF. Not the representor. Apparently your patch is not doing that, changing mac of the representor. NAK. Fix this to change the VF mac address or drop the patch entirely. Thanks! pw-bot: cr From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D294D66B5F for ; Wed, 31 Jan 2024 08:55:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706691324; cv=none; b=bnHemfV2mBv58Wi3yEbY2fRsd6o4eWgSxbkIPNv1oeAPBAYpxbxxOmziZaLoMcbPHu0j0IWFuunrOhQ1Fx2foJqoaz/zCFpfRGr4bYvFpkWXvF3eRzf1UJJ00ilSOujn434K28YnKL5+NTyRjWlD+89hqKgCmJGV5ZRdYlLcIFA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706691324; c=relaxed/simple; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ddQ0/Gn/Hr/4WrutzFOsXJ5jbnJMlYv1Zw69tQxH0rSmcd4mjxlX//XN9N74zPwNpIMCnXESbpEdYggc7ow3afx3vOkGR6ukHSIIpLg93CHJkovEug+ZjS2BZZkxQZAkiiWp9PgTpNcNxUFiJ8vA77CKAEhKzX01xA2P2OckXP4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b=Fg9tabzF; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20230601.gappssmtp.com header.i=@resnulli-us.20230601.gappssmtp.com header.b="Fg9tabzF" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-33ae51f8111so2505249f8f.2 for ; Wed, 31 Jan 2024 00:55:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20230601.gappssmtp.com; s=20230601; t=1706691321; x=1707296121; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; b=Fg9tabzFtad5EwKggaEcDrs2/ZmYJgVp0eQLjYfftJD/GGN9DqbBjrSzWpf9P0vuel 2H2p4iUBl+z7ZcoiyXgY7tKPHl2wEELXSPz9QHhIR1yFzwOJddRcaFbdrH4IaUAA+x3e 71xBT/WyuXGZEfWjbJmE9Bb/PyQjzA6cq1Gl9D7u7xn3+g3OkDk21bE7j4UCzXisM7z0 1d9Qr5ohvYSOSrALiOIFqu2OzFRpVRkz7mLfMphGo0aZO4bQCgOfazaHSFShW0yx4+Sl 9M33WfiHHlZGjo2YfomsK2Tb7PZfGfCmkk7jAM0hhMnao5/V5+4C0vYQGdYf6ursuSWA uNcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706691321; x=1707296121; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1zAz2+MFVhaNzjF0CUHFlp2iK4QKE8zWsjZLLf44jk4=; b=vR7ofJvm3PsSZypaSHwl6xdxI3gVNjFpY9tZp/kPMFn1LXl31EbIDR4sOiYDlh7Yyn OsrDcyyw/FT4Me4y9oiwFZYFz8Q0wAwMwpA/b5AZ9kxGSUQkWKQWGJpaXY66nQ2mxhcE xDNYm+Z/eZjkHqRR8596sfC3S6llUs85XyPmXmsgyboKPa5z8dY9/Q+dL9Upk+Mbz+Qq t2YFLFARME/P+cEhRZn3m+uY6QMFVjji8l3N+yrrnF5pe+xaD7tePcscfzCjgG63PGLB o39kz4IJcQgrqsbUREECyJuIGm0Sybtlhn7PjwG+RkCZ7iYaQmApvYhO+Fu9LOVtOdKQ 4kjQ== X-Gm-Message-State: AOJu0YyWWbfE02/Iql9l5QULnm9sWkwHJbRoKUuhX28SIIZX+fYNBWz/ 0cxjC9GO4ijyGfd7YcrzPp7t2rSNm+0O2F7mOqEC3t5FaJW4/ZXUixsodE/2VapP8fo6HmkNAo9 lOuAqaQ== X-Google-Smtp-Source: AGHT+IEDaB/xrJB9e/nbcOYh/jzhcipifSUQvbsXwmciEyC3bvRWprUeAzSWNd6QobawgPm3fQCCjQ== X-Received: by 2002:adf:ffc8:0:b0:33b:290:253 with SMTP id x8-20020adfffc8000000b0033b02900253mr711420wrs.59.1706691321011; Wed, 31 Jan 2024 00:55:21 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVijmjMIBMPrVUDqpjOW8DpKrsuG/p+eiyjvljc+dEmxB6q2VcNXli1GoNTXWTgsQuSMqmzskCR7aGyn4nRAwYXYG/UmYNOWWOF1uwNI61zppf43lGmYYizGcUNUFCZZQNUGCpi7w4ZtgCB0WBCIqRnfLxpSC7406NOM6iHs7q8O8FAcRbp9PGzvBG0YR8wPtWvmVSfJPd2E13lM01BVx/i0geEPVTkXUA85quOLBts/lbIapx0m+Jo+E9NT+8V7zgl1CDqyXsAmJTXcg8qrf6IjK7V6+Bm05MpE4tIP18QxWOvc6hJnHXPaG/FBv9hHppA6A2RVm0KvkfqxOQuL2hN0bjIcYdO2SCRlhD74ep7iaQ/4VlTQOZdnqM7BYSCfXvf0IC11iSL8TmQkogGy7tRWyt308LRGyblF0Yop5iZy4AyE/JLjXz8YbuWg/lkm1NH80kP Received: from localhost ([193.47.165.251]) by smtp.gmail.com with ESMTPSA id ay12-20020a5d6f0c000000b0033ad47d7b86sm12915043wrb.27.2024.01.31.00.55.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 00:55:20 -0800 (PST) Date: Wed, 31 Jan 2024 09:55:17 +0100 From: Jiri Pirko To: karthiksundaravel Cc: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rjarry@redhat.com, aharivel@redhat.com, vchundur@redhat.com, cfontain@redhat.com Subject: Re: [PATCH] ice: Add get/set hw address for VF representor ports Message-ID: References: <20240131080847.30614-1-ksundara@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240131080847.30614-1-ksundara@redhat.com> Wed, Jan 31, 2024 at 09:08:47AM CET, ksundara@redhat.com wrote: >Changing the mac address of the VF representor ports are not >available via devlink. Add the function handlers to set and get >the HW address for the VF representor ports. Wait a sec. The API is there to change the mac of the actual VF. Not the representor. Apparently your patch is not doing that, changing mac of the representor. NAK. Fix this to change the VF mac address or drop the patch entirely. Thanks! pw-bot: cr