From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Hao Xiang <hao.xiang@bytedance.com>,
Yuan Liu <yuan1.liu@intel.com>,
Bryan Zhang <bryan.zhang@bytedance.com>,
Avihai Horon <avihaih@nvidia.com>
Subject: Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression
Date: Thu, 1 Feb 2024 11:25:00 +0800 [thread overview]
Message-ID: <ZbsPDMePqeWPyyTy@x1n> (raw)
In-Reply-To: <875xz9lk4t.fsf@suse.de>
On Wed, Jan 31, 2024 at 10:14:58AM -0300, Fabiano Rosas wrote:
> > I am thinking the p->normal is mostly redundant.. at least on the sender
> > side that I just read. Since I'll be preparing a new spin of the multifd
> > cleanup series I posted, maybe I can append one more to try dropping
> > p->normal[] completely.
>
> Just for reference, you don't have to use it, but I have this patch:
>
> https://gitlab.com/farosas/qemu/-/commit/4316e145ae7e7bf378ef7fde64c2b02260362847
Oops, I missed that even though I did have a glance over your branch (only
the final look, though), or I could have picked it up indeed, sorry. But
it's also good news then it means it's probably the right thing to do.
--
Peter Xu
next prev parent reply other threads:[~2024-02-01 3:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 22:19 [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work Fabiano Rosas
2024-01-26 22:19 ` [PATCH 1/5] migration/multifd: Separate compression ops from non-compression Fabiano Rosas
2024-01-29 6:29 ` Peter Xu
2024-01-29 12:42 ` Fabiano Rosas
2024-01-30 8:42 ` Peter Xu
2024-01-30 15:11 ` Fabiano Rosas
2024-01-31 7:24 ` Peter Xu
2024-01-31 13:14 ` Fabiano Rosas
2024-02-01 3:25 ` Peter Xu [this message]
2024-01-26 22:19 ` [PATCH 2/5] migration/multifd: Move multifd_socket_ops to socket.c Fabiano Rosas
2024-01-26 22:19 ` [PATCH 3/5] migration/multifd: Add multifd_ops->send Fabiano Rosas
2024-01-26 22:19 ` [PATCH 4/5] migration/multifd: Simplify zero copy send Fabiano Rosas
2024-01-26 22:19 ` [PATCH 5/5] migration/multifd: Move zero copy flag into multifd_socket_setup Fabiano Rosas
2024-01-29 1:41 ` [PATCH 0/5] migration/multifd: Prerequisite cleanups for ongoing work Liu, Yuan1
2024-01-29 7:36 ` Peter Xu
2024-01-29 12:51 ` Fabiano Rosas
2024-01-31 9:29 ` Peter Xu
2024-01-31 13:19 ` Fabiano Rosas
2024-02-01 1:11 ` [External] " Hao Xiang
2024-02-01 13:23 ` Fabiano Rosas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbsPDMePqeWPyyTy@x1n \
--to=peterx@redhat.com \
--cc=avihaih@nvidia.com \
--cc=bryan.zhang@bytedance.com \
--cc=farosas@suse.de \
--cc=hao.xiang@bytedance.com \
--cc=qemu-devel@nongnu.org \
--cc=yuan1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.