From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8DEDA15CD52; Thu, 1 Feb 2024 11:24:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706786657; cv=none; b=jzltFvIyEjrfPg7wZ1UvX/060Rrfox0IuC/ntZ07/Af1nuis4lYRKzzY77dZ82Yb/wwVDMxqshk8bHML1iA3LDErVwL7skpTumgmNwMRsUpHn54Ddrdyzxv3hsIh56CofX7EFwDD+okx0MDwXxsLmosWmThJHYpsS9Qb7ty643s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706786657; c=relaxed/simple; bh=uZUoJTXUOtGTmSyrM1RM4G9rWHINL+HQGMIgwpk5Gdk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=B+CwVJY5XUuG/bHGjcvtw7LceCq7zqI6dgi30ALwO8xt43Xjm+ed68fmHGjuNHe/V1LyZUtJYnnAypK7FVI1cyYywUYKJPxobMG9ZMLNjeQINGooqb15RIX4h/TvgZIQHt0XVzsDLDiU3wUUb1h2bX2Uag1XLETY3RRJmyT2nUw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9273FDA7; Thu, 1 Feb 2024 03:24:56 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0C5F3F762; Thu, 1 Feb 2024 03:19:41 -0800 (PST) Date: Thu, 1 Feb 2024 11:19:30 +0000 From: Cristian Marussi To: Peng Fan Cc: Linus Walleij , "Peng Fan (OSS)" , "souvik.chakravarty@arm.com" , Sudeep Holla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , AKASHI Takahiro , Rob Herring Subject: Re: [PATCH v3 0/6] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: References: <20240121-pinctrl-scmi-v3-0-8d94ba79dca8@nxp.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 01, 2024 at 07:14:17AM +0000, Peng Fan wrote: > > Subject: Re: [PATCH v3 0/6] firmware: arm_scmi: Add SCMI v3.2 pincontrol > > protocol basic support > > Hi Peng, > > On Mon, Jan 29, 2024 at 1:37 PM Peng Fan wrote: > > > > > And for i.MX95 OEM extenstion, do you have any suggestions? > > > I have two points: > > > 1. use vendor compatible. This would also benefit when supporting > > > vendor protocol. > > > 2. Introduce a property saying supporting-generic-pinconf > > > > > > How do you think? > > > > While I don't know how OEM extensions to SCMI were designed, the pin > > control subsystem has the philosophy that extensions are for minor fringe > > stuff, such as a pin config option that no other silicon is using and thus have > > no use for anyone else. Well that is actually all the custom extensions we > > have. > > (This notion is even carried over to SCMI pinctrl.) > > > > The i.MX95 OEM extension is really odd to me, it looks like a > > reimplementation of the core aspects of SCMI pin control, and looks much > > more like the old i.MX drivers than like the SCMI driver. > > i.MX SCMI pin protocol conf settings follows non-SCMI pin conf settings. > It is not just a matter of using custom SCMI OEM types, it is the whole layout/definitions of the i.MX pin/groups/funcs DT bindings that deviates from the generic DT bindings layout as handled and expected by the Linux Pinctrl subsystem (AFAIU), while the SCMI Pinctrl driver as it stands in this series, was conceived, designed and implemented originally by Oleksii to just use the generic existing Pinctrl DT bindings; as a consequence, in your i.MX extensions, you had to add a dedicated i.MX DT parser to interpret the protocol@19 DT snippet in a completely different way, to try to stick your custom solution on top of the generic one. Thanks, Cristian > > > > But I sure cannot speak of what is allowed in SCMI OEM extensions or not. > > + SPEC owner, Souvik. Any comments? > > Thanks, > Peng. > > > > > Yours, > > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B4DBC47DDF for ; Thu, 1 Feb 2024 11:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0dXq3AJam/E32zxw4GH/byn8N+taoVYGikZyBt498LM=; b=4RuIxl0Mi+48Tv XAJ5j+AKb4bqgo3KEqpxLNVRBCAGMtmg45rXXTbGStZqjA2bMKW2WZLNla8wHONRLcgEVkCnmBa52 SSVn4n0YssDR7sx/Aj0rjsKEgMyw2D9wVfJjWcJo+NRdDijB/7r8IOBhKOQQEYXgACCifsTfzEO/n PZoPqNrKh2bwg3Y4xvhXOwfRdWL7yx0kT02aARrksUZtzCbo3Cnq1IC0rzcLnPLAjztvv6UZ0UAMM Zii7B+vm17/f+HAdTP/RNzGgQEOui77b7xtoCSBbalHBRAgZTTuLFP7It1NmY1GP/VVLa7v9srDiY Stsd+FEEB3eQYb9lWYMw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVVB7-00000007ZXz-1b4U; Thu, 01 Feb 2024 11:24:21 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVVB3-00000007ZXJ-3bme for linux-arm-kernel@lists.infradead.org; Thu, 01 Feb 2024 11:24:19 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9273FDA7; Thu, 1 Feb 2024 03:24:56 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0C5F3F762; Thu, 1 Feb 2024 03:19:41 -0800 (PST) Date: Thu, 1 Feb 2024 11:19:30 +0000 From: Cristian Marussi To: Peng Fan Cc: Linus Walleij , "Peng Fan (OSS)" , "souvik.chakravarty@arm.com" , Sudeep Holla , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksii Moisieiev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , AKASHI Takahiro , Rob Herring Subject: Re: [PATCH v3 0/6] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support Message-ID: References: <20240121-pinctrl-scmi-v3-0-8d94ba79dca8@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240201_032418_018006_CD73B14F X-CRM114-Status: GOOD ( 26.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBGZWIgMDEsIDIwMjQgYXQgMDc6MTQ6MTdBTSArMDAwMCwgUGVuZyBGYW4gd3JvdGU6 Cj4gPiBTdWJqZWN0OiBSZTogW1BBVENIIHYzIDAvNl0gZmlybXdhcmU6IGFybV9zY21pOiBBZGQg U0NNSSB2My4yIHBpbmNvbnRyb2wKPiA+IHByb3RvY29sIGJhc2ljIHN1cHBvcnQKPiA+IAoKSGkg UGVuZywKCj4gPiBPbiBNb24sIEphbiAyOSwgMjAyNCBhdCAxOjM34oCvUE0gUGVuZyBGYW4gPHBl bmcuZmFuQG9zcy5ueHAuY29tPiB3cm90ZToKPiA+IAo+ID4gPiBBbmQgZm9yIGkuTVg5NSBPRU0g ZXh0ZW5zdGlvbiwgZG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zPwo+ID4gPiBJIGhhdmUgdHdv IHBvaW50czoKPiA+ID4gMS4gdXNlIHZlbmRvciBjb21wYXRpYmxlLiBUaGlzIHdvdWxkIGFsc28g YmVuZWZpdCB3aGVuIHN1cHBvcnRpbmcKPiA+ID4gdmVuZG9yIHByb3RvY29sLgo+ID4gPiAyLiBJ bnRyb2R1Y2UgYSBwcm9wZXJ0eSBzYXlpbmcgc3VwcG9ydGluZy1nZW5lcmljLXBpbmNvbmYKPiA+ ID4KPiA+ID4gSG93IGRvIHlvdSB0aGluaz8KPiA+IAo+ID4gV2hpbGUgSSBkb24ndCBrbm93IGhv dyBPRU0gZXh0ZW5zaW9ucyB0byBTQ01JIHdlcmUgZGVzaWduZWQsIHRoZSBwaW4KPiA+IGNvbnRy b2wgc3Vic3lzdGVtIGhhcyB0aGUgcGhpbG9zb3BoeSB0aGF0IGV4dGVuc2lvbnMgYXJlIGZvciBt aW5vciBmcmluZ2UKPiA+IHN0dWZmLCBzdWNoIGFzIGEgcGluIGNvbmZpZyBvcHRpb24gdGhhdCBu byBvdGhlciBzaWxpY29uIGlzIHVzaW5nIGFuZCB0aHVzIGhhdmUKPiA+IG5vIHVzZSBmb3IgYW55 b25lIGVsc2UuIFdlbGwgdGhhdCBpcyBhY3R1YWxseSBhbGwgdGhlIGN1c3RvbSBleHRlbnNpb25z IHdlCj4gPiBoYXZlLgo+ID4gKFRoaXMgbm90aW9uIGlzIGV2ZW4gY2FycmllZCBvdmVyIHRvIFND TUkgcGluY3RybC4pCj4gPiAKPiA+IFRoZSBpLk1YOTUgT0VNIGV4dGVuc2lvbiBpcyByZWFsbHkg b2RkIHRvIG1lLCBpdCBsb29rcyBsaWtlIGEKPiA+IHJlaW1wbGVtZW50YXRpb24gb2YgdGhlIGNv cmUgYXNwZWN0cyBvZiBTQ01JIHBpbiBjb250cm9sLCBhbmQgbG9va3MgbXVjaAo+ID4gbW9yZSBs aWtlIHRoZSBvbGQgaS5NWCBkcml2ZXJzIHRoYW4gbGlrZSB0aGUgU0NNSSBkcml2ZXIuCj4gCj4g aS5NWCBTQ01JIHBpbiBwcm90b2NvbCBjb25mIHNldHRpbmdzIGZvbGxvd3Mgbm9uLVNDTUkgcGlu IGNvbmYgc2V0dGluZ3MuCj4gCgpJdCBpcyBub3QganVzdCBhIG1hdHRlciBvZiB1c2luZyBjdXN0 b20gU0NNSSBPRU0gdHlwZXMsIGl0IGlzIHRoZSB3aG9sZQpsYXlvdXQvZGVmaW5pdGlvbnMgb2Yg dGhlIGkuTVggcGluL2dyb3Vwcy9mdW5jcyBEVCBiaW5kaW5ncyB0aGF0IGRldmlhdGVzIGZyb20K dGhlIGdlbmVyaWMgRFQgYmluZGluZ3MgbGF5b3V0IGFzIGhhbmRsZWQgYW5kIGV4cGVjdGVkIGJ5 IHRoZSBMaW51eCBQaW5jdHJsCnN1YnN5c3RlbSAoQUZBSVUpLCB3aGlsZSB0aGUgU0NNSSBQaW5j dHJsIGRyaXZlciBhcyBpdCBzdGFuZHMgaW4gdGhpcyBzZXJpZXMsCndhcyBjb25jZWl2ZWQsIGRl c2lnbmVkIGFuZCBpbXBsZW1lbnRlZCBvcmlnaW5hbGx5IGJ5IE9sZWtzaWkgdG8ganVzdCB1c2Ug dGhlCmdlbmVyaWMgZXhpc3RpbmcgUGluY3RybCBEVCBiaW5kaW5nczsgYXMgYSBjb25zZXF1ZW5j ZSwgaW4geW91ciBpLk1YIGV4dGVuc2lvbnMsCnlvdSBoYWQgdG8gYWRkIGEgZGVkaWNhdGVkIGku TVggRFQgcGFyc2VyIHRvIGludGVycHJldCB0aGUgcHJvdG9jb2xAMTkgRFQgc25pcHBldAppbiBh IGNvbXBsZXRlbHkgZGlmZmVyZW50IHdheSwgdG8gdHJ5IHRvIHN0aWNrIHlvdXIgY3VzdG9tIHNv bHV0aW9uIG9uIHRvcCBvZgp0aGUgZ2VuZXJpYyBvbmUuCgpUaGFua3MsCkNyaXN0aWFuCgo+ID4g Cj4gPiBCdXQgSSBzdXJlIGNhbm5vdCBzcGVhayBvZiB3aGF0IGlzIGFsbG93ZWQgaW4gU0NNSSBP RU0gZXh0ZW5zaW9ucyBvciBub3QuCj4gCj4gKyBTUEVDIG93bmVyLCBTb3V2aWsuIEFueSBjb21t ZW50cz8KPiAKPiBUaGFua3MsCj4gUGVuZy4KPiAKPiA+IAo+ID4gWW91cnMsCj4gPiBMaW51cyBX YWxsZWlqCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==