From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Howard Yen <howardyen@google.com>,
hch@lst.de, m.szyprowski@samsung.com, gregkh@linuxfoundation.org,
petr.tesarik.ext@huawei.com, rafael@kernel.org,
broonie@kernel.org, james@equiv.tech, james.clark@arm.com,
masahiroy@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev
Subject: Re: [PATCH] dma-coherent: add support for multi coherent rmems per dev
Date: Thu, 1 Feb 2024 13:45:19 +0200 [thread overview]
Message-ID: <ZbuETxd_MfFN45C8@smile.fi.intel.com> (raw)
In-Reply-To: <f5b626ae-bda1-479f-bc14-b1fd7ba043cf@arm.com>
On Thu, Feb 01, 2024 at 10:45:30AM +0000, Robin Murphy wrote:
> On 2024-02-01 9:35 am, Howard Yen wrote:
...
> > struct dma_coherent_mem *dma_mem; /* internal for coherent mem
> > override */
> > + struct list_head dma_mem_list;
>
> I'm not necessarily against the idea, but only if it's implemented sensibly.
> If we're going to have a list of these it should *replace* the existing
> pointer, not do this weird thing with both.
+1 on the comment.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-02-01 11:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 9:35 [PATCH] dma-coherent: add support for multi coherent rmems per dev Howard Yen
2024-02-01 10:45 ` Robin Murphy
2024-02-01 11:45 ` Andy Shevchenko [this message]
2024-02-01 15:41 ` Greg KH
2024-02-02 4:40 ` Howard Yen
2024-02-02 15:09 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbuETxd_MfFN45C8@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=howardyen@google.com \
--cc=iommu@lists.linux.dev \
--cc=james.clark@arm.com \
--cc=james@equiv.tech \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=masahiroy@kernel.org \
--cc=petr.tesarik.ext@huawei.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.