All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Aahil Awatramani <aahila@google.com>
Cc: David Dillow <dillow@google.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jan Dabros <jsd@semihalf.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree
Date: Thu, 1 Feb 2024 13:46:58 +0200	[thread overview]
Message-ID: <ZbuEsltcMLNn4SyF@smile.fi.intel.com> (raw)
In-Reply-To: <20240201044623.374389-1-aahila@google.com>

On Thu, Feb 01, 2024 at 04:46:22AM +0000, Aahil Awatramani wrote:
> The Synopsys i2c driver allows a user to override the parameters
> controlling the waveform using ACPI; this is useful for fine tuning when
> needed to make spec compliance. Extend this support to the device tree to
> allow non-ACPI platforms the same capabilities.

DT has different counters from which one should derive these ones.
Can you explain why existing bindings may _not_ be utilised?

Without this very justification, NAK.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2024-02-01 11:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  4:46 [PATCH 1/2] dt-bindings: i2c: designware: allow fine tuning tuning waveform from device tree Aahil Awatramani
2024-02-01  4:46 ` [PATCH 2/2] " Aahil Awatramani
2024-02-01  7:34   ` Krzysztof Kozlowski
2024-02-01  7:33 ` [PATCH 1/2] dt-bindings: " Krzysztof Kozlowski
2024-02-01 11:46 ` Andy Shevchenko [this message]
2024-02-09 21:05   ` Aahil Awatramani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZbuEsltcMLNn4SyF@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=aahila@google.com \
    --cc=andi.shyti@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dillow@google.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jsd@semihalf.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=robh+dt@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.