From: Sean Christopherson <seanjc@google.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ashish Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH v4 2/4] KVM: SVM: Use unsigned integers when dealing with ASIDs
Date: Thu, 1 Feb 2024 09:02:17 -0800 [thread overview]
Message-ID: <ZbvOmf8N-tLOr-0r@google.com> (raw)
In-Reply-To: <7d74cea0-2d98-476b-8d55-ec3a4e3c0fc7@amd.com>
On Thu, Feb 01, 2024, Tom Lendacky wrote:
> On 1/31/24 17:56, Sean Christopherson wrote:
> > @@ -2312,7 +2314,7 @@ int sev_cpu_init(struct svm_cpu_data *sd)
> > */
> > static void sev_flush_encrypted_page(struct kvm_vcpu *vcpu, void *va)
> > {
> > - int asid = to_kvm_svm(vcpu->kvm)->sev_info.asid;
> > + unsigned int asid = to_kvm_svm(vcpu->kvm)->sev_info.asid;
>
> Since you're touching this, you could switch this to:
>
> unsigned int asid = sev_get_asid(vcpu->kvm);
Ah, good call, will do when applying.
Thanks!
next prev parent reply other threads:[~2024-02-01 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 23:56 [PATCH v4 0/4] Add support for allowing zero SEV ASIDs Sean Christopherson
2024-01-31 23:56 ` [PATCH v4 1/4] KVM: SVM: Set sev->asid in sev_asid_new() instead of overloading the return Sean Christopherson
2024-02-01 16:20 ` Tom Lendacky
2024-01-31 23:56 ` [PATCH v4 2/4] KVM: SVM: Use unsigned integers when dealing with ASIDs Sean Christopherson
2024-02-01 16:27 ` Tom Lendacky
2024-02-01 17:02 ` Sean Christopherson [this message]
2024-01-31 23:56 ` [PATCH v4 3/4] KVM: SVM: Add support for allowing zero SEV ASIDs Sean Christopherson
2024-01-31 23:56 ` [PATCH v4 4/4] KVM: SVM: Return -EINVAL instead of -EBUSY on attempt to re-init SEV/SEV-ES Sean Christopherson
2024-02-01 16:32 ` Tom Lendacky
2024-02-06 21:36 ` [PATCH v4 0/4] Add support for allowing zero SEV ASIDs Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbvOmf8N-tLOr-0r@google.com \
--to=seanjc@google.com \
--cc=ashish.kalra@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.