From: Yosry Ahmed <yosryahmed@google.com>
To: Chengming Zhou <zhouchengming@bytedance.com>
Cc: Nhat Pham <nphamcs@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/6] mm/zswap: add more comments in shrink_memcg_cb()
Date: Thu, 1 Feb 2024 23:55:07 +0000 [thread overview]
Message-ID: <ZbwuAyAYi_XxMEn_@google.com> (raw)
In-Reply-To: <20240201-b4-zswap-invalidate-entry-v1-1-56ed496b6e55@bytedance.com>
On Thu, Feb 01, 2024 at 03:49:01PM +0000, Chengming Zhou wrote:
> Add more comments in shrink_memcg_cb() to describe the deref dance
> which is implemented to fix race problem between lru writeback and
> swapoff, and the reason why we rotate the entry at the beginning.
>
> Also fix the stale comments in zswap_writeback_entry(), and add
> more comments to state that we only deref the tree after we get
> the swapcache reference.
>
> Suggested-by: Yosry Ahmed <yosryahmed@google.com>
> Suggested-by: Johannes Weiner <hannes@cmpxchg.org>
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Acked-by: Yosry Ahmed <yosryahmed@google.com>
Thanks!
next prev parent reply other threads:[~2024-02-01 23:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 15:49 [PATCH 0/6] mm/zswap: optimize zswap lru list Chengming Zhou
2024-02-01 15:49 ` [PATCH 1/6] mm/zswap: add more comments in shrink_memcg_cb() Chengming Zhou
2024-02-01 17:45 ` Johannes Weiner
2024-02-01 23:55 ` Yosry Ahmed [this message]
2024-02-02 22:25 ` Nhat Pham
2024-02-01 15:49 ` [PATCH 2/6] mm/zswap: invalidate zswap entry when swap entry free Chengming Zhou
2024-02-01 17:49 ` Johannes Weiner
2024-02-01 20:56 ` Nhat Pham
2024-02-02 0:11 ` Yosry Ahmed
2024-02-02 8:10 ` Chengming Zhou
2024-02-01 15:49 ` [PATCH 3/6] mm/zswap: stop lru list shrinking when encounter warm region Chengming Zhou
2024-02-01 17:51 ` Johannes Weiner
2024-02-01 18:10 ` Nhat Pham
2024-02-02 0:15 ` Yosry Ahmed
2024-02-02 8:12 ` Chengming Zhou
2024-02-01 15:49 ` [PATCH 4/6] mm/zswap: remove duplicate_entry debug value Chengming Zhou
2024-02-01 17:55 ` Johannes Weiner
2024-02-02 8:18 ` Chengming Zhou
2024-02-02 22:17 ` Yosry Ahmed
2024-02-02 22:28 ` Nhat Pham
2024-02-03 4:29 ` Chengming Zhou
2024-02-01 15:49 ` [PATCH 5/6] mm/zswap: only support zswap_exclusive_loads_enabled Chengming Zhou
2024-02-01 18:12 ` Johannes Weiner
2024-02-02 1:04 ` Yosry Ahmed
2024-02-02 12:57 ` Chengming Zhou
2024-02-02 16:26 ` Johannes Weiner
2024-02-03 4:33 ` Chengming Zhou
2024-02-02 22:15 ` Yosry Ahmed
2024-02-02 22:31 ` Nhat Pham
2024-02-01 15:49 ` [PATCH 6/6] mm/zswap: zswap entry doesn't need refcount anymore Chengming Zhou
2024-02-02 1:11 ` Yosry Ahmed
2024-02-02 13:00 ` Chengming Zhou
2024-02-02 16:28 ` Johannes Weiner
2024-02-02 22:33 ` Nhat Pham
2024-02-02 22:36 ` Yosry Ahmed
2024-02-02 22:44 ` Nhat Pham
2024-02-03 5:09 ` Chengming Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbwuAyAYi_XxMEn_@google.com \
--to=yosryahmed@google.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.