All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
	Michal Wajdeczko <michal.wajdeczko@intel.com>
Subject: Re: [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits() to wordpath.h
Date: Wed, 14 Feb 2024 20:12:00 +0200	[thread overview]
Message-ID: <Zc0CcNbpFrkkqiow@smile.fi.intel.com> (raw)
In-Reply-To: <9cba3b78-1020-4337-a1f9-5857a297aee4@infradead.org>

On Wed, Feb 14, 2024 at 10:09:10AM -0800, Randy Dunlap wrote:
> On 2/14/24 09:26, Andy Shevchenko wrote:
> > The wordpart.h header is collecting APIs related to the handling
> > parts of the word (usually in byte granularity). The upper_*_bits()
> > and lower_*_bits() are good candidates to be moved to there.
> > 
> > This helps to clean up header dependency hell with regard to kernel.h
> > as the latter gathers completely unrelated stuff together and slows
> > down compilation (especially when it's included into other header).
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > 
> > Kees, since wordpart.h is now only in your tree, this is supposed
> > to go there as well.
> 
> after someone corrects the Subject (wordpath -> wordpart).

Oh, indeed. Thanks for spotting this!
Kees, should I send a v2 or you can amend when applying?

> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks!

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2024-02-14 18:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14 17:26 [PATCH v1 1/1] kernel.h: Move upper_*_bits() and lower_*_bits() to wordpath.h Andy Shevchenko
2024-02-14 18:09 ` Randy Dunlap
2024-02-14 18:12   ` Andy Shevchenko [this message]
2024-02-14 18:54     ` Kees Cook
2024-02-14 18:54 ` Kees Cook
2024-02-15  8:53 ` Max Kellermann
2024-02-15 13:50   ` Andy Shevchenko
2024-02-15 13:51     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zc0CcNbpFrkkqiow@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.wajdeczko@intel.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.