From: "Christian A. Ehrhardt" <lk@c--e.de>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Sing-Han Chen" <singhanc@nvidia.com>,
"Haotien Hsu" <haotienh@nvidia.com>,
"Utkarsh Patel" <utkarsh.h.patel@intel.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Wayne Chang" <waynec@nvidia.com>, "WK Tsai" <wtsai@nvidia.com>
Subject: Re: [PATCH CFT] usb: ucsi_ccg: Fix command completion handling
Date: Thu, 15 Feb 2024 13:03:03 +0100 [thread overview]
Message-ID: <Zc39d88ikvCO+XVK@cae.in-ulm.de> (raw)
In-Reply-To: <2024021504-oven-worst-5c15@gregkh>
Hi Greg,
On Thu, Feb 15, 2024 at 12:07:20PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Feb 15, 2024 at 11:10:24AM +0100, Christian A. Ehrhardt wrote:
> > In case of a spurious or otherwise delayed interrupt
> > it is possible that CCI still reports the previous completion.
> > For this reason the UCSI spec provides different completion
> > bits for normal commands and for UCSI_ACK_CC_CI.
> >
> > Only complete a sync command if the correct completion bit
> > is set.
> >
> > This should avoid the need to clear out CCI before starting
> > a command. Thus remove this code.
> >
> > Signed-off-by: Christian A. Ehrhardt <lk@c--e.de>
> > Fixes: e32fd989ac1c ("usb: typec: ucsi: ccg: Move to the new API")
>
> What does "CFT" in your subject line mean?
It's supposed to mean "Call For Testers". More info in the
"Additional Information" section of the original mail.
I think the change is necessary and good but I do not have the HW
to test it.
I did test a similar change for ucsi_acpi.c that got merged and this
is the ping for ucsi_ccg.c people that they probably need this, too.
regards Christian
next prev parent reply other threads:[~2024-02-15 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 10:10 [PATCH CFT] usb: ucsi_ccg: Fix command completion handling Christian A. Ehrhardt
2024-02-15 11:07 ` Greg Kroah-Hartman
2024-02-15 12:03 ` Christian A. Ehrhardt [this message]
2024-02-29 7:18 ` HaoTien Hsu
2024-02-29 20:13 ` Christian A. Ehrhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc39d88ikvCO+XVK@cae.in-ulm.de \
--to=lk@c--e.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=haotienh@nvidia.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=singhanc@nvidia.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=utkarsh.h.patel@intel.com \
--cc=waynec@nvidia.com \
--cc=wtsai@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.