From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE6EAC4829E for ; Thu, 15 Feb 2024 11:21:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TbCLX3tLqz3vYK for ; Thu, 15 Feb 2024 22:21:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arm.com (client-ip=217.140.110.172; helo=foss.arm.com; envelope-from=mark.rutland@arm.com; receiver=lists.ozlabs.org) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lists.ozlabs.org (Postfix) with ESMTP id 4TbCL338mRz30Q3 for ; Thu, 15 Feb 2024 22:20:58 +1100 (AEDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 816FD150C; Thu, 15 Feb 2024 03:21:08 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.68.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 045423F7B4; Thu, 15 Feb 2024 03:20:23 -0800 (PST) Date: Thu, 15 Feb 2024 11:20:21 +0000 From: Mark Rutland To: Ryan Roberts Subject: Re: [PATCH v6 09/18] arm64/mm: Convert ptep_clear() to ptep_get_and_clear() Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-10-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-10-ryan.roberts@arm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kefeng Wang , x86@kernel.org, David Hildenbrand , Catalin Marinas , Yang Shi , Dave Hansen , linux-mm@kvack.org, Andrey Ryabinin , "H. Peter Anvin" , Will Deacon , Ard Biesheuvel , Marc Zyngier , Alistair Popple , Barry Song <21cnbao@gmail.com>, Matthew Wilcox , Ingo Molnar , Zi Yan , John Hubbard , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Morse , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 15, 2024 at 10:31:56AM +0000, Ryan Roberts wrote: > ptep_clear() is a generic wrapper around the arch-implemented > ptep_get_and_clear(). We are about to convert ptep_get_and_clear() into > a public version and private version (__ptep_get_and_clear()) to support > the transparent contpte work. We won't have a private version of > ptep_clear() so let's convert it to directly call ptep_get_and_clear(). > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Mark Rutland Mark. > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 27f6160890d1..48e8b429879d 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -229,7 +229,7 @@ static void clear_flush(struct mm_struct *mm, > unsigned long i, saddr = addr; > > for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) > - ptep_clear(mm, addr, ptep); > + ptep_get_and_clear(mm, addr, ptep); > > flush_tlb_range(&vma, saddr, addr); > } > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D68C4829E for ; Thu, 15 Feb 2024 11:20:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/wsVlcARp+GYToOz0ZvZlPuD4yjNXqH69JqjyF3X0lE=; b=ghhywpTcaFEHWN 0XyDtzJg3T+xYAsXmLqNNv92/jIL0PkYxsynEmvfzyvkOIsnvl/ZDDQaaNV6T4YY6yKNspJpXgb9j ZvP26dTWyYg+a2OtZielyItHh4oblxwoRISpAxt5hruckISamqTo4jIlBQkmmebc+VxHOD1eYUh/I 2jv1B3SgOh4kg8T91f9SsW6RTx7S1Q2pAqwaCysMf7xUEjK52WnsDNEcMHGG57oPIg5sRoDQYbYkh TJPpYt19CgIN3eKDlw2pBKt76WsZx/fPOSuI65hs7UDCMGs3ONZbJUeSMxD1oQqWxZ45+F8dqYtwy y9ZCI1zUrO4rJSfRfC6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raZn6-0000000G0Ut-0tmv; Thu, 15 Feb 2024 11:20:32 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1raZn3-0000000G0Tb-1N63 for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 11:20:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 816FD150C; Thu, 15 Feb 2024 03:21:08 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.68.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 045423F7B4; Thu, 15 Feb 2024 03:20:23 -0800 (PST) Date: Thu, 15 Feb 2024 11:20:21 +0000 From: Mark Rutland To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 09/18] arm64/mm: Convert ptep_clear() to ptep_get_and_clear() Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-10-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240215103205.2607016-10-ryan.roberts@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_032029_436551_3E804553 X-CRM114-Status: GOOD ( 18.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 10:31:56AM +0000, Ryan Roberts wrote: > ptep_clear() is a generic wrapper around the arch-implemented > ptep_get_and_clear(). We are about to convert ptep_get_and_clear() into > a public version and private version (__ptep_get_and_clear()) to support > the transparent contpte work. We won't have a private version of > ptep_clear() so let's convert it to directly call ptep_get_and_clear(). > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Mark Rutland Mark. > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 27f6160890d1..48e8b429879d 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -229,7 +229,7 @@ static void clear_flush(struct mm_struct *mm, > unsigned long i, saddr = addr; > > for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) > - ptep_clear(mm, addr, ptep); > + ptep_get_and_clear(mm, addr, ptep); > > flush_tlb_range(&vma, saddr, addr); > } > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EF1CC4829E for ; Thu, 15 Feb 2024 11:20:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2FE38D000E; Thu, 15 Feb 2024 06:20:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DFA08D0001; Thu, 15 Feb 2024 06:20:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A7FE8D000E; Thu, 15 Feb 2024 06:20:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 768368D0001 for ; Thu, 15 Feb 2024 06:20:30 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2B9BF161006 for ; Thu, 15 Feb 2024 11:20:30 +0000 (UTC) X-FDA: 81793795020.09.0E9A7B4 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 8636D20022 for ; Thu, 15 Feb 2024 11:20:28 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707996028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tH2elRLSe7WOgZdPnk8RrzizqylLRzqaAMmDkAnF/2c=; b=PDDMN9NiGy+bZAgmfh2ffg2jBT1Y5ieYuFpx4Ca/+D40H5lqdOrmBkPTy4o4IghC1JghTl jKdECAG479nq4w+iA5CRrWCH9HjEpnw3D2itlvnpflMfqQ6w14jYTiQ2rGD3NCrUUyop/o UTqx2Ynv4eILuRruMWDeCLzZt0+BuY4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of mark.rutland@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=mark.rutland@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707996028; a=rsa-sha256; cv=none; b=E6o+6/OS/ZlKukau2NXrjBYoUZ6Zl/QHehqA1+x4MG7deqUTFublGtU8+5/Yz8wVLkwppj Nx3vTKsJPxS3lRTRTkKssSy43vNu3ak7Kc25d0u9ZKHdtKQ+vr6T8IUXHkJm3+yr9Zh3S2 ry/PoPWq/HyxwA9Rxd3Ib6FZZGGP3js= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 816FD150C; Thu, 15 Feb 2024 03:21:08 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.68.11]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 045423F7B4; Thu, 15 Feb 2024 03:20:23 -0800 (PST) Date: Thu, 15 Feb 2024 11:20:21 +0000 From: Mark Rutland To: Ryan Roberts Cc: Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 09/18] arm64/mm: Convert ptep_clear() to ptep_get_and_clear() Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-10-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-10-ryan.roberts@arm.com> X-Rspamd-Queue-Id: 8636D20022 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 5d97yiuk9gt85hkwu4iczwk6mrk8dgop X-HE-Tag: 1707996028-576533 X-HE-Meta: U2FsdGVkX1+dO1qH/joVvjqkJjl8CARG2LGj8RBvBK1yGM6axrndAMRBVU2gSNtfp7Vu6di46SGGvvgYj9jIx8GF1l0XfbNP03F1Zd4Qyi7Xt+5DWEGkEgAp11m8xHeBqWFtI2a5C0txtBNkJhqmp4vHlTIKJpJ1Gau2UlEfOoeXDZilSzwk0Va1vLLCi96QIhJx/iJ35qwEB2aGHVHuzbp9+w9mo6cYbbd03sHT49QO5P6NMdcxegXIjju8q/we/yZyVUvG8cwLSrC9W+NVGtrX2yaBZeM4t8P40U/BrEHlIDy+qXVVF+Mt3xBc9MWyGyGoTGK7uq9ZFGrnMf2pQFqXhoH8xXxDt6Fa69sQzXFbcbZR3FEPFBzrgRc5sltxXi+S7jjDBfhmW3giwqtiBnUXVR9dD+eMi1KAU4ChkjzPEDJpq4ywsqSfzXQbtlRkPPuojGpsuh7rFOPrXwCXPXHPSAfptkUCcNKrPiGGgHPh6YqMLyEVWWK1tK7JG+cqjWHhIMeSlczWHCATMOGWTsZEW7QEffZkaDTUoJMBQhOndrQ0JXun5tUxr/ap2b0X7MWUPVWy8bgU6kkr4mz/GDMJ/OVcy+S26DzF5jxdFcc47Zm/WCtyAMT6yt2mPWnUYry5suGs8xg0ZWA7JC1wX57K3phRowecYoWPt48gvwClW3wnOOV/6next/KIgpUVLBLl14UhlnaCro2xLL3IIMG3PoF1/j46uxLX7Z7YIm5y1FLJKZ2jn8hBExf0OeGhErvr5rHJm7j7lQ+WBtIsnQ9TgFKejCh/Ar3qwl93GDvwVCTg4/NRjBJKchoxjHjfjGnLsaHOcgAllJrDLPcaX/g6Xej/E2/yWyNM5McSqgH1pwsSkxCFngvnyWR/rd/5VvbOEbFM5gvsH9J2pr0PWa89CTx9Q0jWs7ii6YivvubZ2OsyatiEXUx6HZGDebJfL8+UD1XxiYsHxjP9Q0B 9+3D5BhX GWUP0Z5kVXxF9/JNyoNOvHdHqjEM3I/mYVqvkaBDk8OEtjM/l38A/VKREyECMGZV8GUg8ctpLMMn+6IRaG3/EH3EAni2ie23SWXQZWrrIBk/n57Z2DiKt8LFpuCjIvluKjGOcgTjmkNYvzoS21zBTicmnqzqEEgTdPP7SLp4ruAsdrjhfszc+QJ5cIkzdlLmZchLTkGep2iGKuhbTMKTHlFXRxathEDlwvnEO2+5ebOCnBQFdwPZg6m2SnnmOk9QkL7PNMV5+gA+BPiZF2+D8On+vgIsrLQBR3qa2NlgJa52Z6k2TGj3MiV+tmJMyf1lGg4lsTHjHebv8FMBA07LvKrWTOF5bPzgleK8O X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:56AM +0000, Ryan Roberts wrote: > ptep_clear() is a generic wrapper around the arch-implemented > ptep_get_and_clear(). We are about to convert ptep_get_and_clear() into > a public version and private version (__ptep_get_and_clear()) to support > the transparent contpte work. We won't have a private version of > ptep_clear() so let's convert it to directly call ptep_get_and_clear(). > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Mark Rutland Mark. > --- > arch/arm64/mm/hugetlbpage.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/hugetlbpage.c b/arch/arm64/mm/hugetlbpage.c > index 27f6160890d1..48e8b429879d 100644 > --- a/arch/arm64/mm/hugetlbpage.c > +++ b/arch/arm64/mm/hugetlbpage.c > @@ -229,7 +229,7 @@ static void clear_flush(struct mm_struct *mm, > unsigned long i, saddr = addr; > > for (i = 0; i < ncontig; i++, addr += pgsize, ptep++) > - ptep_clear(mm, addr, ptep); > + ptep_get_and_clear(mm, addr, ptep); > > flush_tlb_range(&vma, saddr, addr); > } > -- > 2.25.1 >