All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Benjamin Bara" <benjamin.bara@skidata.com>,
	"Richard Leitner" <richard.leitner@linux.dev>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] input: touchcreen: tsc2007: make interrupt optional
Date: Thu, 15 Feb 2024 09:55:12 -0800	[thread overview]
Message-ID: <Zc5QANGhS8EPvgEy@google.com> (raw)
In-Reply-To: <20240210175530.137361-2-clamor95@gmail.com>

Hi Svyatoslav,

On Sat, Feb 10, 2024 at 07:55:30PM +0200, Svyatoslav Ryhel wrote:
> In case tsc2007 is used as an ADC sensor there will be no interrupt
> provided at all, so set up an interrupt only if one is present and
> remove associated warning.

If we want to do this, we should better handle the input device portion
of the driver. We have 2 options:

- switch the input device into polling mode when interrupt is absent
- do not create input device

Those do not need to be mutually exclusive (i.e. we could use absence of
both device tree interrupt property as well as lack of poll-interval
property to suppress creation of the input device and only leave iio.

Thanks.

-- 
Dmitry

  reply	other threads:[~2024-02-15 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-10 17:55 [PATCH v1 0/1] input: touchcreen: tsc2007: make interrupt optional Svyatoslav Ryhel
2024-02-10 17:55 ` [PATCH v1 1/1] " Svyatoslav Ryhel
2024-02-15 17:55   ` Dmitry Torokhov [this message]
2024-02-15 18:09     ` Svyatoslav Ryhel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zc5QANGhS8EPvgEy@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=benjamin.bara@skidata.com \
    --cc=clamor95@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.leitner@linux.dev \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.