From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F365C48BC4 for ; Thu, 15 Feb 2024 19:21:49 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4TbQ0q677Mz3vcl for ; Fri, 16 Feb 2024 06:21:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:40e1:4800::1; helo=sin.source.kernel.org; envelope-from=cmarinas@kernel.org; receiver=lists.ozlabs.org) Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4TbQ0N5tLvz3dHK for ; Fri, 16 Feb 2024 06:21:24 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1FA8CCE1C49; Thu, 15 Feb 2024 19:21:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852F2C433F1; Thu, 15 Feb 2024 19:21:15 +0000 (UTC) Date: Thu, 15 Feb 2024 19:21:13 +0000 From: Catalin Marinas To: Ryan Roberts Subject: Re: [PATCH v6 10/18] arm64/mm: New ptep layer to manage contig bit Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-11-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-11-ryan.roberts@arm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kefeng Wang , x86@kernel.org, David Hildenbrand , Yang Shi , Dave Hansen , linux-mm@kvack.org, Andrey Ryabinin , "H. Peter Anvin" , Will Deacon , Ard Biesheuvel , Marc Zyngier , Alistair Popple , Barry Song <21cnbao@gmail.com>, Matthew Wilcox , Ingo Molnar , Zi Yan , John Hubbard , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, James Morse , Andrew Morton , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Feb 15, 2024 at 10:31:57AM +0000, Ryan Roberts wrote: > Create a new layer for the in-table PTE manipulation APIs. For now, The > existing API is prefixed with double underscore to become the > arch-private API and the public API is just a simple wrapper that calls > the private API. > > The public API implementation will subsequently be used to transparently > manipulate the contiguous bit where appropriate. But since there are > already some contig-aware users (e.g. hugetlb, kernel mapper), we must > first ensure those users use the private API directly so that the future > contig-bit manipulations in the public API do not interfere with those > existing uses. > > The following APIs are treated this way: > > - ptep_get > - set_pte > - set_ptes > - pte_clear > - ptep_get_and_clear > - ptep_test_and_clear_young > - ptep_clear_flush_young > - ptep_set_wrprotect > - ptep_set_access_flags > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 708F6C4829E for ; Thu, 15 Feb 2024 19:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wJiQvp5pAPHpGAcU2oTe4QkOXS7fVLmp8F6s8dE16pI=; b=16shTuThsnyste wdumgpAQpqdOa+r45ndJpIo8Y3ePGf+lK8GReJH8ASqdzuwuJfKkm5uoJhBDO39ZiX8J8WDc3oaob bY3aDXSLFVywLtmz2VRVjJqgvtLUhB4A95JP9dKT5Fc0Y49f5rcDurOtmtvm5OQSFbL9cgdfMgoUX o8FofI4W8guUfvr9zmXMH7Z3LDzYU4+ZAgVAp17Ohva2gazGlNdxhSais5SpuK3LqRRYu1mqHyKsH vxEEBAmnun0Z7W9r9gVy6P/fRezRMp9MFhQ40WtnVdW2eojA36jWJdW817NHdWIpKebTj4SVRVRJf WZgl10XGb40qEsEmFLDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rahIU-0000000HTdj-2mHo; Thu, 15 Feb 2024 19:21:26 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rahIR-0000000HTc2-0p3t for linux-arm-kernel@lists.infradead.org; Thu, 15 Feb 2024 19:21:25 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1FA8CCE1C49; Thu, 15 Feb 2024 19:21:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852F2C433F1; Thu, 15 Feb 2024 19:21:15 +0000 (UTC) Date: Thu, 15 Feb 2024 19:21:13 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 10/18] arm64/mm: New ptep layer to manage contig bit Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-11-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240215103205.2607016-11-ryan.roberts@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240215_112123_418735_ED159B84 X-CRM114-Status: GOOD ( 14.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Feb 15, 2024 at 10:31:57AM +0000, Ryan Roberts wrote: > Create a new layer for the in-table PTE manipulation APIs. For now, The > existing API is prefixed with double underscore to become the > arch-private API and the public API is just a simple wrapper that calls > the private API. > > The public API implementation will subsequently be used to transparently > manipulate the contiguous bit where appropriate. But since there are > already some contig-aware users (e.g. hugetlb, kernel mapper), we must > first ensure those users use the private API directly so that the future > contig-bit manipulations in the public API do not interfere with those > existing uses. > > The following APIs are treated this way: > > - ptep_get > - set_pte > - set_ptes > - pte_clear > - ptep_get_and_clear > - ptep_test_and_clear_young > - ptep_clear_flush_young > - ptep_set_wrprotect > - ptep_set_access_flags > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA7B7C4829E for ; Thu, 15 Feb 2024 19:21:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 70A796B008A; Thu, 15 Feb 2024 14:21:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B77D6B008C; Thu, 15 Feb 2024 14:21:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57EA96B0092; Thu, 15 Feb 2024 14:21:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4595E6B008A for ; Thu, 15 Feb 2024 14:21:28 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E2C7A1207DA for ; Thu, 15 Feb 2024 19:21:27 +0000 (UTC) X-FDA: 81795007014.18.0CCAF56 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf29.hostedemail.com (Postfix) with ESMTP id C836212001A for ; Thu, 15 Feb 2024 19:21:25 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708024886; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aEXWfOskoddJlaVEp+6gKTRnEzzdl8u8/iTdrQ3QtXU=; b=MC39RGLdP+MTTL8VkeB5eApidM7vXKg3tmMR9Vdp75QymkYAiMzVoE27z+dTCijcaaNQgZ ZRpFYo4855C+lnVj02An2dFMwscNd90S46NC1aJahj1QAeUPv5T6XAEBdVWvBSTXQ+v9fL KoWJiJygOk1kRFzWx/S7WDkDS3qtMH0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf29.hostedemail.com: domain of cmarinas@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708024886; a=rsa-sha256; cv=none; b=Kd9kosTfMfgZ5kqxuKNeveasuZLjQewkAwEPIeJijFKKWF6fs7GEEh6tdGvkxGGtq1DCgi IAhk9knRIF5PYemOQvPS7A4bn57/6VoNiwYXm2Trk35xQg1NSGDLJm0zEqYEnOvqR2Gylu ac0yUHWrFlgMRTBVu5b7wBUWVleuQmk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1FA8CCE1C49; Thu, 15 Feb 2024 19:21:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 852F2C433F1; Thu, 15 Feb 2024 19:21:15 +0000 (UTC) Date: Thu, 15 Feb 2024 19:21:13 +0000 From: Catalin Marinas To: Ryan Roberts Cc: Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Matthew Wilcox , Mark Rutland , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 10/18] arm64/mm: New ptep layer to manage contig bit Message-ID: References: <20240215103205.2607016-1-ryan.roberts@arm.com> <20240215103205.2607016-11-ryan.roberts@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240215103205.2607016-11-ryan.roberts@arm.com> X-Rspamd-Queue-Id: C836212001A X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: uidyxq5nh8zjz5npmkmi7czoc4hjz9ts X-HE-Tag: 1708024885-860446 X-HE-Meta: U2FsdGVkX19LgH1SoEnKvfAJhjpHK7pk/JTq1JZps0r5WcXpHTSyzXcrBIRnx4I+bZ73V/W+G+d77SciaXOYir3c0vWNuqKsR0U4swWIfG1/4u4s8lnmfaiCnfV3roZ10eoNccGjkYF7n5xfvNPY8IafSUsfMDd/Vwla76hHnYR2ctUNzYAlVg6l3sLETY6SC14LL/mwSIlmN6E+WUI9dBpvCz8CrdR6AoXqFbM/MaFp7WQHew/rUwDDnGB18/0Y4w8vyvapRXx5KqyvqLGMRK4onlMd1PFoiJZZ1A5kBlhV+3NIVDSxLCOzg+8lER0VQcBPBnAUXzJcecctTqcCpFkBLh2oV5W3Z2RaNyhNp4v/M2jJC4n85+2DawNMc56hHDYDp2GqLf3fzOI0FVXl1bE2PYhJLJGejcuB2TAzEKU8z0vTUV0KoX/KQCN8WTj81zNEz8YsbpkHD9E5TWtAFtwTt5RB54O9DjSuL9JlXhlw0Nemp8atG+zymr3AUaPMv9ZUnmYIE/ia1t+AQgHD7oT/rDvBI67eGb38uvDEmWWHZFyZKzCmEcItzZBY9cp4ro2CNcDEx5EkKz5N1eoD2irsLTw7l9e4l2GisfHbt9FPU7m1xrEYspzIoV+/HzQoBC3V/3JIdzK2MrSqFizdsGZzO8ZZr0hBizewyMx6UFc32/hDTdgdNog89desDv5kJC+VE6tJZav+9ar/NA9vu1liZbs5xYJmFm/bWlXsZpDJGmHsoU/Dhp/ZohnGrKwkHCmri+1Ioy8WUt4quEewlVhF9rqAzYeV2LAr6zwWD1S1vUSibZi0LveFsjlaH0PB5ijttbdsTQcKvDMHLLHXkGYf240bkBGqnuirMf5nP3kx03pOi3QktAh6iugI9VGWronqRsKUzWGeacfbzTfh1N60YZaa80TpFR7TtSaqk0yIwr6ayCQEONB1fnGQpIH0vvWchkpOGZWfo9Lngw7 4u58ZK92 Q6D5XvpCvmdGeGqhirumc/WgUUtJxcRcNr13pVSjjJQDma/sbIaI5GlKBqe8tfI8uwBKQh1NDo/o3nrUs/eUIsRHN0of25FOr6fbY84wX6aLcGqENaKZPCZBO91ujug5YmcXwJgCQ1V/MaP3NDkLLgpDs0PjZfC3NiBSUr10IGPIQ7zmv7UCelfW2PVKvKL7Ahy/Ghwgkw1Tu9rjLIaEED3U7hKssyDlXkoEzux8fE3hQbfHBjQJ417KHdTysw5WvfwQ+vFvWnPRyA9vyD4qD6PThl8zIO/TUcgU68F3fdmiDZFf8CplGiyhdg4j7V4Rx78IT5oaKia3hVpvziH0FE3i+2P4c1S9kGJRMSB7Qe9YC2S9Oq374lBgowq2GEFnk/k/5AZu5HkOo2c+Z8MMiPUoMO5Vwf5GqeLNSWNCWT8ltABCg0DiaDQKedXUpmwFBTxgedGrmLjPe9Xavvq22CGTlfg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 15, 2024 at 10:31:57AM +0000, Ryan Roberts wrote: > Create a new layer for the in-table PTE manipulation APIs. For now, The > existing API is prefixed with double underscore to become the > arch-private API and the public API is just a simple wrapper that calls > the private API. > > The public API implementation will subsequently be used to transparently > manipulate the contiguous bit where appropriate. But since there are > already some contig-aware users (e.g. hugetlb, kernel mapper), we must > first ensure those users use the private API directly so that the future > contig-bit manipulations in the public API do not interfere with those > existing uses. > > The following APIs are treated this way: > > - ptep_get > - set_pte > - set_ptes > - pte_clear > - ptep_get_and_clear > - ptep_test_and_clear_young > - ptep_clear_flush_young > - ptep_set_wrprotect > - ptep_set_access_flags > > Tested-by: John Hubbard > Signed-off-by: Ryan Roberts Acked-by: Catalin Marinas