From: Oliver Upton <oliver.upton@linux.dev>
To: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
David Matlack <dmatlack@google.com>,
Pasha Tatashin <tatashin@google.com>,
Michael Krebs <mkrebs@google.com>
Subject: Re: [PATCH 2/2] KVM: selftests: Test forced instruction emulation in dirty log test (x86 only)
Date: Thu, 15 Feb 2024 20:13:00 +0000 [thread overview]
Message-ID: <Zc5wTHuphbg3peZ9@linux.dev> (raw)
In-Reply-To: <Zc5c7Af-N71_RYq0@google.com>
On Thu, Feb 15, 2024 at 10:50:20AM -0800, Sean Christopherson wrote:
> Yeah, the funky flow I concocted was done purely to have the "no emulation" path
> fall through to the common "*mem = val". I don't have a strong preference, I
> mentally flipped a coin on doing that versus what you suggested, and apparently
> chose poorly :-)
Oh, I could definitely tell this was intentional :) But really if folks
are going to add more flavors of emulated instructions to the x86
implementation (which they should) then it might make sense to just have
an x86-specific function.
But again, it's selftests, who cares! /s
--
Thanks,
Oliver
next prev parent reply other threads:[~2024-02-15 20:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 1:00 [PATCH 0/2] KVM: x86: Fix dirty logging of emulated atomics Sean Christopherson
2024-02-15 1:00 ` [PATCH 1/2] KVM: x86: Mark target gfn of emulated atomic instruction as dirty Sean Christopherson
2024-02-15 17:13 ` Jim Mattson
2024-02-15 17:57 ` David Matlack
2024-02-15 18:45 ` Sean Christopherson
2024-02-16 17:10 ` Sean Christopherson
2024-02-16 17:14 ` David Matlack
2024-02-15 1:00 ` [PATCH 2/2] KVM: selftests: Test forced instruction emulation in dirty log test (x86 only) Sean Christopherson
2024-02-15 8:21 ` Oliver Upton
2024-02-15 18:50 ` Sean Christopherson
2024-02-15 20:13 ` Oliver Upton [this message]
2024-02-15 21:33 ` Sean Christopherson
2024-02-15 23:27 ` Oliver Upton
2024-02-16 0:26 ` Sean Christopherson
2024-02-16 15:55 ` Oliver Upton
2024-02-16 17:03 ` Sean Christopherson
2024-02-17 1:02 ` [PATCH 0/2] KVM: x86: Fix dirty logging of emulated atomics Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zc5wTHuphbg3peZ9@linux.dev \
--to=oliver.upton@linux.dev \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrebs@google.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=tatashin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.