All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Aleksandr Makarov <aleksandr.o.makarov@gmail.com>
Cc: Fabrice Fontaine <fontaine.fabrice@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further'
Date: Mon, 5 Feb 2024 10:25:10 +0100	[thread overview]
Message-ID: <ZcCpdoR2fzshSSzf@landeda> (raw)
In-Reply-To: <20240204201657.33079-2-aleksandr.o.makarov@gmail.com>

Aleksandr, All,

On 2024-02-04 22:16 +0200, Aleksandr Makarov spake thusly:
> Setting HAPROXY_CFLAGS on the haproxy build command line overrides CFLAGS
> which were internally set by the haproxy Makefile.
> 
> Among those omitted CFLAGS is -fwrapv. Compiling haproxy without it and
> and then running the program results in runtime error:
> 
> $ haproxy
> FATAL ERROR: invalid code detected -- cannot go further, please recompile!
> ...
> 
> To address this issue, include HAPROXY_CFLAGS in the DEFINE variable instead
> of CFLAGS in haproxy.mk.

You forgot to add your Signed-off-by line here, but I messed up and
applied and pushed.

/me goes fumble with his git hooks to understand why that was not
caught...

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> Changes v1 -> v2
>   - Drop patch for haproxy program Makefile, make changes to haproxy.mk instead
> ---
>  package/haproxy/haproxy.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/haproxy/haproxy.mk b/package/haproxy/haproxy.mk
> index 63a92090f3..61a9ebebe4 100644
> --- a/package/haproxy/haproxy.mk
> +++ b/package/haproxy/haproxy.mk
> @@ -82,7 +82,7 @@ endif
>  
>  define HAPROXY_BUILD_CMDS
>  	$(TARGET_MAKE_ENV) $(MAKE) $(TARGET_CONFIGURE_OPTS) \
> -		$(HAPROXY_MAKE_OPTS) CFLAGS="$(HAPROXY_CFLAGS)" -C $(@D)
> +		$(HAPROXY_MAKE_OPTS) DEFINE="$(HAPROXY_CFLAGS)" -C $(@D)
>  endef
>  
>  define HAPROXY_INSTALL_TARGET_CMDS
> -- 
> 2.39.2
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-05  9:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-04 20:16 [Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further Aleksandr Makarov
2024-02-04 20:16 ` [Buildroot] [PATCH v2] package/haproxy: fix runtime 'FATAL ERROR: invalid code detected -- cannot go further' Aleksandr Makarov
2024-02-05  9:25   ` Yann E. MORIN [this message]
2024-02-29 14:21   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcCpdoR2fzshSSzf@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=aleksandr.o.makarov@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.