All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Marcus Hoffmann <buildroot@bubu1.eu>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package
Date: Mon, 5 Feb 2024 14:47:40 +0100	[thread overview]
Message-ID: <ZcDm_KSpgpqSYJ6u@landeda> (raw)
In-Reply-To: <02f46330-bc2b-4dec-a933-0e086db94f2c@bubu1.eu>

Marcus, All,

On 2024-02-05 14:38 +0100, Marcus Hoffmann via buildroot spake thusly:
> Forgot my SoB
> On 21.09.23 22:39, ~bubu wrote:
> > From: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> > Calling `setup.py` build builds and installs  an empty package
> > after upstream changed their packaging. Calling setuptools via
> > `python -m build` builds the package correctly.
> Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>

Thanks. However, the SoB line needs to match the author of the commit,
and that does not match:
    Author:     Marcus Hoffmann <marcus.hoffmann@othermo.de>
    Signed-off-by: Marcus Hoffmann <bubu@bubu1.eu>

Regards,
Yann E. MORIN.

> > ---
> >   package/python-minimalmodbus/python-minimalmodbus.mk | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/package/python-minimalmodbus/python-minimalmodbus.mk b/package/python-minimalmodbus/python-minimalmodbus.mk
> > index 5a6e7733be..cb8a0d8cc9 100644
> > --- a/package/python-minimalmodbus/python-minimalmodbus.mk
> > +++ b/package/python-minimalmodbus/python-minimalmodbus.mk
> > @@ -7,7 +7,8 @@
> >   PYTHON_MINIMALMODBUS_VERSION = 2.1.1
> >   PYTHON_MINIMALMODBUS_SOURCE = minimalmodbus-$(PYTHON_MINIMALMODBUS_VERSION).tar.gz
> >   PYTHON_MINIMALMODBUS_SITE = https://files.pythonhosted.org/packages/37/fc/8a58f7bcdece751f16a4a9aac780acd1288aa8ac6adbffdd764c88fb71c6
> > -PYTHON_MINIMALMODBUS_SETUP_TYPE = setuptools
> > +PYTHON_MINIMALMODBUS_DEPENDENCIES = host-python-setuptools
> > +PYTHON_MINIMALMODBUS_SETUP_TYPE = pep517
> >   PYTHON_MINIMALMODBUS_LICENSE = Apache-2.0
> >   PYTHON_MINIMALMODBUS_LICENSE_FILES = LICENSE
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-02-05 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 20:39 [Buildroot] [PATCH buildroot] package/python-minimalmodbus: fix empty package ~bubu
2024-02-05 13:38 ` Marcus Hoffmann via buildroot
2024-02-05 13:47   ` Yann E. MORIN [this message]
2024-02-05 14:39 ` Yann E. MORIN
2024-02-05 17:20   ` James Hilliard
2024-02-29 15:22 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcDm_KSpgpqSYJ6u@landeda \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@bubu1.eu \
    --cc=buildroot@buildroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.