From: Sean Christopherson <seanjc@google.com>
To: Peter Xu <peterx@redhat.com>
Cc: Shaoqin Huang <shahuang@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Shuah Khan <shuah@kernel.org>,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] KVM: selftests: Fix the dirty_log_test semaphore imbalance
Date: Mon, 5 Feb 2024 07:48:38 -0800 [thread overview]
Message-ID: <ZcEDVkWp6mXoyZsu@google.com> (raw)
In-Reply-To: <ZcCyzrUhXSlhKyqC@x1n>
On Mon, Feb 05, 2024, Peter Xu wrote:
> Shaoqin, Sean,
>
> Apologies for a late comment. I'm trying to remember what I wrote..
>
> On Fri, Feb 02, 2024 at 01:43:32AM -0500, Shaoqin Huang wrote:
> > Why sem_vcpu_cont and sem_vcpu_stop can be non-zero value? It's because
> > the dirty_ring_before_vcpu_join() execute the sem_post(&sem_vcpu_cont)
> > at the end of each dirty-ring test. It can cause two cases:
>
> As a possible alternative, would it work if we simply reset all the sems
> for each run? Then we don't care about the leftovers. E.g. sem_destroy()
> at the end of run_test(), then always init to 0 at entry.
Gah, I posted v4[*] and didn't Cc you. I would prefer not to reset the semaphores,
mostly because it encourages sloppiness in the test. There's no reason to allow
the two threads to effectively get out of sync.
[*] https://lore.kernel.org/all/17eefa60-cf30-4830-943e-793a63d4e6f1@redhat.com
prev parent reply other threads:[~2024-02-05 15:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 6:43 [PATCH v3] KVM: selftests: Fix the dirty_log_test semaphore imbalance Shaoqin Huang
2024-02-02 17:46 ` Sean Christopherson
2024-02-02 21:14 ` Sean Christopherson
2024-02-05 10:05 ` Peter Xu
2024-02-05 10:18 ` Peter Xu
2024-02-05 15:48 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcEDVkWp6mXoyZsu@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=shahuang@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.