Re: git-gui desktop launcher

["brian m. carlson" <sandals@crustytoothpaste.net>]

[-- Attachment #1: Type: text/plain, Size: 2733 bytes --]

On 2024-02-05 at 20:12:10, Tobias Boesch wrote:
> Hello everyone,
> 
> quoting from downstream issue:
> https://gitlab.archlinux.org/archlinux/packaging/packages/git/-/issues/5
> 
> -------------------------
> 
> "As far as I can see git gui cannot easily be used by me on arch.
> A .desktop entry is missing for me.
> I created one that opens git gui.
> It also adds an entry in the "Open With..." menu of file managers (I
> tested only with Nautilus). Opeing git gui with this entry git gui is
> opened in the folder where the menu was opened.
> If it is a git repository git gui open it. If it is no git repository
> git gui opens just as if it was called from the desktop launcher.
> Since it took a while to create it and adds value for me I would like
> to share it to be added to the git package by default.
> It is far from being perfect. It's a first working version. For me
> personally it is enough.
> Before tweaking it further to fit the packaging standards I would like
> to ask if is desired to be added.
> 
> .desktop file proposal
> 
> [Desktop Entry]
> Name=git gui

I don't know whether this is the official name of the project or not.
Perhaps someone else can comment on what the capitalization and
punctuation of this entry should be.

> Comment=A portable graphical interface to Git
> Exec=/bin/bash -c 'if [[ "$0" = "/bin/bash" ]]; then git gui; else cd
> "$0" && git gui; fi' %F

It's not guaranteed that bash even exists on the system, let alone that
it's in /bin.  For example, this wouldn't work on most of the BSDs.
This would need to be templated using SHELL_PATH and written in POSIX
sh (e.g., no `[[`).

> Icon=/usr/share/git-gui/lib/git-gui.ico

This would also need to be given an appropriate location based on the
build parameters.

> Type=Application
> Terminal=false
> Categories=Development;
> 
> 
> I think upstream has any interest to add this. Therefore I ask here."
> 
> -------------------------
> 
> The arch package maintainer proposed to try to to add this to upstream
> before just putting it into the arch package.
> Here I am asking if it could be added to git.

If you wanted to send a suitable patch for the file such that it were
appropriately built as part of the build process and installed, then we
could probably accept it. Such patches are usually created by using
`git format-patch` on one or multiple commits and then sent using `git
send-email`.  You can take a look at `Documentation/SubmittingPatches`
for more details.

I think such functionality would be generally useful, and probably be
beneficial to a wide variety of distributors.
-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 262 bytes --]