From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57FCF4D10A for ; Mon, 5 Feb 2024 23:32:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707175933; cv=none; b=i2XzgR5kmM1B/mML1H07kre0t4h0Nx0fIYpWDZVWY5t83NCzyu563HRcCy52tQ5d5o6Fz3YWOW8Aa43hv/vi8QKIWMuJtZOg9YaiXe3dPuvsHxGACYojxFeOPacLQqyXk5XxCXHUCvWZfwQY9Nk2vysG+E+sChMuRgoU00HJHBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707175933; c=relaxed/simple; bh=s+ba7UNNd4l6rcm9bL2S4lJrdSzTfcoNEa8bBjhT/34=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=XmPzTXiDd0eMoz4mhhMVKJbrSyVudBdxDeLdC4AIbL73X0H5lON8TOwGsElwyGfFNndAX294aUWJtN+YJsih+LT1FxogownEK4YA5PoLx8iF+fqjU9zBUI27u9erPp4hr46L2eSpjFroCwQ/IAbXdjIkgnOlEbngtdp57tiLdbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=LE6LHuze; arc=none smtp.client-ip=209.85.215.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="LE6LHuze" Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-5dc148f91faso2242725a12.0 for ; Mon, 05 Feb 2024 15:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707175931; x=1707780731; darn=lists.linux.dev; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2aHiF8WGptYmPz5iXMzHQodsCytVgYePbufYEivoKF8=; b=LE6LHuzevwrzhIfZIslheQ3GJPKABFmutIg58OSw3bKpbSHQQt5M6Yz6a5S2e7KRl8 bDveDwf3Mm9YUocf/vO119G+a1/9wcsDmF+UaSbo1GKrINlz+orK/21tFFRlrpIIMzF3 eDRTTXlSZfyHSmxC13c9QHVnY4ZUO7DPX9lvJ7U3mLetES3i68lKE39md8DQUoMwvM2V bkwFT3cmAUfSmR5JoQwr/wAyXQykvLVPORTq1rvZ6SYONkeDcSn1mP7vN2VgUYvejs7m rUqRlqgpoqBGNyjxElF4ebhMgRqmJnWLXKkz+2r/A0ty9AEkvcNzRAyBveBTrb86Jr9z 6aLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707175931; x=1707780731; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2aHiF8WGptYmPz5iXMzHQodsCytVgYePbufYEivoKF8=; b=NiyLkrNYTnyHzzT5TjdMQDRYGmYpcDD9EXoEeuR4aGsYfsOs3Mz4BFLNtNmDVcFFC+ dL37BrwaYJLa/aBY3gkpI6izBeUJukIXfpCHLj2gEZ5nqnSpsSTW2HL55edikr1bPvec zJetk1uj+H0wB+os1I23vfCMCFzGaEmH+SdEZiZeQNXEOI1oH+GY7NSEp0FFqZQcWFEJ 80rUSNc1LmlXpChOApuWOAF0G20DXkR25qxbXwvHtx9glKZV63Do0MgSaO1RbrxRVlef RbkK4Lm8zuo27W5IlRBgt5wanvz5lYqztNo/kjqYtTQrshoSHl8OsSba2jj/yJjCHOQ+ dp9g== X-Gm-Message-State: AOJu0YzWPbzCbxTIIwCTph9yZDS18uurP8/RNmiMIAUYa8gBgUlWmv4W UY0PGiot5AyBZDrpPz5mWiZMvJ6gHGN+Qa3/dfr6DaDH1eRvkV7AS4Kpl5JILiWxZtlbeGrTfQv QaA== X-Google-Smtp-Source: AGHT+IF9pQzmD6LV2uQvxz4V7wiPEQ0CxqP6mZJtdq5EHg/fzbnEEZKqUoflqGDmgX/A+FwqUkK4tjTOOUk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:2452:b0:1d9:68ae:b650 with SMTP id l18-20020a170903245200b001d968aeb650mr2496pls.12.1707175931486; Mon, 05 Feb 2024 15:32:11 -0800 (PST) Date: Mon, 5 Feb 2024 15:32:09 -0800 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240202234603.366925-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH] KVM: selftests: Fix GUEST_PRINTF() format warnings in ARM code From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Sat, Feb 03, 2024, Oliver Upton wrote: > On Fri, Feb 02, 2024 at 03:46:03PM -0800, Sean Christopherson wrote: > > Fix a pile of -Wformat warnings in the KVM ARM selftests code, almost all > > of which are benign "long" versus "long long" issues (selftests are 64-bit > > only, and the guest printf code treats "ll" the same as "l"). The code > > itself isn't problematic, but the warnings make it impossible to build ARM > > selftests with -Werror, which does detect real issues from time to time. > > > > Opportunistically have GUEST_ASSERT_BITMAP_REG() interpret set_expected, > > which is a bool, as an unsigned decimal value, i.e. have it print '0' or > > '1' instead of '0x0' or '0x1'. > > > > Signed-off-by: Sean Christopherson > > This all looks good to me. Just want to confirm before applying: you're > not planning any other patches that'll go through your tree that depend > on this right? Correct. There's one patch in kvm-x86/selftests (see below) that touches some of the same files, but unless I had a bad -ENOCOFFEE on Friday, there are no conflicts. [2/5] KVM: selftests: aarch64: Remove redundant newlines https://github.com/kvm-x86/linux/commit/95be17e4008b From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42352C48260 for ; Mon, 5 Feb 2024 23:32:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tavbv3ARV+XzJL7UJx6ZHl5HlifDAMqkOh4bXcnAey4=; b=gbI31/i1Ht+hiTsHBKmSh5VjRr e8ozHYdrQ2O82KCsu+2sKnJ+CQEgLxju+3gxyMVIgRZFcm9Fd52Q1B4VB7qcmXJyLYrRe4i8YfsSu DoDHxrzgcU1TFDKW8s4IfChFsy7vSNpLw8N8He7FMcsLqpuGqjh3C5jBAkYcT1UWXJ9Zu6pEls1cP 6TI5ACeVji8oNNOIJI92uv6ihE+5yWMlh9wqkUQAVuOwC0CPovUEAAfJsfm1RDfs1hsGo+NRLGXer tOdcrgqFjrPBRDa6M2AHT00yjacmCr4bSPq5R06Tamg2rcuSQMwpWi2iIqkdleSFkweyUvMpnZDg+ 4I7bZi+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX8Rk-00000005Yjn-0k29; Mon, 05 Feb 2024 23:32:16 +0000 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rX8Rh-00000005YjN-1Tj0 for linux-arm-kernel@lists.infradead.org; Mon, 05 Feb 2024 23:32:14 +0000 Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-5d8c924c8bbso6051441a12.3 for ; Mon, 05 Feb 2024 15:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707175931; x=1707780731; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=2aHiF8WGptYmPz5iXMzHQodsCytVgYePbufYEivoKF8=; b=0ZYKPHqXMzFSVUnJV+MjouKy03h7VX/YTyPUmOZP7z0vhQXavZEJwbP063Yxcv+xcC lxaa+0a1zgGZOGNJi72JqIg5ImiNJr7iY7YCTseHIVY5PVuGCzr4o2PBGNTbTTtwoRIq dCZC2MnlJna9Q8Q+lCJx5MuCzPA/bMsDDagEuZLODIhf3+ZAwmiqqbvnq8e+i6+KJGOA y2aVzgC2iFfiXtJy2m7xpAtp/nsCZQduQl+UkdlJUIAlDDLg/TputQ2lW1lEmnKERt/M MPFVctDB8kItV8YSXQKgkJVff1bdz+hQQ9u6N9V7R5Ce+pS5pW394PeMtSWJ4FDljMkD VSag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707175931; x=1707780731; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2aHiF8WGptYmPz5iXMzHQodsCytVgYePbufYEivoKF8=; b=KyN6XiS+JLnxOEnJkeuXnjlOtKusygVNCSBpTpKJ0F/84knR86K6L4egMDaPWyoEOr rQYOT7qyhpphslkNkGiI5kYj41BCvz1oT42WZU7lsACDq/MESydqE3LfRisxIvCQk1Y+ A6LbFo3l7WVNr5DFPv6S8qP2WrLybsGi96HsMJiCXc9fPjK0mUztjHSX2KhfJBirCBHw +pNtpOk7pBRRmC+XX/JYSQQh5Va+NDTV9+FGq6nJ3c7bQXJuN75avZDz5PslAkSCAQVv KznH19Iz5qesJbEs1UZGi0K9C9uI6V1yGWHl114537OqneHl4ogRq9nY2U//4EuU1Rl/ srKw== X-Gm-Message-State: AOJu0YzS/6lkdGgmKI3H1x8JoP7+pn1thnf9zYCE08E3K1b6Y60emM5v RvT0iUlBgmAuofulUANHbAwPRM5OZh6mJh/+yEMzK3Ti3qmdiiqY8a8tPIbgbYs5sxmce+RzN9W /jQ== X-Google-Smtp-Source: AGHT+IF9pQzmD6LV2uQvxz4V7wiPEQ0CxqP6mZJtdq5EHg/fzbnEEZKqUoflqGDmgX/A+FwqUkK4tjTOOUk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:2452:b0:1d9:68ae:b650 with SMTP id l18-20020a170903245200b001d968aeb650mr2496pls.12.1707175931486; Mon, 05 Feb 2024 15:32:11 -0800 (PST) Date: Mon, 5 Feb 2024 15:32:09 -0800 In-Reply-To: Mime-Version: 1.0 References: <20240202234603.366925-1-seanjc@google.com> Message-ID: Subject: Re: [PATCH] KVM: selftests: Fix GUEST_PRINTF() format warnings in ARM code From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240205_153213_413280_1F8920BD X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 03, 2024, Oliver Upton wrote: > On Fri, Feb 02, 2024 at 03:46:03PM -0800, Sean Christopherson wrote: > > Fix a pile of -Wformat warnings in the KVM ARM selftests code, almost all > > of which are benign "long" versus "long long" issues (selftests are 64-bit > > only, and the guest printf code treats "ll" the same as "l"). The code > > itself isn't problematic, but the warnings make it impossible to build ARM > > selftests with -Werror, which does detect real issues from time to time. > > > > Opportunistically have GUEST_ASSERT_BITMAP_REG() interpret set_expected, > > which is a bool, as an unsigned decimal value, i.e. have it print '0' or > > '1' instead of '0x0' or '0x1'. > > > > Signed-off-by: Sean Christopherson > > This all looks good to me. Just want to confirm before applying: you're > not planning any other patches that'll go through your tree that depend > on this right? Correct. There's one patch in kvm-x86/selftests (see below) that touches some of the same files, but unless I had a bad -ENOCOFFEE on Friday, there are no conflicts. [2/5] KVM: selftests: aarch64: Remove redundant newlines https://github.com/kvm-x86/linux/commit/95be17e4008b _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel