From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Ismael Luceno <ismael@iodev.co.uk>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [RFC PATCH v2] docs/website: Add Makefile to pre-generate the website
Date: Tue, 6 Feb 2024 16:10:52 +0100 [thread overview]
Message-ID: <ZcJL_Fie7-Xwy_Cg@landeda> (raw)
In-Reply-To: <20240206145353.19868-1-ismael@iodev.co.uk>
Ismael, All,
I'll do the rest of my review in this new iteration! ;-)
On 2024-02-06 15:53 +0100, Ismael Luceno spake thusly:
[--SNIP--]
> +${DEPLOYDIR}/%.html: ${SRCDIR}/%.smu ${conf-files}
> + mkdir -p "${@D}"
> + tmpfile=$$(mktemp) && \
> + ${AWK} -f incfile.awk $< | smu | tidy -q -m > "$$tmpfile" && \
Don't use pipes, otherwise we can't catch the failure of any
intermediate command. For example, if we can get the awk script to
properly fail in case of error, using pipes will not allow the Makefile
to catch issues.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-02-06 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 14:53 [Buildroot] [RFC PATCH v2] docs/website: Add Makefile to pre-generate the website Ismael Luceno
2024-02-06 15:04 ` Ismael Luceno
2024-02-06 15:10 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcJL_Fie7-Xwy_Cg@landeda \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=ismael@iodev.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.