From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Keith Busch <kbusch@meta.com>,
"sagi@grimberg.me" <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>,
Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>,
Alan Adamson <alan.adamson@oracle.com>
Subject: Re: [PATCH] nvme: move passthrough logging attribute to head
Date: Tue, 6 Feb 2024 21:54:04 -0800 [thread overview]
Message-ID: <ZcMa_GF34i9GGPpe@kbusch-mbp> (raw)
In-Reply-To: <cb287226-8b73-421a-9fa0-ee1b110912dd@nvidia.com>
On Wed, Feb 07, 2024 at 04:02:42AM +0000, Chaitanya Kulkarni wrote:
> On 2/6/24 09:50, Keith Busch wrote:
> > From: Keith Busch <kbusch@kernel.org>
> >
> > The namespace does not have attributes, but the head does. Move the new
> > attribute to that structure instead of dereferncing the wrong type.
> >
> > And while we're here, fix the reverse-tree coding style.
> >
> > Fixes: 9f079dda14339e ("nvme: allow passthru cmd error logging")
> > Reported-by: Tasmiya Nalatwad <tasmiya@linux.vnet.ibm.com>
> > Cc: Alan Adamson <alan.adamson@oracle.com>
> > Signed-off-by: Keith Busch <kbusch@kernel.org>
> > ---
> >
>
> Looks good.
>
> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
>
> BTW I've also posted comment correction patch with Alan's review in this
> area, please have a look.
Right, I saw that but the comments would need to be updated again after
this fix. I'll take another look tomorrow and maybe just change it when
applying.
next prev parent reply other threads:[~2024-02-07 5:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 17:50 [PATCH] nvme: move passthrough logging attribute to head Keith Busch
2024-02-07 4:02 ` Chaitanya Kulkarni
2024-02-07 5:54 ` Keith Busch [this message]
2024-02-07 8:43 ` Tasmiya Nalatwad
2024-02-07 18:28 ` alan.adamson
2024-02-07 18:40 ` Keith Busch
2024-02-08 8:00 ` Tasmiya Nalatwad
2024-02-12 6:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcMa_GF34i9GGPpe@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=alan.adamson@oracle.com \
--cc=chaitanyak@nvidia.com \
--cc=hch@lst.de \
--cc=kbusch@meta.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=tasmiya@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.