From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, arei.gonglei@huawei.com,
eblake@redhat.com, eduardo@habkost.net, fan.ni@samsung.com,
farosas@suse.de, hreitz@redhat.com, jasowang@redhat.com,
jiri@resnulli.us, jonathan.cameron@huawei.com,
kkostiuk@redhat.com, kraxel@redhat.com, kwolf@redhat.com,
lukasstraub2@web.de, marcandre.lureau@redhat.com,
marcel.apfelbaum@gmail.com, michael.roth@amd.com, mst@redhat.com,
pbonzini@redhat.com, peter.maydell@linaro.org, peterx@redhat.com,
philmd@linaro.org, pizhenwei@bytedance.com,
qemu-block@nongnu.org, stefanb@linux.ibm.com,
wangyanan55@huawei.com
Subject: Re: [PATCH 15/15] qapi: Add missing union tag documentation
Date: Wed, 7 Feb 2024 08:42:03 +0000 [thread overview]
Message-ID: <ZcNCW-j9mC2v2qwv@redhat.com> (raw)
In-Reply-To: <20240205074709.3613229-16-armbru@redhat.com>
On Mon, Feb 05, 2024 at 08:47:09AM +0100, Markus Armbruster wrote:
> Low-hanging fruit, and except for StatsFilter, the only members of
> these unions lacking documentation.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 12 ++++++++++++
> qapi/block-export.json | 2 ++
> qapi/char.json | 2 ++
> qapi/crypto.json | 2 ++
> qapi/machine.json | 4 ++++
> qapi/migration.json | 2 ++
> qapi/pragma.json | 16 ----------------
> qapi/sockets.json | 2 ++
> qapi/stats.json | 2 ++
> qapi/transaction.json | 2 ++
> qapi/ui.json | 2 ++
> qapi/yank.json | 2 ++
> 12 files changed, 34 insertions(+), 16 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2024-02-07 8:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 7:46 [PATCH 00/15] qapi: Require member documentation (with loophole) Markus Armbruster
2024-02-05 7:46 ` [PATCH 01/15] docs/devel/qapi-code-gen: Normalize version refs x.y.0 to just x.y Markus Armbruster
2024-02-07 8:15 ` Daniel P. Berrangé
2024-02-05 7:46 ` [PATCH 02/15] docs/devel/qapi-code-gen: Tweak doc comment whitespace Markus Armbruster
2024-02-07 8:18 ` Daniel P. Berrangé
2024-02-05 7:46 ` [PATCH 03/15] qapi/block-core: Fix BlockLatencyHistogramInfo doc markup Markus Armbruster
2024-02-07 8:18 ` Daniel P. Berrangé
2024-02-05 7:46 ` [PATCH 04/15] qapi: Indent tagged doc comment sections properly Markus Armbruster
2024-02-07 8:19 ` Daniel P. Berrangé
2024-02-05 7:46 ` [PATCH 05/15] sphinx/qapidoc: Drop code to generate doc for simple union tag Markus Armbruster
2024-02-07 8:20 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 06/15] qapi: Require member documentation (with loophole) Markus Armbruster
2024-02-07 8:31 ` Daniel P. Berrangé
2024-02-12 9:10 ` Markus Armbruster
2024-02-05 7:47 ` [PATCH 07/15] qga/qapi-schema: Clean up documentation of guest-set-memory-blocks Markus Armbruster
2024-02-07 8:32 ` Daniel P. Berrangé
2024-02-20 8:37 ` Konstantin Kostiuk
2024-02-05 7:47 ` [PATCH 08/15] qga/qapi-schema: Clean up documentation of guest-set-vcpus Markus Armbruster
2024-02-07 8:32 ` Daniel P. Berrangé
2024-02-20 8:57 ` Konstantin Kostiuk
2024-02-05 7:47 ` [PATCH 09/15] qga/qapi-schema: Plug trivial documentation holes Markus Armbruster
2024-02-07 8:34 ` Daniel P. Berrangé
2024-02-08 6:49 ` Markus Armbruster
2024-02-05 7:47 ` [PATCH 10/15] qapi/yank: Clean up documentaion of yank Markus Armbruster
2024-02-07 8:35 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 11/15] qapi/dump: Clean up documentation of DumpGuestMemoryCapability Markus Armbruster
2024-02-07 8:35 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 12/15] qapi: Plug trivial documentation holes around former simple unions Markus Armbruster
2024-02-07 8:36 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 13/15] qapi: Improve documentation of file descriptor socket addresses Markus Armbruster
2024-02-07 8:40 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 14/15] qapi: Move @String out of common.json to discourage reuse Markus Armbruster
2024-02-07 8:41 ` Daniel P. Berrangé
2024-02-05 7:47 ` [PATCH 15/15] qapi: Add missing union tag documentation Markus Armbruster
2024-02-07 8:42 ` Daniel P. Berrangé [this message]
2024-02-07 3:20 ` [PATCH 00/15] qapi: Require member documentation (with loophole) Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcNCW-j9mC2v2qwv@redhat.com \
--to=berrange@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=fan.ni@samsung.com \
--cc=farosas@suse.de \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=jonathan.cameron@huawei.com \
--cc=kkostiuk@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=lukasstraub2@web.de \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pizhenwei@bytedance.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.ibm.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.