All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kousik Sanagavarapu <five231003@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2024, #03; Tue, 6)
Date: Wed, 7 Feb 2024 18:35:17 +0530	[thread overview]
Message-ID: <ZcOADbiXv81OzztB@five231003> (raw)
In-Reply-To: <xmqqcyt9dqgi.fsf@gitster.g>

Hi,

Junio C Hamano <gitster@pobox.com> wrote:

> * ak/color-decorate-symbols (2023-10-23) 7 commits
>  - log: add color.decorate.pseudoref config variable
>  - refs: exempt pseudorefs from pattern prefixing
>  - refs: add pseudorefs array and iteration functions
>  - log: add color.decorate.ref config variable
>  - log: add color.decorate.symbol config variable
>  - log: use designated inits for decoration_colors
>  - config: restructure color.decorate documentation
> 
>  A new config for coloring.
> 
>  Needs review.
>  source: <20231023221143.72489-1-andy.koppe@gmail.com>

These commits have a design conflict [1] with the series

> * kn/for-all-refs (2024-01-29) 4 commits
>   (merged to 'next' on 2024-01-30 at e7a9234a8b)
>  + for-each-ref: avoid filtering on empty pattern
>  + refs: introduce `refs_for_each_all_refs()`
>  + refs: extract out `loose_fill_ref_dir_regular_file()`
>  + refs: introduce `is_pseudoref()` and `is_headref()`
> 
>  "git for-each-ref" filters its output with prefixes given from the
>  command line, but it did not honor an empty string to mean "pass
>  everything", which has been corrected.
> 
>  Reverted out of 'next' to revamp its UI.
>  source: <20240129113527.607022-1-karthik.188@gmail.com

So maybe change "Needs review" to "Not ready to be reviewed yet"? as
people who read it might not be aware that it is kind of an "out-dated"
(not surprising since it was sent last October) implementation and
reviewing needs to be held off till a reroll is sent.

Thanks

[1] I have detailed the conflict out here:

	https://lore.kernel.org/git/ZcEvLwp0t8-rcyGn@five231003/

      reply	other threads:[~2024-02-07 13:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07  1:15 What's cooking in git.git (Feb 2024, #03; Tue, 6) Junio C Hamano
2024-02-07 13:05 ` Kousik Sanagavarapu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZcOADbiXv81OzztB@five231003 \
    --to=five231003@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.