From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF313C4828F for ; Wed, 7 Feb 2024 16:36:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0BE2E7F1; Wed, 7 Feb 2024 17:36:42 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0BE2E7F1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1707323812; bh=VoywwgjLXTwUOhSbbLxontbmbKuuFTrPOSRwdOlJD3g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=G0gE8OZrnGpdjVuTUiyO9045Y57uxsh6jPj96oFE+SaYMm0IgWI+3OWKpCd1bms2Q mELkqychYx6tZePAqXSkRloQi3unxl0FBPV/ffNA5r0kjd2dvzNVWJl4uXmNxtmQxT gtkMJ7xMNYalQtzoALjKoAv//E94U6CdltNs/Gkk= Received: by alsa1.perex.cz (Postfix, from userid 50401) id EC3ECF805A0; Wed, 7 Feb 2024 17:36:19 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 7E85FF80548; Wed, 7 Feb 2024 17:36:19 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 075EEF801EB; Wed, 7 Feb 2024 17:36:15 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 14C80F800EE for ; Wed, 7 Feb 2024 17:36:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 14C80F800EE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=dYfvwdMz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1707323769; x=1738859769; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=VoywwgjLXTwUOhSbbLxontbmbKuuFTrPOSRwdOlJD3g=; b=dYfvwdMzDrPKaLas1a+SxgRz8ovScRjHoqJLzZ1nchSPjE/UQ3i5rXt1 8UuQf5kbr+wnT+VP+7p499fWmaLsWKwXrYCdKUyVKJi5oq4YYTr+6/cbf mrOODea4pY1wbRSmi54Rx1S01U9gI3KyzRozQBI2O0JBlybR5Z7fyS1HI D0fBP//JASyQhiI2TwBq6ixwx1KQ2sixcdFf+UvgLWwTfBtXZZGos3QdG z/QVIB2aKAPtRuXwyVmAfoId9zEoH1Ecn4Q4i+1iQFhVtd75LIbFZ27QH /8DCN8Gsu2HvlR9yGzihGclKoVEzs89SmT0gZ1Xzk86vG18JxiJNZnrAV A==; X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="12384564" X-IronPort-AV: E=Sophos;i="6.05,251,1701158400"; d="scan'208";a="12384564" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 08:36:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10977"; a="910038493" X-IronPort-AV: E=Sophos;i="6.05,251,1701158400"; d="scan'208";a="910038493" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2024 08:35:59 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rXktw-00000002eqb-1cXu; Wed, 07 Feb 2024 18:35:56 +0200 Date: Wed, 7 Feb 2024 18:35:56 +0200 From: Andy Shevchenko To: Mark Brown Cc: Shenghao Ding , lgirdwood@gmail.com, perex@perex.cz, pierre-louis.bossart@linux.intel.com, 13916275206@139.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, liam.r.girdwood@intel.com, bard.liao@intel.com, mengdong.lin@intel.com, yung-chuan.liao@linux.intel.com, baojun.xu@ti.com, kevin-lu@ti.com, navada@ti.com, tiwai@suse.de, soyer@irl.hu Subject: Re: [PATCH v7] ASoc: tas2783: Add tas2783 codec driver Message-ID: References: <20240207054743.1504-1-shenghao-ding@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: LKPUXEPMWVCZPUJGVGYJZ6DJB4LDBOC7 X-Message-ID-Hash: LKPUXEPMWVCZPUJGVGYJZ6DJB4LDBOC7 X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Feb 07, 2024 at 03:30:16PM +0000, Mark Brown wrote: > On Wed, Feb 07, 2024 at 04:40:38PM +0200, Andy Shevchenko wrote: > > On Wed, Feb 07, 2024 at 01:47:42PM +0800, Shenghao Ding wrote: ... > > > + .max_register = 0x44ffffff, > > > I'm always wondering how this can work in debugfs when one tries to dump all > > registers... > > regmap will filter out non-readable registers from what it shows in > debugfs so sparse regmaps will end up much smaller than they might look. > The debugfs code also has support for seeking into the output (since > each register is a fixed size) so we'll only actually render whatever is > being read in an individual read(). Thanks, good to know. ... > > > +static const struct dev_pm_ops tas2783_sdca_pm = { > > > + SET_SYSTEM_SLEEP_PM_OPS(tas2783_sdca_dev_suspend, > > > + tas2783_sdca_dev_resume) > > > + SET_RUNTIME_PM_OPS(tas2783_sdca_dev_suspend, > > > + tas2783_sdca_dev_resume, NULL) > > > +}; > > > Use new PM macros. > > ...which are? SYSTEM_SLEEP_PM_OPS() RUNTIME_PM_OPS() and pm_ptr() in the .driver.pm assignment. -- With Best Regards, Andy Shevchenko