From: Pavel Machek <pavel@ucw.cz>
To: Justin Stitt <justinstitt@google.com>
Cc: Kees Cook <keescook@chromium.org>,
Andy Shevchenko <andy@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] string: Allow 2-argument strscpy()
Date: Wed, 7 Feb 2024 18:51:45 +0100 [thread overview]
Message-ID: <ZcPDMZFPY08S4MGR@duo.ucw.cz> (raw)
In-Reply-To: <20240129215525.4uxchtrywzzsrauc@google.com>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi!
> > Using sizeof(dst) is the overwhelmingly common case for strscpy().
> > Instead of requiring this everywhere, allow a 2-argument version to be
> > used that will use the sizeof() internally.
>
> Yeah, this is definitely the case. I have a ton of patches replacing
> strncpy with strscpy [1] and many of them match the pattern of:
> | strscpy(dest, src, sizeof(dest))
>
> BTW, this hack for function overloading is insane. Never really looked into
> it before.
This hack is insane, but this is also highly confusing, please don't
do this.
BR,
Pavel
--
People of Russia, stop Putin before his war on Ukraine escalates.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2024-02-07 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 20:29 [RFC] string: Allow 2-argument strscpy() Kees Cook
2024-01-29 21:55 ` Justin Stitt
2024-01-29 22:02 ` Kees Cook
2024-01-29 23:27 ` Andy Shevchenko
2024-01-29 23:30 ` Andy Shevchenko
2024-02-07 17:51 ` Pavel Machek [this message]
2024-02-10 13:02 ` David Laight
2024-02-10 13:51 ` David Laight
2024-02-01 22:29 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcPDMZFPY08S4MGR@duo.ucw.cz \
--to=pavel@ucw.cz \
--cc=andy@kernel.org \
--cc=justinstitt@google.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.