From: Tejun Heo <tj@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux PM <linux-pm@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Nathan Chancellor <nathan@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Naohiro.Aota@wdc.com, kernel-team@meta.com
Subject: Re: [PATCH v1] PM: sleep: Restore asynchronous device resume optimization
Date: Wed, 7 Feb 2024 08:58:01 -1000 [thread overview]
Message-ID: <ZcPSuUBoL_EDvcTF@slm.duckdns.org> (raw)
In-Reply-To: <2f125955-8c7c-465c-938c-8768f7ca360b@samsung.com>
On Wed, Feb 07, 2024 at 07:55:51PM +0100, Marek Szyprowski wrote:
> On 07.02.2024 17:39, Tejun Heo wrote:
> > On Wed, Feb 07, 2024 at 12:25:46PM +0100, Rafael J. Wysocki wrote:
> >> The other one is that what happens during async resume does not meet
> >> the assumptions of commit 5797b1c18919 (for example, it can easily
> >> produce a chain of interdependent work items longer than 8) and so it
> >> breaks things.
> > Ah, that's fascinating. But aren't CPUs all brought up online before devices
> > are resumed? If so, the max_active should already be way higher than the
> > WQ_DFL_MIN_ACTIVE. Also, are these multi node NUMA machines? Otherwise, it
> > really shouldn't affect anything. One easy way to verify would be just
> > bumping up WQ_DFL_MIN_ACTIVE and see what happens.
>
> I've increased WQ_DFL_MIN_ACTIVE from 8 to 32 and all the system
> suspend/resume issues went away. :)
Ah, okay, that's surprising. Lemme look at the code again. I gotta be
missing something.
Thanks.
--
tejun
next prev parent reply other threads:[~2024-02-07 18:58 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240207103144eucas1p16b601a73ff347d2542f8380b25921491@eucas1p1.samsung.com>
2024-01-09 16:59 ` [PATCH v1] PM: sleep: Restore asynchronous device resume optimization Rafael J. Wysocki
2024-01-10 10:37 ` Stanislaw Gruszka
2024-01-10 12:33 ` Rafael J. Wysocki
2024-01-10 14:05 ` Stanislaw Gruszka
2024-01-11 7:58 ` Stanislaw Gruszka
2024-01-11 12:01 ` Rafael J. Wysocki
2024-02-07 10:31 ` Marek Szyprowski
2024-02-07 10:38 ` Rafael J. Wysocki
2024-02-07 11:16 ` Marek Szyprowski
2024-02-07 11:25 ` Rafael J. Wysocki
2024-02-07 16:39 ` Tejun Heo
2024-02-07 18:41 ` Rafael J. Wysocki
2024-02-07 18:55 ` Marek Szyprowski
2024-02-07 18:58 ` Tejun Heo [this message]
2024-02-07 19:48 ` Tejun Heo
2024-02-07 19:54 ` Rafael J. Wysocki
2024-02-07 21:30 ` Marek Szyprowski
2024-02-07 21:35 ` Tejun Heo
2024-02-08 7:47 ` Marek Szyprowski
2024-02-09 0:20 ` Tejun Heo
2024-02-12 14:57 ` Rafael J. Wysocki
2024-02-07 10:59 ` Rafael J. Wysocki
2024-02-10 14:04 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcPSuUBoL_EDvcTF@slm.duckdns.org \
--to=tj@kernel.org \
--cc=Naohiro.Aota@wdc.com \
--cc=jiangshanlai@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=nathan@kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stanislaw.gruszka@linux.intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.