From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Avihai Horon" <avihaih@nvidia.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH v3 0/6] migration/multifd: Fix channel creation vs. cleanup races
Date: Thu, 8 Feb 2024 11:01:17 +0800 [thread overview]
Message-ID: <ZcRD_R0lR6MwHZe6@x1n> (raw)
In-Reply-To: <20240206215118.6171-1-farosas@suse.de>
On Tue, Feb 06, 2024 at 06:51:12PM -0300, Fabiano Rosas wrote:
> Based-on: 20240202102857.110210-1-peterx@redhat.com
> [PATCH v2 00/23] migration/multifd: Refactor ->send_prepare() and cleanups
> https://lore.kernel.org/r/20240202102857.110210-1-peterx@redhat.com
>
> Hi,
>
> For v3 I fixed the refcounting issue spotted by Avihai. The situation
> there is a bit clunky due to historical reasons. The gist is that we
> have an assumption that channel creation never fails after p->c has
> been set, so when 'p->c == NULL' we have to unref and when 'p->c !=
> NULL' the cleanup code will do the unref.
>
> CI run: https://gitlab.com/farosas/qemu/-/pipelines/1166889341
Apologize if I queue this too fast, but i'll disappear tomorrow, so I want
to have this thread race fixed soon. I hope that's already complete from
angle of all race can happen, but if otherwise we work on top.
queued, thanks.
--
Peter Xu
prev parent reply other threads:[~2024-02-08 3:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 21:51 [PATCH v3 0/6] migration/multifd: Fix channel creation vs. cleanup races Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 1/6] migration/multifd: Join the TLS thread Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 2/6] migration/multifd: Remove p->running Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 3/6] migration/multifd: Move multifd_send_setup error handling in to the function Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 4/6] migration/multifd: Move multifd_send_setup into migration thread Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 5/6] migration/multifd: Unify multifd and TLS connection paths Fabiano Rosas
2024-02-06 21:51 ` [PATCH v3 6/6] migration/multifd: Add a synchronization point for channel creation Fabiano Rosas
2024-02-07 2:29 ` [PATCH v3 0/6] migration/multifd: Fix channel creation vs. cleanup races Peter Xu
2024-02-07 13:31 ` Fabiano Rosas
2024-02-08 3:32 ` Peter Xu
2024-02-08 3:01 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcRD_R0lR6MwHZe6@x1n \
--to=peterx@redhat.com \
--cc=avihaih@nvidia.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.