From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Kevin Tian <kevin.tian@intel.com>, Paul Durrant <paul@xen.org>
Subject: Re: [PATCH 5/7] VT-d: move ats_device() to the sole file it's used from
Date: Fri, 9 Feb 2024 09:15:32 +0100 [thread overview]
Message-ID: <ZcXfJHs6DWNvvTYw@macbook> (raw)
In-Reply-To: <c6d803ba-9478-4ab0-9ab6-a9af94808682@suse.com>
On Mon, Feb 05, 2024 at 02:56:55PM +0100, Jan Beulich wrote:
> ..., thus allowing it to become static, and thus reducing scope overlap
> between it and pci_ats_device(). There's nothing x86-specific about this
> function anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Roger Pau Monné zroger.pau@citrix.com>
FWIW, the function would better return a boolean, as none of the
callers care about the position of the ATS capability, and use it as
an indication that ATS is supported.
Thanks, Roger.
next prev parent reply other threads:[~2024-02-09 8:15 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 13:53 [PATCH 0/7] VT-d: SATC handling and ATS tidying Jan Beulich
2024-02-05 13:55 ` [PATCH 1/7] VT-d: parse ACPI "SoC Integrated Address Translation Cache Reporting Structure"s Jan Beulich
2024-02-08 9:17 ` Roger Pau Monné
2024-02-08 15:29 ` Jan Beulich
2024-02-09 9:00 ` Roger Pau Monné
2024-02-12 9:32 ` Jan Beulich
2024-02-12 10:06 ` Roger Pau Monné
2024-02-05 13:55 ` [PATCH 2/7] IOMMU: rename and re-type ats_enabled Jan Beulich
2024-02-08 11:49 ` Roger Pau Monné
2024-02-08 15:49 ` Jan Beulich
2024-02-12 9:39 ` Roger Pau Monné
2024-02-12 10:45 ` Jan Beulich
2024-02-12 15:38 ` Roger Pau Monné
2024-02-12 15:59 ` Jan Beulich
2024-02-05 13:56 ` [PATCH 3/7] VT-d: respect ACPI SATC's ATC_REQUIRED flag Jan Beulich
2024-02-08 12:42 ` Roger Pau Monné
2024-02-12 11:06 ` Jan Beulich
2024-02-05 13:56 ` [PATCH 4/7] VT-d: replace find_ats_dev_drhd() Jan Beulich
2024-02-08 17:31 ` Roger Pau Monné
2024-02-09 7:06 ` Jan Beulich
2024-02-09 8:11 ` Roger Pau Monné
2024-02-05 13:56 ` [PATCH 5/7] VT-d: move ats_device() to the sole file it's used from Jan Beulich
2024-02-09 8:15 ` Roger Pau Monné [this message]
2024-02-05 13:57 ` [PATCH 6/7] VT-d: move dev_invalidate_iotlb() " Jan Beulich
2024-02-09 8:25 ` Roger Pau Monné
2024-02-09 14:44 ` Jan Beulich
2024-02-05 13:57 ` [PATCH 7/7] VT-d: move {,un}map_vtd_domain_page() Jan Beulich
2024-02-09 8:39 ` Roger Pau Monné
2024-02-12 9:46 ` Jan Beulich
2024-02-12 10:11 ` Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZcXfJHs6DWNvvTYw@macbook \
--to=roger.pau@citrix.com \
--cc=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.